Attention is currently required from: jolly, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email )
Change subject: ASCI: Add support flags to mobile (and VTY) for VGCS/VBS ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/host/layer23/include/osmocom/bb/common/settings.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/34483/comment/33d8b8c3_7df9aa5b PS5, Line 165: uint8_t vgcs; /* support of VGCS */
bool […]
IMO, we either change the existing code to use `bool` and then require all new fields to be `bool` or stay consistent with the existing code. If we use `bool` right now, the coding style becomes inconsistent. And then, who and when is going to submit a patch converting everything to `bool`? All in all, I prefer consistency and believe that we should not block because of this.