Attention is currently required from: jolly, pespin.

Patch set 5:Code-Review +1

View Change

1 comment:

• File src/host/layer23/include/osmocom/bb/common/settings.h:

  • Patch Set #5, Line 165: uint8_t vgcs; /* support of VGCS */

    bool […]

    IMO, we either change the existing code to use `bool` and then require all new fields to be `bool` or stay consistent with the existing code. If we use `bool` right now, the coding style becomes inconsistent. And then, who and when is going to submit a patch converting everything to `bool`? All in all, I prefer consistency and believe that we should not block because of this.

To view, visit change 34483. To unsubscribe, or for help writing mail filters, visit settings.