[M] Change in libosmo-gprs[master]: rlcmac: Fix Starting Time rfn->fn calculation

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 ) Change subject: rlcmac: Fix Starting Time rfn->fn calculation ...................................................................... Patch Set 3: (3 comments) File src/rlcmac/rlcmac_dec.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/98766f3e_727ca34f PS3, Line 434: rfn_to_fn May be a good idea to have this function in libosmocore.git (`src/gsm/gsm0502.c`), since we need this calculation in several projects (osmocom-bb.git, osmo-pcu.git) IIRC. File tests/rlcmac/Makefile.am: https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/c693e25d_c77ed27f PS3, Line 52: rlcmac_types_test_LDADD = $(LDADD) " No newline at end of right file. " File tests/rlcmac/rlcmac_types_test.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/76d3c34a_07fbafc1 PS3, Line 54: printf Why not printing to `stderr`? It's easier to read/review stuff when it's in one file. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I00741289333853a8db472950ee2ac38dc2c74fd3 Gerrit-Change-Number: 34044 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Aug 2023 15:03:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment