Attention is currently required from: pespin.

View Change

3 comments:

• File src/rlcmac/rlcmac_dec.c:

  • Patch Set #3, Line 434: rfn_to_fn

    May be a good idea to have this function in libosmocore.git (`src/gsm/gsm0502.c`), since we need this calculation in several projects (osmocom-bb.git, osmo-pcu.git) IIRC.

• File tests/rlcmac/Makefile.am:

  • Patch Set #3, Line 52: rlcmac_types_test_LDADD = $(LDADD)

    " No newline at end of right file. "

• File tests/rlcmac/rlcmac_types_test.c:

  • Patch Set #3, Line 54: printf

    Why not printing to `stderr`? It's easier to read/review stuff when it's in one file.

To view, visit change 34044. To unsubscribe, or for help writing mail filters, visit settings.