Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28048 )
Change subject: msc: add test for OS#5532: crash from CM Serv Rej ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28048/comment/d829379c_c9f39... PS1, Line 6815: BSSAP.send(ts_PDU_DTAP_MO(ts_CM_SERV_REQ(CM_TYPE_MO_SMS, mi))); Ah, indeed. I was confused because {BTS,BSC}_Tests.f_est_dchan() does not send anything on the established channel, while BSC_ConnectionHandler.f_establish_fully() does send a CM Service Request. Nevermind.
Is the comment above not clear enough?
If you said "Send *another* CM Serv Req ..." it would be cleaner, IMO.
Not critical, giving CR+2.