Attention is currently required from: neels.

Patch set 1:Code-Review +2

View Change

1 comment:

• File msc/MSC_Tests.ttcn:

  • Patch Set #1, Line 6815: BSSAP.send(ts_PDU_DTAP_MO(ts_CM_SERV_REQ(CM_TYPE_MO_SMS, mi)));

    Ah, indeed. I was confused because {BTS,BSC}_Tests.f_est_dchan() does not send anything on the established channel, while BSC_ConnectionHandler.f_establish_fully() does send a CM Service Request. Nevermind.

    Is the comment above not clear enough?

    If you said "Send *another* CM Serv Req ..." it would be cleaner, IMO.

    Not critical, giving CR+2.

To view, visit change 28048. To unsubscribe, or for help writing mail filters, visit settings.