27 Aug
2025
27 Aug
'25
8:57 a.m.
Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/40936?usp=email )
Change subject: contrib: add a tool to parse the SIMA response from an eUICC
......................................................................
Patch Set 1:
(4 comments)
File contrib/sima-response-tool.py:
https://gerrit.osmocom.org/c/pysim/+/40936/comment/ef39092f_02ef0a29?usp=em… :
PS1, Line 57: 8 : 'template-not-supported',
: 9 : 'feature-not-supported',
```suggestion
8 : 'lib-not-supported',
9 : 'template-not-supported',
```
https://gerrit.osmocom.org/c/pysim/+/40936/comment/a8664bda_356868c9?usp=em… :
PS1, Line 74: propritary
```suggestion
return "%d = %04x (proprietary)" % (status, status)
```
(same typo in other places in this file)
https://gerrit.osmocom.org/c/pysim/+/40936/comment/cc8717fb_99af552b?usp=em… :
PS1, Line 77: return "%d (unknown, propritary?)" % (status, status)
contrib/sima-response-tool.py:77:11: E1305: Too many arguments for format string
(too-many-format-args)
https://gerrit.osmocom.org/c/pysim/+/40936/comment/7a0dd315_06111ac3?usp=em… :
PS1, Line 93: if euicc_response_decoded.get('profileInstallationAborted',
False) is None:
Is comparing against `is None` correct here? I wonder if it should be compared against `is
True` as the print then says `True`.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e
Gerrit-Change-Number: 40936
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Aug 2025 06:57:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No