Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33097 )
Change subject: Port to new libosmogsm 'struct osmo_sub_auth_data2' ......................................................................
Patch Set 3:
(2 comments)
File include/osmocom/hlr/db.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/cb81afa1_f4b73297 PS2, Line 124: /* Like struct osmo_sub_auth_data2, but the keys are in hexdump representation.
intentional rename? is sub_auth_data_str also used for osmo_sub_auth_data2?
yes. Since after this patch the code is now only using sub_auth_data2, there is no usage of osmo_sub_auth_data left, and hence the comment would refer to an unused struct type if it's not changed here.
File src/db_hlr.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/96f03b91_4e930295 PS2, Line 289: if (!osmo_is_hexstr(aud->u.umts.k, 32, 64, true)) {
(this patch intends no change of length, right?)
you are correct, this belongs into Ibbde68484c904507a15c35cbfdf88cd47d0c7039