Attention is currently required from: pespin, dexter.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 )
Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ......................................................................
Patch Set 9:
(4 comments)
File src/libosmo-mgcp/mgcp_network.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/00e89359_c2fc46e4 PS9, Line 704: switch(msgb_length(msg)) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/dc1b001a_398a1359 PS9, Line 704: switch(msgb_length(msg)) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/cb2a49a9_6640a804 PS9, Line 706: case GSM_HR_BYTES + sizeof(struct rtp_hdr): code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/89d6e140_9512b368 PS9, Line 706: case GSM_HR_BYTES + sizeof(struct rtp_hdr): please, no spaces at the start of a line