[M] Change in osmo-mgw[master]: mgw: rtp-patch rfc5993hr: convert to each end's respective format

Attention is currently required from: falconia, neels. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email ) Change subject: mgw: rtp-patch rfc5993hr: convert to each end's respective format ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Patchset: PS2: Idea: It may make sense at some point to get rid of such VTY comamnd and somehow be able to specify specific GSM RTP HR format over MGCP. There may even be a ticket abotu thtat iirc? File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/28545f3b_7080b89d?usp… : PS2, Line 1660: strcmp(conn_src->end.cset.codec->subtype_name, "GSM-HR-08") == 0 && conn_src->end.rfc5993_hr_convert) { I'd say better split this line into 2. https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/18d1bec3_b81f2fb6?usp… : PS2, Line 1666: mgcp_conn_watchdog_kick(conn_src->conn); It probably makes sense to call this even if output is wrong, but not a hard opinion. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b446ad83c540fb8b7e1aae24b78c27010212d64 Gerrit-Change-Number: 39869 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Mar 2025 11:27:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes