Attention is currently required from: iedemam, neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28165
)
Change subject: stats: new trackers for lchan life duration (v2)
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/85bb77b3_81b5d41e
PS1, Line 768: if (!lchan->activate.concluded)
I wonder: you are probably then not counting last
interval since .concluded was set to true.
Nevermind this one, I was confused. I
think the comment is actually confusing. It's not "inactive lchans" but
"lchans not yet active" or "lchans in process of being activated"
right?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28165
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie3771233ecbd4bc24a24fb22c1064a18e7b8b2b0
Gerrit-Change-Number: 28165
Gerrit-PatchSet: 1
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 19 May 2022 20:08:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment