Attention is currently required from: iedemam, neels.
View Change
1 comment:
File src/osmo-bsc/bts.c:
Patch Set #1, Line 768: if (!lchan->activate.concluded)
I wonder: you are probably then not counting last interval since .concluded was set to true.
Nevermind this one, I was confused. I think the comment is actually confusing. It's not "inactive lchans" but "lchans not yet active" or "lchans in process of being activated" right?
To view, visit change 28165. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie3771233ecbd4bc24a24fb22c1064a18e7b8b2b0
Gerrit-Change-Number: 28165
Gerrit-PatchSet: 1
Gerrit-Owner: iedemam <michael@kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: iedemam <michael@kapsulate.com>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Comment-Date: Thu, 19 May 2022 20:08:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment