Attention is currently required from: daniel, fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email )
Change subject: card_key_provider: add PostgreSQL support ......................................................................
Patch Set 7:
(2 comments)
File contrib/csv-to-pgsql.py:
https://gerrit.osmocom.org/c/pysim/+/41508/comment/bb352254_c969d0db?usp=ema... : PS5, Line 38: table_name
Maybe do the `self. […]
I am not sure, yes we could do the .lower() here. I think its ok to keep the .lower() calls in the queries for consistency.
https://gerrit.osmocom.org/c/pysim/+/41508/comment/93780c15_6ce6f79b?usp=ema... : PS5, Line 132: %s;", (self.table.lower(),))
Why not using `SQL("...").format(... […]
In this case it was possible to spare the SQL(). The escaping for values is done by the execute method. However, identifier names cannot be run through the escaping of the execute method. That is what SQL().format is then used for.