Attention is currently required from: daniel, fixeria, laforge.

View Change

2 comments:

• File contrib/csv-to-pgsql.py:

  • Patch Set #5, Line 38: table_name

    Maybe do the `self. […]

    I am not sure, yes we could do the .lower() here. I think its ok to keep the .lower() calls in the queries for consistency.

  • Patch Set #5, Line 132: %s;", (self.table.lower(),))

    Why not using `SQL("...").format(... […]

    In this case it was possible to spare the SQL(). The escaping for values is done by the execute method. However, identifier names cannot be run through the escaping of the execute method. That is what SQL().format is then used for.

To view, visit change 41508. To unsubscribe, or for help writing mail filters, visit settings.