[XL] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft

Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email ) Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Hi @nhofmeyr@sysmocom.de, I wrote some comments while digesting the patch, feel free to apply whatever you think makes sense. In general looks promising. What I would really like, is that you split each of the worker threads into its own file, otherwise it's a bit mindblowing trying to digest that (for me now, and for any reader that comes after me when the code is merged and has to debug it). So I say: Please first split those into different files if possible and then I'll give a more through review through each of them on that code. It should be mostly moving functions from one file to another (and if a lot other work is needed, then to me it also means something is entangled where it shouldn't, so it's good it becomes untangled). -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib2f0a9252715ea4b2fe9c367aa65f771357768ca Gerrit-Change-Number: 36539 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 21 May 2024 17:48:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment