Attention is currently required from: laforge, neels.
1 comment:
Patchset:
Hi @nhofmeyr@sysmocom.de, I wrote some comments while digesting the patch, feel free to apply whatever you think makes sense. In general looks promising.
What I would really like, is that you split each of the worker threads into its own file, otherwise it's a bit mindblowing trying to digest that (for me now, and for any reader that comes after me when the code is merged and has to debug it).
So I say: Please first split those into different files if possible and then I'll give a more through review through each of them on that code. It should be mostly moving functions from one file to another (and if a lot other work is needed, then to me it also means something is entangled where it shouldn't, so it's good it becomes untangled).
To view, visit change 36539. To unsubscribe, or for help writing mail filters, visit settings.