Attention is currently required from: laforge.
jolly has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/libosmocore/+/40760?usp=email )
Change subject: osmo-io: Put together message buffers when dequeued from tx queue
......................................................................
Patch Set 4:
(1 comment)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/40760/comment/2ec59388_27c8ad09?… :
PS3, Line 261: * There can be empty buffers, when a msghdr is queued to the front with
incomplete write. */
do we have some unit test coverage for those rather
hard-to-trigger code paths? I think it's hard to […]
I tried to trigger an
incomplete write, so that it is re-queued in front of the tx_queue. With regular
non-nblocking IO it is possible to have partly written buffers, but with io_uring this
seems not to happen. This means that this condition is never true, as there is no msghdr
with unused write buffers in front of another msghdr.
I prefer to remove it, since it is just an optimization. It is not required, even if
io_uring would return an incomplete write.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/40760?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I97c366211dd266fd58ec252890ec017d6d334534
Gerrit-Change-Number: 40760
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 08 Aug 2025 13:57:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>