Attention is currently required from: arehbein.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33196 )
Change subject: stream: Fix endless loop on server on client disconnect
......................................................................
Patch Set 3:
(1 comment)
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33196/comment/22f18be2_b0682271
PS3, Line 1349: osmo_stream_srv_set_flush_and_destroy(conn);
why aren't you simply disabling READ poll flag here if res == 0?
Another issue I see is that probably if res < 0, we should destroy the stream even if
the tx queue len is not 0, since anyway (checking at the errno) the socket is already
dead.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33196
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I012ddf14ae17642a52d34026d85ab6958cf488a1
Gerrit-Change-Number: 33196
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jun 2023 12:48:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment