Attention is currently required from: arehbein.

View Change

1 comment:

• File src/stream.c:

  • Patch Set #3, Line 1349: osmo_stream_srv_set_flush_and_destroy(conn);

    why aren't you simply disabling READ poll flag here if res == 0?
    Another issue I see is that probably if res < 0, we should destroy the stream even if the tx queue len is not 0, since anyway (checking at the errno) the socket is already dead.

To view, visit change 33196. To unsubscribe, or for help writing mail filters, visit settings.