Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/30620
)
Change subject: Convert tbf->control_ts to be a gprs_rlcmac_pdch*
......................................................................
Patch Set 2:
(2 comments)
File src/pdch.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/30620/comment/66e7611a_84e3db14
PS2, Line 1316: ts == pdch
Same here: comparing foo_ts to pdch may look
confusing, so it's better to have a unified naming by d […]
This is rather
cosmetic and has to be applied in several places, so rather applies to an extra patch. I
am fine with keeping this naming for now so that it's also easier to understand and
understand against older code.
File tests/alloc/AllocTest.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/30620/comment/c9af9127_d8d1b535
PS2, Line 186: tbf->control_ts
Maybe move NULL checking to pdch_name()? This way one
could pass PDCH pointers directly without worr […]
No, I want the code to explicitly
show where/which fields can be null.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/30620
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6a97b6528b2f9d78dfbca8fb97ab7c621f777fc7
Gerrit-Change-Number: 30620
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Dec 2022 11:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment