Attention is currently required from: fixeria.

View Change

2 comments:

• File src/pdch.cpp:

  • Patch Set #2, Line 1316: ts == pdch

    Same here: comparing foo_ts to pdch may look confusing, so it's better to have a unified naming by d […]

    This is rather cosmetic and has to be applied in several places, so rather applies to an extra patch. I am fine with keeping this naming for now so that it's also easier to understand and understand against older code.

• File tests/alloc/AllocTest.cpp:

  • Patch Set #2, Line 186: tbf->control_ts

    Maybe move NULL checking to pdch_name()? This way one could pass PDCH pointers directly without worr […]

    No, I want the code to explicitly show where/which fields can be null.

To view, visit change 30620. To unsubscribe, or for help writing mail filters, visit settings.