- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: msc: CC SETUP MT speech: verify bearer capabilities
by osmith 05 Sep '25

05 Sep '25

Attention is currently required from: neels, osmith, pespin. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: msc: CC SETUP MT speech: verify bearer capabilities ...................................................................... msc: CC SETUP MT speech: verify bearer capabilities Verify that the MSC sends the bearer capability IE from 3GPP TS 24.008 § D.1.2 for speech in the network to MS direction, instead of allowing e.g. what osmo-msc master and latest release currently do: - Filling out radio channel requirement the same way as the MS to Network direction, which is wrong for the Network to MS direction: "Bits 6 and 7 are spare bits. The sending side (i.e. the network) shall set bit 7 to value 0 and bit 6 to value 1." (3GPP TS 24.008 Table 10.5.102) - Sending a speech list in the Network to MS direction, which seems to be allowed in theory and MS are supposed to ignore it (end of Table 10.5.103) but causes bugs in some MS in practice. Therefore it is better to ensure that osmo-msc does not send it (OS#6656). Implement this in f_mt_call_complete(), which gets used e.g. by TC_lu_and_mt_call. Depends: osmo-msc I7046e9244fd9d4301ee2c4df1147a619f753739c Related: OS#6657, OS#6655, OS#6656 Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 --- M library/L3_Templates.ttcn M msc/BSC_ConnectionHandler.ttcn 2 files changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/41044/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Gerrit-Change-Number: 41044 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: gsm48_cc_tx_setup_set_transaction_id: tweak error msg
by osmith 05 Sep '25

05 Sep '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/41057?usp=email ) Change subject: gsm48_cc_tx_setup_set_transaction_id: tweak error msg ...................................................................... gsm48_cc_tx_setup_set_transaction_id: tweak error msg Reword the message to make it less confusing. Change-Id: I4007e99b6abd9b2e05945ccdedaac185a2aea19e --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/57/41057/1 diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 3a78b6d..93b4995 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -842,7 +842,7 @@ /* Transaction ID must not be assigned */ if (trans->transaction_id != TRANS_ID_UNASSIGNED) { - LOG_TRANS(trans, LOGL_ERROR, "TX Setup with assigned transaction. This is not allowed!\n"); + LOG_TRANS(trans, LOGL_ERROR, "TX Setup: transaction ID is already assigned!\n"); mncc_release_ind(trans->net, trans, trans->callref, GSM48_CAUSE_LOC_PRN_S_LU, GSM48_CC_CAUSE_RESOURCE_UNAVAIL); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41057?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4007e99b6abd9b2e05945ccdedaac185a2aea19e Gerrit-Change-Number: 41057 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_set_bearer_cap: split out
by osmith 05 Sep '25

05 Sep '25

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gsm48_cc_tx_setup_set_bearer_cap: split out ...................................................................... gsm48_cc_tx_setup_set_bearer_cap: split out Change-Id: I3fe6bb2af90d729bb32cae8f5a1a38dcf8f87eb9 --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 76 insertions(+), 60 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/41040/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3fe6bb2af90d729bb32cae8f5a1a38dcf8f87eb9 Gerrit-Change-Number: 41040 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_select_codecs: split out
by osmith 05 Sep '25

05 Sep '25

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/41039?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: gsm48_cc_tx_setup_select_codecs: split out ...................................................................... gsm48_cc_tx_setup_select_codecs: split out Change-Id: Ic502f9ed77ea57de4cf6d362c0e7070d9147d6f3 --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 34 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/39/41039/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic502f9ed77ea57de4cf6d362c0e7070d9147d6f3 Gerrit-Change-Number: 41039 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_encode_msg: split out
by osmith 05 Sep '25

05 Sep '25

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/41041?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: gsm48_cc_tx_setup_encode_msg: split out ...................................................................... gsm48_cc_tx_setup_encode_msg: split out Change-Id: I443b4b54c6ad40d852e4c21c896c2d0da5fac239 --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 42 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/41041/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I443b4b54c6ad40d852e4c21c896c2d0da5fac239 Gerrit-Change-Number: 41041 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_setup: remove extra bearer_cap var
by osmith 05 Sep '25

05 Sep '25

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/41042?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by fixeria, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: gsm48_cc_tx_setup: remove extra bearer_cap var ...................................................................... gsm48_cc_tx_setup: remove extra bearer_cap var Store the bearer capabilities directly in the transaction, instead of storing them in a separate variable first, then copying it to the transaction, then using both the separate variable and the copy in the transaction later on. The extra variable is not needed and only makes it more compilicated. Add an explicit '.transfer = GSM48_BCAP_ITCAP_SPEECH,' while at it in the speech case. This was already set implicitly because GSM48_BCAP_ITCAP_SPEECH is 0. Change-Id: I247ef10923c2875ca75e73046f4b8ed14190d4d2 --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 11 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/42/41042/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I247ef10923c2875ca75e73046f4b8ed14190d4d2 Gerrit-Change-Number: 41042 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup: fix speech bearer capabilities
by osmith 05 Sep '25

05 Sep '25

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gsm48_cc_tx_setup: fix speech bearer capabilities ...................................................................... gsm48_cc_tx_setup: fix speech bearer capabilities Send the bearer capability IE from 3GPP TS 24.008 § D.1.2 for speech instead of the result from gsm48_cc_tx_setup_set_bearer_cap() for the network to MS direction. This is needed, because: - We shall send spare bits for the radio channel requirement in the network to MS direction, see 3GPP TS 24.008 § D.1.1 and Table 10.5.102). - We could in theory send a speech version list that MS are then supposed to ignore (end of Table 10.5.103), but this causes bugs in some MS so it is better to not send it (OS#6656). Related: OS#6657, OS#6655, OS#6656 Related: osmo-ttcn3-hacks I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Depends: libosmocore I97101c977104eae82e4850d40f9abd15aa03e33e Change-Id: I7046e9244fd9d4301ee2c4df1147a619f753739c --- M TODO-RELEASE M src/libmsc/gsm_04_08_cc.c M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err 4 files changed, 42 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/43/41043/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7046e9244fd9d4301ee2c4df1147a619f753739c Gerrit-Change-Number: 41043 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_set_transaction_id: split out
by osmith 05 Sep '25

05 Sep '25

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: gsm48_cc_tx_setup_set_transaction_id: split out ...................................................................... gsm48_cc_tx_setup_set_transaction_id: split out Move the code for setting the transaction ID to a separate function to start making gsm48_cc_tx_setup shorter and easier to read. Return -1 on error instead of rc from mncc_release_ind() as it returns 0 on success. Make some tweaks while at it: * Set LOGL_ERROR for the "TX Setup with assigned transaction" error. * Add a log message for the "could not get a free transaction ID" case. * Minor formatting tweaks. Change-Id: I715f12d09570211a98b667c56960309bd326e8d8 --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 32 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/38/41038/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I715f12d09570211a98b667c56960309bd326e8d8 Gerrit-Change-Number: 41038 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS
by osmith 05 Sep '25

05 Sep '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email ) Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS ...................................................................... gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS From network to MS, we must send spare bits that are encoded the same as GSM48_BCAP_RRQ_FR_ONLY. Add a define, so it is obvious that those are spare bits. Related: OS#6657 Related: osmo-msc I7046e9244fd9d4301ee2c4df1147a619f753739c Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/41056/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index aad50d6..1c95a1c 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -2155,6 +2155,9 @@ GSM48_BCAP_RRQ_DUAL_HR = 2, GSM48_BCAP_RRQ_DUAL_FR = 3, }; +/* GSM 04.08 Table 10.72: In network to MS direction, the network must send + * spare bits that are encoded the same as FR_ONLY. */ +#define GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS GSM48_BCAP_RRQ_FR_ONLY /* GSM 04.08 Bearer Capability: Rate Adaption */ enum gsm48_bcap_ra { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e Gerrit-Change-Number: 41056 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_setup: move msgb_alloc down
by osmith 05 Sep '25

05 Sep '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/41037?usp=email ) Change subject: gsm48_cc_tx_setup: move msgb_alloc down ...................................................................... gsm48_cc_tx_setup: move msgb_alloc down Don't alloc msgb before it gets used. Change-Id: I99edbdc915552a4ab28ef6f7a1e55818092a2e20 --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 59f42c8..b82c018 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -838,14 +838,12 @@ static int gsm48_cc_tx_setup(struct gsm_trans *trans, void *arg) { - struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 CC SETUP"); + struct msgb *msg; struct gsm48_hdr *gh; struct gsm_mncc *setup = arg; int rc, trans_id; struct gsm_mncc_bearer_cap bearer_cap; - gh = (struct gsm48_hdr *) msgb_put(msg, sizeof(*gh)); - /* transaction id must not be assigned */ if (trans->transaction_id != TRANS_ID_UNASSIGNED) { LOG_TRANS(trans, LOGL_DEBUG, "TX Setup with assigned transaction. " @@ -870,8 +868,6 @@ } trans->transaction_id = trans_id; - gh->msg_type = GSM48_MT_CC_SETUP; - gsm48_start_cc_timer(trans, 0x303, GSM48_T303); /* MT call leg is starting. Gather all codecs information so far known. @@ -974,6 +970,10 @@ /* Create a copy of the bearer capability in the transaction struct, so we can use this information later */ trans->bearer_cap = bearer_cap; + msg = gsm48_msgb_alloc_name("GSM 04.08 CC SETUP"); + gh = (struct gsm48_hdr *) msgb_put(msg, sizeof(*gh)); + gh->msg_type = GSM48_MT_CC_SETUP; + gsm48_encode_bearer_cap(msg, 0, &bearer_cap); /* facility */ @@ -1011,7 +1011,6 @@ return trans_tx_gsm48(trans, msg); error: trans_free(trans); - msgb_free(msg); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41037?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I99edbdc915552a4ab28ef6f7a1e55818092a2e20 Gerrit-Change-Number: 41037 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log