- gerrit-log - lists.osmocom.org

[M] Change in libosmo-asn1-tcap[master]: Add git-version-gen
by osmith 05 Sep '25

05 Sep '25

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41026?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Add git-version-gen ...................................................................... Add git-version-gen Change-Id: Ic6245f4d0ccced5089c55eccbe07b36c43d71e9c --- M .gitignore M Makefile.am M configure.ac A git-version-gen 4 files changed, 165 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/26/41026/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41026?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ic6245f4d0ccced5089c55eccbe07b36c43d71e9c Gerrit-Change-Number: 41026 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-asn1-tcap[master]: Generate a version.h file
by osmith 05 Sep '25

05 Sep '25

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41027?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by fixeria, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: Generate a version.h file ...................................................................... Generate a version.h file Related: OS#6626 Change-Id: I2ee394086af3ccf0ec789e2cba627054c09fe1cd --- M .gitignore M include/osmocom/tcap/Makefile.am A include/osmocom/tcap/version.h.tpl 3 files changed, 37 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/27/41027/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I2ee394086af3ccf0ec789e2cba627054c09fe1cd Gerrit-Change-Number: 41027 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS
by pespin 05 Sep '25

05 Sep '25

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email ) Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS ...................................................................... Patch Set 2: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/41056/comment/8bb558f1_547292d8?… : PS1, Line 2158: /* GSM 04.08 Table 10.72: In network to MS direction, the network must send > It was rather close to that enum and the same prefix suggests the relation? […] I really had to use CTRL+F to actually find the enum, so not close enough ;) Still, when looking at the enum you definetly want to see that field inside. I'm not looking outside. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e Gerrit-Change-Number: 41056 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 13:08:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: HRv1 codec: add support for TW-TS-002
by pespin 05 Sep '25

05 Sep '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email ) Change subject: HRv1 codec: add support for TW-TS-002 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf11e43d4ce9df990d0e0a856d62d9ea11cb837c Gerrit-Change-Number: 41050 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 13:07:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bts[master]: FR/HR/EFR: implement SID filter in TCH UL path
by pespin 05 Sep '25

05 Sep '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41049?usp=email ) Change subject: FR/HR/EFR: implement SID filter in TCH UL path ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmo-bts/lchan.h: https://gerrit.osmocom.org/c/osmo-bts/+/41049/comment/bac15ded_da67aece?usp… : PS1, Line 295: /* UL SID filter to catch DTXu half-blocks */ Maybe add link reference https://osmocom.org/projects/retro-gsm/wiki/DTXu_half-blocks here too? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c62312316b04567bcadf6050597673f071247d Gerrit-Change-Number: 41049 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 13:04:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bts[master]: FR/HR/EFR: centralize TCH UL SID classification
by pespin 05 Sep '25

05 Sep '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email ) Change subject: FR/HR/EFR: centralize TCH UL SID classification ...................................................................... Patch Set 1: (2 comments) File include/osmo-bts/msg_utils.h: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/867dc87a_7b5e3426?usp… : PS1, Line 25: * Additionally for HRv1 codec, we use a control buffer word to pass IMHO once you improve de comment framing (see first patch); this show go immediatelly above each field being defined (eg. line 43). File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/b933e9d1_c2a84a7a?usp… : PS1, Line 2349: tch_ul_msg_sid(msg) = sidc; I wonder whether this msg field should be called "hr_sid" instead of "sid". -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6c8c146962de2f173760889eb232693bb4229d3 Gerrit-Change-Number: 41048 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in ...osmo-python-tests[master]: debian: add python3-osmopy-{libs,utils}.install
by fixeria 05 Sep '25

05 Sep '25

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email ) Change subject: debian: add python3-osmopy-{libs,utils}.install ...................................................................... Patch Set 1: (1 comment) File debian/python3-osmopy-libs.install: https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053/comment/e6f33… : PS1, Line 1: usr/lib > why is this file needed? looks like the contents of the -libs package stays the same, see end of: […] Yes, the package contents is not expected to change here. The idea here is to avoid overwriting Debian's automatic rules (see `debian/rules`) and facilitate installing misc files (systemd services, configs). I'll update the commit message. When `setup.py` is invoked, we get libraries in `usr/lib` and binaries in `usr/bin`. We include only the libraries for `python3-osmopy-libs`, and only the binaries for `python3-osmopy-utils`. -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I94b940789e138341792f40eedeedb73d4e4d421e Gerrit-Change-Number: 41053 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:50:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: TCH UL path: add out-of-band BFI flag
by pespin 05 Sep '25

05 Sep '25

Attention is currently required from: dexter, falconia, fixeria. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41047?usp=email ) Change subject: TCH UL path: add out-of-band BFI flag ...................................................................... Patch Set 1: (3 comments) File include/osmo-bts/msg_utils.h: https://gerrit.osmocom.org/c/osmo-bts/+/41047/comment/e50ff293_01f8f716?usp… : PS1, Line 27: /* Accessor macros for control buffer words in RTP input path */ Can you add a a bit more framing to clearly separate the 2 groups of cb fields? eg: /**************************************************************** * Accessor macros for control buffer words in RTP input path (DL) *****************************************************************/ https://gerrit.osmocom.org/c/osmo-bts/+/41047/comment/58b8fd84_39ba8749?usp… : PS1, Line 39: #define tch_ul_msg_bfi(x) ((x)->cb[0]) I wonder whether this is a boolean, a flag, or an integer. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41047/comment/1fe57ebe_1de536f3?usp… : PS1, Line 2229: teh = 0xE0 | (tch_ul_msg_bfi(msg) << 1); and this kind of operation together with "I wonder whether this is a boolean, a flag, or an integer." comment makes it even more disturbing ;) EDIT: Ok, I see from below ("= true") that this is a boolean. Hence, I'd prefer to keep the assigning logic here as it was before, instead of shifting a boolean. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8097946429e83eae90f89e49d17ffb8eb0636fcb Gerrit-Change-Number: 41047 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:45:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS
by fixeria 05 Sep '25

05 Sep '25

Attention is currently required from: pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email ) Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/41056/comment/cef4f27e_ea7a3c5c?… : PS1, Line 2158: /* GSM 04.08 Table 10.72: In network to MS direction, the network must send > This kind of approach is usually placed inside the enum to quickly see it's related to it: […] It was rather close to that enum and the same prefix suggests the relation? Anyways, I am not opposed to having it inside of the enum. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e Gerrit-Change-Number: 41056 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:38:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS
by osmith 05 Sep '25

05 Sep '25

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email ) Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS ...................................................................... Patch Set 2: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/41056/comment/77b82491_d16ef9f2?… : PS1, Line 2158: /* GSM 04.08 Table 10.72: In network to MS direction, the network must send > This kind of approach is usually placed inside the enum to quickly see it's related to it: […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e Gerrit-Change-Number: 41056 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:37:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log