Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email )
Change subject: [REST] Implement MetricsList
......................................................................
Patch Set 7:
(1 comment)
File doc/osmo-s1gw-cli.md:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099/comment/d2480afe_941d… :
PS7, Line 109: | pfcp.assoc_setup_req.timeout | counter | 21 |
imho it would be better to have those as "c" and "g", otherwise it populates a lot of space.
In any case, I'd have the value next to the name.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I43114aa8f5f8a388dd6a436f83ad1ee97f1d2ab1
Gerrit-Change-Number: 41099
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Sep 2025 15:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email )
Change subject: Correctly calculate size iofd_msgb_alloc2()
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/41138/comment/88e33270_e39670fc?… :
PS1, Line 10: too small, if headroom exceeds 65535.
how can headroom exceed 65535 is it's limited to 16bit value?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12
Gerrit-Change-Number: 41138
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 19 Sep 2025 15:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No