- gerrit-log - lists.osmocom.org

[L] Change in ...osmo-s1gw[master]: [REST] Implement MetricsList
by osmith 25 Sep '25

25 Sep '25

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email ) Change subject: [REST] Implement MetricsList ...................................................................... Patch Set 8: (1 comment) File doc/osmo-s1gw-cli.md: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099/comment/aee5c877_18e4… : PS7, Line 109: | pfcp.assoc_setup_req.timeout | counter | 21 | > Having metric types in a separate column looks more readable to me than those cryptic single-later s […] IMHO using counter / gauge here is better, given that individual lines in this list are still rather short and this makes the meaning immediately obvious -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I43114aa8f5f8a388dd6a436f83ad1ee97f1d2ab1 Gerrit-Change-Number: 41099 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Sep 2025 08:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in ...osmo-s1gw[master]: [REST] Implement MetricsList
by fixeria 25 Sep '25

25 Sep '25

Attention is currently required from: fixeria, laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email ) Change subject: [REST] Implement MetricsList ...................................................................... Patch Set 8: (1 comment) File doc/osmo-s1gw-cli.md: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099/comment/123d2637_639f… : PS7, Line 109: | pfcp.assoc_setup_req.timeout | counter | 21 | > imho it would be better to have those as "c" and "g", otherwise it populates a lot of space. […] Having metric types in a separate column looks more readable to me than those cryptic single-later suffixes. Though, I don't have a strong preference and would like to hear what the others think (also, ideally, what the customer wants). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I43114aa8f5f8a388dd6a436f83ad1ee97f1d2ab1 Gerrit-Change-Number: 41099 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Sep 2025 08:23:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in ...osmo-s1gw[master]: [REST] Implement MetricsList
by osmith 25 Sep '25

25 Sep '25

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email ) Change subject: [REST] Implement MetricsList ...................................................................... Patch Set 8: (1 comment) File contrib/openapi.yaml: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099/comment/2b595a30_737c… : PS8, Line 27: responses: > If the requested metric type is invalid, then such a request is considered invalid and rejected with code 400 Bad Request, because it's violating the present specification. I don't think we want to define general response codes like 400 or 500 for each procedure explicitly. Acknowledged > Regarding the path... I guess by invalid path you mean a path that matches no metrics in the S1GW. This can be a mistake, e.g. a typo, but this can also happen if the matching metrics are not registered yet. For instance, this applies to per-eNB metrics: they do not exist before the eNB connects. I can implement returning 404 in this case (in a follow-up patch). That sounds useful IMHO. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I43114aa8f5f8a388dd6a436f83ad1ee97f1d2ab1 Gerrit-Change-Number: 41099 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Sep 2025 08:21:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in ...osmo-s1gw[master]: [REST] Implement MetricsList
by fixeria 25 Sep '25

25 Sep '25

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email ) Change subject: [REST] Implement MetricsList ...................................................................... Patch Set 8: (1 comment) File contrib/openapi.yaml: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099/comment/510a25d8_40bc… : PS8, Line 27: responses: > should there be a different response defined if the type or path are invalid? If the requested metric type is invalid, then such a request is considered invalid and rejected with code 400 `Bad Request`, because it's violating the present specification. I don't think we want to define general response codes like 400 or 500 for each procedure explicitly. Regarding the path... I guess by invalid path you mean a path that matches no metrics in the S1GW. This can be a mistake, e.g. a typo, but this can also happen if the matching metrics are not registered yet. For instance, this applies to per-eNB metrics: they do not exist before the eNB connects. I can implement returning 404 in this case (in a follow-up patch). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I43114aa8f5f8a388dd6a436f83ad1ee97f1d2ab1 Gerrit-Change-Number: 41099 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 25 Sep 2025 08:18:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[L] Change in ...osmo-s1gw[master]: [REST] Implement EnbErabList
by osmith 25 Sep '25

25 Sep '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41103?usp=email ) Change subject: [REST] Implement EnbErabList ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41103?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I846974dd79e737acaac17918d18da55967a9abf2 Gerrit-Change-Number: 41103 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Sep 2025 06:54:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in ...osmo-s1gw[master]: [REST] Implement EnbList and EnbInfo
by osmith 25 Sep '25

25 Sep '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41101?usp=email ) Change subject: [REST] Implement EnbList and EnbInfo ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41101?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iba5a36678cf4bc245e9ae8cecc20ced76dfb7d75 Gerrit-Change-Number: 41101 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Sep 2025 06:52:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in ...osmo-s1gw[master]: [REST] Implement Pfcp{AssocState,Heartbeat}
by osmith 25 Sep '25

25 Sep '25

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41100?usp=email ) Change subject: [REST] Implement Pfcp{AssocState,Heartbeat} ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41100?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Idc98952d46d8e224969da343dc29ef323c6ed813 Gerrit-Change-Number: 41100 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Sep 2025 06:48:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in ...osmo-s1gw[master]: [REST] Implement Pfcp{AssocState,Heartbeat}
by osmith 25 Sep '25

25 Sep '25

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41100?usp=email ) Change subject: [REST] Implement Pfcp{AssocState,Heartbeat} ...................................................................... Patch Set 8: (1 comment) File contrib/openapi.yaml: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41100/comment/d9925ea4_d2ce… : PS8, Line 46: post: looks like post and delete are not implemented yet. maybe mention this here in summary as comment? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41100?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Idc98952d46d8e224969da343dc29ef323c6ed813 Gerrit-Change-Number: 41100 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Sep 2025 06:47:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in ...osmo-s1gw[master]: [REST] Implement MetricsList
by osmith 25 Sep '25

25 Sep '25

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email ) Change subject: [REST] Implement MetricsList ...................................................................... Patch Set 8: Code-Review+1 (1 comment) File contrib/openapi.yaml: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099/comment/366a8625_b547… : PS8, Line 27: responses: should there be a different response defined if the type or path are invalid? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I43114aa8f5f8a388dd6a436f83ad1ee97f1d2ab1 Gerrit-Change-Number: 41099 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Sep 2025 06:43:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: [REST] Implement ErabList and ErabInfo
by osmith 25 Sep '25

25 Sep '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41104?usp=email ) Change subject: [REST] Implement ErabList and ErabInfo ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41104?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia98498143fd0e38030429171e42a0c4c4887df64 Gerrit-Change-Number: 41104 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Sep 2025 06:38:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log