- gerrit-log - lists.osmocom.org

Change in pysim[master]: catch and ignore SwMatchError on probing for AID's
by laforge 21 Jan '22

21 Jan '22

Attention is currently required from: bjoern. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26958 ) Change subject: catch and ignore SwMatchError on probing for AID's ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: ha, I just did exactly the same in https://gerrit.osmocom.org/c/pysim/+/26961 with the difference that I'm printing those situations as error. I guess we should print it only as an error if the AID was listed in EF.DIR but not if it was a random probe. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3aa7deaf46bdf352a201c3089b3714405a06f281 Gerrit-Change-Number: 26958 Gerrit-PatchSet: 1 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: xua_default_lm_fsm.c: Fix typo in comment
by pespin 21 Jan '22

21 Jan '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26960 ) Change subject: xua_default_lm_fsm.c: Fix typo in comment ...................................................................... xua_default_lm_fsm.c: Fix typo in comment Change-Id: I4095878fb05c3128be556ab36dfc7ab88d309c9a --- M src/xua_default_lm_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/xua_default_lm_fsm.c b/src/xua_default_lm_fsm.c index ca488a7..e5cceea 100644 --- a/src/xua_default_lm_fsm.c +++ b/src/xua_default_lm_fsm.c @@ -149,7 +149,7 @@ { switch (event) { case LM_E_ASP_UP_CONF: - /* ASP is sup, wait for some time if any NOTIFY + /* ASP is up, wait for some time if any NOTIFY * indications about AS in this ASP are received */ osmo_fsm_inst_state_chg(fi, S_WAIT_NOTIFY, 2, T_WAIT_NOTIFY); break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4095878fb05c3128be556ab36dfc7ab88d309c9a Gerrit-Change-Number: 26960 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmo-sccp[master]: xua_default_lm_fsm.c: Fix typo in comment
by fixeria 21 Jan '22

21 Jan '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26960 ) Change subject: xua_default_lm_fsm.c: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4095878fb05c3128be556ab36dfc7ab88d309c9a Gerrit-Change-Number: 26960 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:05:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: _match_applications: catch SwMatchError e.g. if permission denied
by fixeria 21 Jan '22

21 Jan '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26961 ) Change subject: _match_applications: catch SwMatchError e.g. if permission denied ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Duplicate of https://gerrit.osmocom.org/c/pysim/+/26958. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id03a44c84cc8939908bc15f9fe42a9955d58c643 Gerrit-Change-Number: 26961 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:00:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in pysim[master]: _match_applications: catch SwMatchError e.g. if permission denied
by laforge 21 Jan '22

21 Jan '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26961 ) Change subject: _match_applications: catch SwMatchError e.g. if permission denied ...................................................................... _match_applications: catch SwMatchError e.g. if permission denied There are some SIM cards (e.g. those of sipgate), which return an undefined error status word if one tries to select some of the applications the card itself lists in EF.DIR. Let's handle this situation gracefully rather than printing python exceptions. Change-Id: Id03a44c84cc8939908bc15f9fe42a9955d58c643 Closes: OS#5409 --- M pySim/filesystem.py 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/26961/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index dfe1677..785108c 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1113,10 +1113,13 @@ # Some card applications may not be registered in EF.DIR, we will actively # probe for those applications for f in set(apps_profile) - set(apps_taken): - data, sw = self.card.select_adf_by_aid(f.aid) - if sw == "9000": - print(" %s: %s" % (f.name, f.aid)) - apps_taken.append(f) + try: + data, sw = self.card.select_adf_by_aid(f.aid) + if sw == "9000": + print(" %s: %s" % (f.name, f.aid)) + apps_taken.append(f) + except SwMatchError as e: + print(" ERROR: %s: %s: Unable to select: %s" % (f.name, f.aid, e)) return apps_taken -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id03a44c84cc8939908bc15f9fe42a9955d58c643 Gerrit-Change-Number: 26961 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in libosmo-sccp[master]: xua_default_lm_fsm.c: Fix typo in comment
by pespin 21 Jan '22

21 Jan '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26960 ) Change subject: xua_default_lm_fsm.c: Fix typo in comment ...................................................................... xua_default_lm_fsm.c: Fix typo in comment Change-Id: I4095878fb05c3128be556ab36dfc7ab88d309c9a --- M src/xua_default_lm_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/60/26960/1 diff --git a/src/xua_default_lm_fsm.c b/src/xua_default_lm_fsm.c index ca488a7..e5cceea 100644 --- a/src/xua_default_lm_fsm.c +++ b/src/xua_default_lm_fsm.c @@ -149,7 +149,7 @@ { switch (event) { case LM_E_ASP_UP_CONF: - /* ASP is sup, wait for some time if any NOTIFY + /* ASP is up, wait for some time if any NOTIFY * indications about AS in this ASP are received */ osmo_fsm_inst_state_chg(fi, S_WAIT_NOTIFY, 2, T_WAIT_NOTIFY); break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4095878fb05c3128be556ab36dfc7ab88d309c9a Gerrit-Change-Number: 26960 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in pysim[master]: add missing bit definition for NG-RAN in xAcT
by fixeria 21 Jan '22

21 Jan '22

Attention is currently required from: Bjoern Riemer. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26956 ) Change subject: add missing bit definition for NG-RAN in xAcT ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please update the unit test(s). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I910df28c4c59ec94cce9603377786325f6d8c1a3 Gerrit-Change-Number: 26956 Gerrit-PatchSet: 1 Gerrit-Owner: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-Comment-Date: Fri, 21 Jan 2022 08:45:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in pysim[master]: implement shell command to update PLMN in IMSI
by fixeria 21 Jan '22

21 Jan '22

Attention is currently required from: Bjoern Riemer. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26959 ) Change subject: implement shell command to update PLMN in IMSI ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26959/comment/6f929f4f_d99beccc PS1, Line 485: string There is no such type in Python, should be 'str' instead. https://gerrit.osmocom.org/c/pysim/+/26959/comment/679e39f7_c3b50569 PS1, Line 488: if len(plmn) == 5: If I am not mistaken, it can also be 6 in case of 3-digit MNC. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc Gerrit-Change-Number: 26959 Gerrit-PatchSet: 1 Gerrit-Owner: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-Comment-Date: Fri, 21 Jan 2022 08:41:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: osmo_fsm: Ensure all state and event names are valid identifiers
by fixeria 21 Jan '22

21 Jan '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16355 ) Change subject: osmo_fsm: Ensure all state and event names are valid identifiers ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: When it comes to identifiers exposed over the CTRL interface, I am always wondering why don't we just implement a simple escaping for the CTRL itself, rather than restricting the FSM/CTR identifiers? I faced this problem while working on https://gerrit.osmocom.org/c/osmo-bts/+/25270. On the one had I have readability of the rate counter groups, on the other - inability of the CTRL interface to escape special symbols. I personally vote for readability, rather than identifiers that are hard to read. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If98587eff3c48a66ed2e5cc1f01a12accab5a3e7 Gerrit-Change-Number: 16355 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 21 Jan 2022 08:34:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Build failure of network:osmocom:latest/libusrp in openSUSE_Factory_ARM/armv7l
by OBS Notification 21 Jan '22

21 Jan '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/li… Package network:osmocom:latest/libusrp failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 39s] [166/181] cumulate gcc-PIE-11-4.3 [ 39s] [167/181] Bad rpm //.init_b_cache/rpms/gcc-c++.rpm [ 39s] cannot query //.init_b_cache/rpms/gcc-c++.rpm [ 39s] cumulate [ 39s] [168/181] cumulate libboost_headers1_78_0-devel-1.78.0-1.2 [ 39s] [169/181] cumulate rpm-build-4.17.0-2.4 [ 39s] [170/181] cumulate libboost_chrono1_78_0-devel-1.78.0-1.2 [ 39s] [171/181] cumulate libboost_program_options1_78_0-devel-1.78.0-1.2 [ 39s] [172/181] cumulate libboost_system1_78_0-devel-1.78.0-1.2 [ 39s] [173/181] cumulate libboost_atomic1_78_0-devel-1.78.0-1.2 [ 39s] [174/181] cumulate libboost_date_time1_78_0-devel-1.78.0-1.2 [ 39s] [175/181] cumulate libboost_date_time-devel-1.78.0-1.1 [ 39s] [176/181] cumulate libboost_program_options-devel-1.78.0-1.1 [ 39s] [177/181] cumulate libboost_system-devel-1.78.0-1.1 [ 39s] [178/181] cumulate libboost_filesystem1_78_0-devel-1.78.0-1.2 [ 39s] [179/181] cumulate libboost_thread1_78_0-devel-1.78.0-1.2 [ 39s] [180/181] cumulate libboost_filesystem-devel-1.78.0-1.1 [ 39s] [181/181] cumulate libboost_thread-devel-1.78.0-1.1 [ 39s] now installing cumulated packages [ 39s] error: .init_b_cache/gcc-c++.rpm: signature region trailer: BAD, tag 0 type 0 offset 0 count 0 [ 39s] error: .init_b_cache/gcc-c++.rpm cannot be installed [ 39s] exit ... [ 39s] ### VM INTERACTION START ### [ 42s] [ 8.596457][ T392] sysrq: Power Off [ 42s] [ 8.596888][ T7] reboot: Power down [ 42s] ### VM INTERACTION END ### [ 42s] [ 42s] obs-arm-11 failed "build libusrp.spec" at Fri Jan 21 04:32:24 UTC 2022. [ 42s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

2026

2025

2024

2023

2022

gerrit-log