- gerrit-log - lists.osmocom.org

Change in dahdi-linux[master]: icE1usb: update ice1usb_proto.h to firmware 0.2
by laforge 22 Jan '22

22 Jan '22

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26967 ) Change subject: icE1usb: update ice1usb_proto.h to firmware 0.2 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: as I wrote on IRC last night, I think the GPS-DO should actually be exposed as anoter interface descriptor (with no endpoints). This would substantially simplify the DAHDI (or any Linux kernel) driver. Wondering if we should at thta point move the requests from device to interface level? -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I1423531470a1c9165d713108fb6a87ff47ff6e29 Gerrit-Change-Number: 26967 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Sat, 22 Jan 2022 12:57:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Build failure of network:osmocom:nightly/libosmocore in openSUSE_Factory_ARM/aarch64
by OBS Notification 22 Jan '22

22 Jan '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/l… Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 50s] [190/207] cumulate pam_unix-1.5.2-5.3 [ 50s] [191/207] cumulate python38-3.8.12-3.4 [ 50s] [192/207] cumulate libgnutls-devel-3.7.3-1.1 [ 50s] [193/207] cumulate libgio-2_0-0-2.70.2-1.2 [ 50s] [194/207] cumulate systemd-mini-249.9-1.1 [ 50s] [195/207] cumulate shadow-4.11.1-1.1 [ 50s] [196/207] cumulate util-linux-2.37.2-2.3 [ 50s] [197/207] cumulate gcc-PIE-11-4.3 [ 50s] [198/207] cumulate gio-branding-upstream-2.70.2-1.2 [ 50s] [199/207] cumulate glib2-tools-2.70.2-1.2 [ 50s] [200/207] cumulate polkit-0.120-1.2 [ 50s] [201/207] cumulate rpm-build-4.17.0-2.4 [ 50s] [202/207] cumulate libpolkit-gobject-1-0-0.120-1.2 [ 50s] [203/207] cumulate polkit-default-privs-1550+20211214.daf2765-1.1 [ 50s] [204/207] cumulate rpmlint-mini-2.2.0+git20220106.43867d0-3.2 [ 50s] [205/207] cumulate libpolkit-agent-1-0-0.120-1.2 [ 50s] [206/207] cumulate pcsc-lite-1.9.5-1.2 [ 50s] [207/207] cumulate pcsc-lite-devel-1.9.5-1.2 [ 50s] now installing cumulated packages [ 50s] error: .init_b_cache/libbz2-1.rpm: signature region trailer: BAD, tag 0 type 0 offset 0 count 0 [ 50s] error: .init_b_cache/libbz2-1.rpm cannot be installed [ 51s] exit ... [ 51s] ### VM INTERACTION START ### [ 54s] [ 8.829939][ T391] sysrq: Power Off [ 54s] [ 8.830436][ T262] reboot: Power down [ 54s] ### VM INTERACTION END ### [ 54s] [ 54s] obs-arm-11 failed "build libosmocore.spec" at Sat Jan 22 00:29:07 UTC 2022. [ 54s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Change in dahdi-linux[master]: icE1usb: Use USB_CTRL_SET_TIMEOUT (5s) instead of hand-coded 1s
by laforge 22 Jan '22

22 Jan '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26968 ) Change subject: icE1usb: Use USB_CTRL_SET_TIMEOUT (5s) instead of hand-coded 1s ...................................................................... icE1usb: Use USB_CTRL_SET_TIMEOUT (5s) instead of hand-coded 1s This seems to be the kernel default for CTRL request timeout, let's use it here. Change-Id: I7b7c1a2b13f61372e839e34a376e66c91190bdb3 --- M drivers/dahdi/icE1usb/icE1usb.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/68/26968/1 diff --git a/drivers/dahdi/icE1usb/icE1usb.c b/drivers/dahdi/icE1usb/icE1usb.c index 9339933..87a7422 100644 --- a/drivers/dahdi/icE1usb/icE1usb.c +++ b/drivers/dahdi/icE1usb/icE1usb.c @@ -209,7 +209,8 @@ rc = usb_control_msg(ieu->usb_dev, usb_sndctrlpipe(ieu->usb_dev, 0), ICE1USB_INTF_SET_TX_CFG, USB_RT_VEND_IF, - 0, 0, &ieu->cfg.tx, sizeof(ieu->cfg.tx), 1000); + 0, 0, &ieu->cfg.tx, sizeof(ieu->cfg.tx), + USB_CTRL_SET_TIMEOUT); if (rc < 0) return rc; if (rc != sizeof(ieu->cfg.tx)) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I7b7c1a2b13f61372e839e34a376e66c91190bdb3 Gerrit-Change-Number: 26968 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in dahdi-linux[master]: icE1usb: update ice1usb_proto.h to firmware 0.2
by laforge 22 Jan '22

22 Jan '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26967 ) Change subject: icE1usb: update ice1usb_proto.h to firmware 0.2 ...................................................................... icE1usb: update ice1usb_proto.h to firmware 0.2 git revision c308334de7f7fb92504364f29bd815014002d3ce of https://git.osmocom.org/osmo-e1-hardware Change-Id: I1423531470a1c9165d713108fb6a87ff47ff6e29 --- M drivers/dahdi/icE1usb/icE1usb.c M drivers/dahdi/icE1usb/ice1usb_proto.h 2 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/67/26967/1 diff --git a/drivers/dahdi/icE1usb/icE1usb.c b/drivers/dahdi/icE1usb/icE1usb.c index 7744828..9339933 100644 --- a/drivers/dahdi/icE1usb/icE1usb.c +++ b/drivers/dahdi/icE1usb/icE1usb.c @@ -1012,6 +1012,8 @@ dev_err(&intf->dev, "Cannot find ON altsetting"); goto error; } + dev_info(&intf->dev, "altsetting off=%u, on=%u\n", + ieu->alt_off->desc.bAlternateSetting, ieu->alt_on->desc.bAlternateSetting); /* locate ON / OFF altsettings */ if (find_endpoints(ieu, ieu->alt_on) < 4) { @@ -1034,6 +1036,7 @@ //ddev->location = USB_BUS_PATH; dspan = &ieu->dahdi.span; + /* TODO: include USB path info? */ snprintf(dspan->name, sizeof(dspan->name), "icE1usb/1/%d", ieu->alt_on->desc.bInterfaceNumber); //TDOO: device != 1 snprintf(dspan->desc, sizeof(dspan->desc), "Osmocom icE1USB Card 1 Span %d", diff --git a/drivers/dahdi/icE1usb/ice1usb_proto.h b/drivers/dahdi/icE1usb/ice1usb_proto.h index d0d7304..a249537 100644 --- a/drivers/dahdi/icE1usb/ice1usb_proto.h +++ b/drivers/dahdi/icE1usb/ice1usb_proto.h @@ -17,12 +17,51 @@ /*! returns a bit-mask of optional device capabilities (see enum e1usb_dev_capability) */ #define ICE1USB_DEV_GET_CAPABILITIES 0x01 #define ICE1USB_DEV_GET_FW_BUILD 0x02 +#define ICE1USB_DEV_GET_GPSDO_STATUS 0x10 +#define ICE1USB_DEV_GET_GPSDO_MODE 0x12 /*!< uint8_t */ +#define ICE1USB_DEV_SET_GPSDO_MODE 0x13 /*!< wValue = mode */ +#define ICE1USB_DEV_GET_GPSDO_TUNE 0x14 /*!< data = struct e1usb_gpsdo_tune */ +#define ICE1USB_DEV_SET_GPSDO_TUNE 0x15 /*!< data = struct e1usb_gpsdo_tune */ enum e1usb_dev_capability { /*! Does this board have a GPS-DO */ ICE1USB_DEV_CAP_GPSDO, }; +enum ice1usb_gpsdo_mode { + ICE1USB_GPSDO_MODE_DISABLED = 0, + ICE1USB_GPSDO_MODE_AUTO = 1, +}; + +enum ice1usb_gpsdo_antenna_state { + ICE1USB_GPSDO_ANT_UNKNOWN = 0, + ICE1USB_GPSDO_ANT_OK = 1, + ICE1USB_GPSDO_ANT_OPEN = 2, + ICE1USB_GPSDO_ANT_SHORT = 3, +}; + +enum ice1usb_gpsdo_state { + ICE1USB_GPSDO_STATE_DISABLED = 0, + ICE1USB_GPSDO_STATE_CALIBRATE = 1, + ICE1USB_GPSDO_STATE_HOLD_OVER = 2, + ICE1USB_GPSDO_STATE_TUNE_COARSE = 3, + ICE1USB_GPSDO_STATE_TUNE_FINE = 4, +}; + +struct e1usb_gpsdo_tune { + uint16_t coarse; + uint16_t fine; +} __attribute__((packed)); + +struct e1usb_gpsdo_status { + uint8_t state; + uint8_t antenna_status; /*!< Antenna status */ + uint8_t valid_fix; /*!< Valid GPS Fix (0/1) */ + uint8_t mode; /*!< Current configured operating mode */ + struct e1usb_gpsdo_tune tune; /*!< Current VCXO tuning values */ + uint32_t freq_est; /*!< Latest frequency estimate measurement */ +} __attribute__((packed)); + /* Interface Requests */ @@ -32,6 +71,7 @@ #define ICE1USB_INTF_GET_TX_CFG 0x03 /*!< struct ice1usb_tx_config */ #define ICE1USB_INTF_SET_RX_CFG 0x04 /*!< struct ice1usb_rx_config */ #define ICE1USB_INTF_GET_RX_CFG 0x05 /*!< struct ice1usb_rx_config */ +#define ICE1USB_INTF_GET_ERRORS 0x06 /*!< struct ice1usb_irq_err */ //enum e1usb_intf_capability { }; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I1423531470a1c9165d713108fb6a87ff47ff6e29 Gerrit-Change-Number: 26967 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in pysim[master]: add missing bit definition for NG-RAN in xAcT
by bjoern 22 Jan '22

22 Jan '22

Attention is currently required from: laforge, fixeria. bjoern has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26956 ) Change subject: add missing bit definition for NG-RAN in xAcT ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > As can be seen from https://jenkins.osmocom. […] thanks for pointing me to this file. I now also added an additional test for NG-RAN only. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I910df28c4c59ec94cce9603377786325f6d8c1a3 Gerrit-Change-Number: 26956 Gerrit-PatchSet: 3 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 21:34:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in pysim[master]: add missing bit definition for NG-RAN in xAcT
by bjoern 22 Jan '22

22 Jan '22

Attention is currently required from: laforge, bjoern. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26956 to look at the new patch set (#3). Change subject: add missing bit definition for NG-RAN in xAcT ...................................................................... add missing bit definition for NG-RAN in xAcT when encoding the AcT value bit 11 is correctly set when NG-RAN is present in the string representation, however the decoding of bit 11 was missing. Adds tests for the decoder as well. Change-Id: I910df28c4c59ec94cce9603377786325f6d8c1a3 --- M pySim/utils.py M pysim-testdata/Fairwaves-SIM.ok M pysim-testdata/Wavemobile-SIM.ok M pysim-testdata/sysmoISIM-SJA2.ok M pysim-testdata/sysmoUSIM-SJS1.ok M tests/test_utils.py 6 files changed, 14 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/56/26956/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I910df28c4c59ec94cce9603377786325f6d8c1a3 Gerrit-Change-Number: 26956 Gerrit-PatchSet: 3 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: bjoern <bjoern.c3(a)nixda.biz> Gerrit-MessageType: newpatchset

1 0

Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Factory_ARM/armv7l
by OBS Notification 22 Jan '22

22 Jan '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 54s] [163/180] cumulate libosmoctrl0-1.6.0.46.13fa.202201210032-1.1 [ 54s] [164/180] cumulate libosmonetif8-1.1.0.11.2687.202201210032-1.1 [ 54s] [165/180] cumulate libosmogb12-1.6.0.46.13fa.202201210032-1.1 [ 54s] [166/180] cumulate post-build-checks-84.87+git20210304.df696a0-1.2 [ 54s] [167/180] cumulate pam-1.5.2-5.3 [ 54s] [168/180] cumulate gcc11-11.2.1+git1173-1.3 [ 54s] [169/180] cumulate gcc-11-4.3 [ 54s] [170/180] cumulate libosmonetif-devel-1.1.0.11.2687.202201210032-1.1 [ 54s] [171/180] cumulate libosmoctrl-devel-1.6.0.46.13fa.202201210032-1.1 [ 54s] [172/180] cumulate libosmogb-devel-1.6.0.46.13fa.202201210032-1.1 [ 54s] [173/180] cumulate pam_unix-1.5.2-5.3 [ 54s] [174/180] cumulate python38-3.8.12-3.4 [ 54s] [175/180] cumulate libosmo-sigtran7-1.5.0.4.853c.202201210032-1.1 [ 54s] [176/180] cumulate shadow-4.11.1-1.1 [ 54s] [177/180] cumulate util-linux-2.37.2-2.3 [ 54s] [178/180] cumulate gcc-PIE-11-4.3 [ 54s] [179/180] cumulate libosmo-sigtran-devel-1.5.0.4.853c.202201210032-1.1 [ 54s] [180/180] cumulate rpm-build-4.17.0-2.4 [ 54s] now installing cumulated packages [ 54s] error: .init_b_cache/bash-sh.rpm: signature region trailer: BAD, tag 0 type 0 offset 0 count 0 [ 54s] error: .init_b_cache/bash-sh.rpm cannot be installed [ 54s] exit ... [ 54s] ### VM INTERACTION START ### [ 57s] [ 8.783002][ T382] sysrq: Power Off [ 57s] [ 8.783491][ T7] reboot: Power down [ 57s] ### VM INTERACTION END ### [ 57s] [ 57s] obs-arm-11 failed "build osmo-iuh.spec" at Fri Jan 21 19:04:56 UTC 2022. [ 57s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Build failure of network:osmocom:nightly/libosmo-netif in Debian_Unstable/x86_64
by OBS Notification 22 Jan '22

22 Jan '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/l… Package network:osmocom:nightly/libosmo-netif failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 335s] +{11.000015} [NA|OK] Server's read_cb_srv(): callback triggered [ 335s] +{11.000015} [NA|OK] Server's read_cb_srv(): received 29(29) bytes: 48 69 21 20 66 72 6f 6d 20 63 6f 6e 6e 65 63 74 20 63 61 6c 6c 62 61 63 6b 20 3a 2d 50 [ 335s] +{11.000015} [NA|OK] Server's read_cb_srv(): sent 11 bytes message: 72 65 61 64 5f 63 62 5f 73 72 76 [ 335s] +{11.000015} [OK|OK] Server's read_cb_srv(): keep initial client connection [ 335s] +{11.000017} [NA] Client's read_cb_cli(): callback triggered [ 335s] +{11.000017} [NA] Client's read_cb_cli(): received 11(11) bytes: 72 65 61 64 5f 63 62 5f 73 72 76 [ 335s] +{11.000017} [NA] Client's read_cb_cli(): initial read, contacting server [ 335s] +{11.000017} [OK] Client's read_cb_cli(): sent 29 bytes message: 44 6f 68 2c 20 72 65 73 70 6f 6e 64 69 6e 67 20 74 6f 20 73 65 72 76 65 72 20 3a 2d 44 [ 335s] +{11.000019} [OK|OK] Server's read_cb_srv(): callback triggered [ 335s] +{11.000019} [OK|OK] Server's read_cb_srv(): received 29(29) bytes: 44 6f 68 2c 20 72 65 73 70 6f 6e 64 69 6e 67 20 74 6f 20 73 65 72 76 65 72 20 3a 2d 44 [ 335s] +{11.000019} [OK|OK] Server's read_cb_srv(): sent 11 bytes message: 72 65 61 64 5f 63 62 5f 73 72 76 [ 335s] +{11.000019} [OK|OK] Server's read_cb_srv(): force client disconnect on subsequent call [ 335s] +{11.000020} [OK] Client's read_cb_cli(): callback triggered [ 335s] +{11.000020} [OK] Client's read_cb_cli(): 0-byte read, auto-reconnect will be triggered if enabled [ 335s] +{20.000020} non-reconnecting test complete. [ 335s] [ 335s] Stream tests completed [ 335s] 1. testsuite.at:4: 1. stream_test (testsuite.at:4): FAILED (testsuite.at:8) [ 335s] make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 [ 335s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 335s] make: *** [debian/rules:13: build] Error 2 [ 335s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 335s] ### VM INTERACTION START ### [ 338s] [ 300.157371][ T445] sysrq: Power Off [ 338s] [ 300.190842][ T442] reboot: Power down [ 338s] ### VM INTERACTION END ### [ 338s] [ 338s] lamb06 failed "build libosmo-netif_1.1.0.11.2687.202201210032.dsc" at Fri Jan 21 17:11:44 UTC 2022. [ 338s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Change in osmo-bsc-nat[master]: Add bsc_nat fsm
by pespin 22 Jan '22

22 Jan '22

Attention is currently required from: osmith, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Patch Set 6: (1 comment) File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/e4badc29_99967299 PS6, Line 129: ss7_inst_free(bsc_nat->cn); looks like we want to set the pointers to NULL here after freeing. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 17:00:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc-nat[master]: Add bsc_nat fsm
by osmith 22 Jan '22

22 Jan '22

Attention is currently required from: neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Patch Set 5: (2 comments) File include/osmocom/bsc_nat/bsc_nat_fsm.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/de08ecc5_d24162bf PS5, Line 22: void bsc_nat_fsm_start(struct bsc_nat *bsc_nat); > The API is a bit weird, because you return fi in bsc_nat_fsm_alloc, which is then assigned externall […] Done File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/6f82e076_cb4c7617 PS5, Line 136: static void st_stopped_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) > Please put the on_enter function above the event one. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 16:36:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log