- gerrit-log - lists.osmocom.org

Change in dahdi-linux[master]: enable PPP and DAHDI_MIRROR by default.
by tnt 21 Feb '22

21 Feb '22

Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27264 ) Change subject: enable PPP and DAHDI_MIRROR by default. ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Looks fine to me too. AFAICT all the codepaths this enables don't do anything until they get configured so this shouldn't change anything to default behavior. -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ib03074062ada7b6da485afac53b1550d31f1a5ca Gerrit-Change-Number: 27264 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 21 Feb 2022 10:05:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: initial conn-oriented forwarding
by pespin 21 Feb '22

21 Feb '22

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 ) Change subject: bsc_nat_fsm: initial conn-oriented forwarding ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82 Gerrit-Change-Number: 27260 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 09:39:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: scripts/osmo-ci-docker-rebuild: x86: skip deb11
by pespin 21 Feb '22

21 Feb '22

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27265 ) Change subject: scripts/osmo-ci-docker-rebuild: x86: skip deb11 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3 Gerrit-Change-Number: 27265 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 09:38:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: ggsn: Add timeout to TC_pdp_act_restart_ctr_echo
by pespin 21 Feb '22

21 Feb '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27243 ) Change subject: ggsn: Add timeout to TC_pdp_act_restart_ctr_echo ...................................................................... ggsn: Add timeout to TC_pdp_act_restart_ctr_echo Change-Id: Id9d71504b2da1438239934bfe21934d365b6e333 --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 29 insertions(+), 12 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 675c435..bffdd4c 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -122,7 +122,7 @@ port TELNETasp_PT GGSNVTY; var boolean use_gtpu_txseq := false; - var boolean g_use_echo := false; + var integer g_use_echo_intval := 0; /* 0 = disabled */ /* emulated PCRF, used with m_ggsn_impl = GGSN_IMPL_OPEN5GS */ var DIAMETER_Emulation_CT vc_DIAMETER; @@ -180,11 +180,11 @@ return true; } - private function f_vty_enable_echo_interval(boolean enable) runs on GT_CT { + private function f_vty_enable_echo_interval(integer intval_sec) runs on GT_CT { f_vty_enter_config(GGSNVTY); f_vty_transceive(GGSNVTY, "ggsn ggsn0"); - if (enable) { - f_vty_transceive(GGSNVTY, "echo-interval 5"); + if (intval_sec > 0) { + f_vty_transceive(GGSNVTY, "echo-interval " & int2str(intval_sec)); } else { f_vty_transceive(GGSNVTY, "no echo-interval"); } @@ -253,7 +253,7 @@ if (m_ggsn_impl == GGSN_IMPL_OSMOCOM) { f_init_vty(); f_vty_set_gpdu_txseq(use_gtpu_txseq); - f_vty_enable_echo_interval(g_use_echo); + f_vty_enable_echo_interval(g_use_echo_intval); } else if (m_ggsn_impl == GGSN_IMPL_OPEN5GS) { f_init_diameter(testcasename()); } @@ -263,12 +263,12 @@ private altstep pingpong() runs on GT_CT { var Gtp1cUnitdata ud; var Gtp1uUnitdata udu; - [g_use_echo] GTPC.receive(tr_GTPC_PING(?)) -> value ud { + [g_use_echo_intval > 0] GTPC.receive(tr_GTPC_PING(?)) -> value ud { var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber); GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr)); repeat; }; - [not g_use_echo] GTPC.receive(tr_GTPC_PING(?)) { + [g_use_echo_intval == 0] GTPC.receive(tr_GTPC_PING(?)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "GTP Echo Req rceived but not enabled in VTY"); }; @@ -1781,25 +1781,42 @@ /* Activate PDP context + trigger Recovery procedure through EchoResp */ testcase TC_pdp_act_restart_ctr_echo() runs on GT_CT { var Gtp1cUnitdata ud; - g_use_echo := true; + g_use_echo_intval := 5; + timer T_echo; f_init(); var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn))); f_pdp_ctx_act(ctx); /* Wait to receive echo request and send initial Restart counter */ - GTPC.receive(tr_GTPC_PING(?)) -> value ud { + T_echo.start(int2float(g_use_echo_intval) + 1.0); + alt { + [] GTPC.receive(tr_GTPC_PING(?)) -> value ud { var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber); GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr)); - }; + } + [] T_echo.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Timeout waiting for ping"); + } + } + T_echo.stop; /* Wait to receive second echo request and send incremented Restart counter. This will fake a restarted SGSN, and pdp ctx allocated should be released by GGSN */ g_restart_ctr := int2oct((oct2int(g_restart_ctr) + 1) mod 256, 1); - GTPC.receive(tr_GTPC_PING(?)) -> value ud { + T_echo.start(int2float(g_use_echo_intval) + 1.0); + alt { + [] GTPC.receive(tr_GTPC_PING(?)) -> value ud { var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber); GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr)); - }; + } + [] T_echo.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Timeout waiting for ping"); + } + } + T_echo.stop; f_pdp_ctx_exp_del_req(ctx, omit, true); setverdict(pass); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9d71504b2da1438239934bfe21934d365b6e333 Gerrit-Change-Number: 27243 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: initial conn-oriented forwarding
by osmith 21 Feb '22

21 Feb '22

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 ) Change subject: bsc_nat_fsm: initial conn-oriented forwarding ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/c348e7f7_5e915384 PS2, Line 82: return 1; > Do you really need to return 1 here? isn't 0 enough? I wouldn't complicate function signatures for n […] ACK, fixed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82 Gerrit-Change-Number: 27260 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 09:34:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: initial conn-oriented forwarding
by osmith 21 Feb '22

21 Feb '22

Attention is currently required from: osmith, fixeria. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 to look at the new patch set (#3). Change subject: bsc_nat_fsm: initial conn-oriented forwarding ...................................................................... bsc_nat_fsm: initial conn-oriented forwarding Implement a simple version of forwarding Connection Request, Connection Confirm, Data Form, Released SCCP messages. This is still assuming that there is just one BSC, one MSC, the same connection ID is used in RAN and CN. Future patches will add a mapping between RAN and CN sides and allow multiple BSCs. With this patch it is possible to perform a call between two MS in the following network structure: MS1 --. BTS --- BSC --- BSCNAT --- MSC MS2 --' Related: SYS#5560 Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82 --- M src/osmo-bsc-nat/bsc_nat_fsm.c 1 file changed, 87 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/60/27260/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82 Gerrit-Change-Number: 27260 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ci[master]: scripts/osmo-ci-docker-rebuild: x86: skip deb11
by osmith 21 Feb '22

21 Feb '22

Attention is currently required from: osmith, fixeria. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/27265 to look at the new patch set (#3). Change subject: scripts/osmo-ci-docker-rebuild: x86: skip deb11 ...................................................................... scripts/osmo-ci-docker-rebuild: x86: skip deb11 Don't attempt to build debian-bullseye (11) in docker on debian 10 x86, as it results in: GPG error: http://security.debian.org/debian-security bullseye-security InRelease: At least one invalid signature was encountered. E: The repository 'http://security.debian.org/debian-security bullseye-security InRelease' is not signed. This is a temporary measure until we've upgraded the only jenkins node that runs debian 10 on x86, gtp0-deb10build32. Related: OS#5453 Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3 --- M scripts/osmo-ci-docker-rebuild.sh 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/65/27265/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3 Gerrit-Change-Number: 27265 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ci[master]: scripts/osmo-ci-docker-rebuild: x86: skip deb11
by pespin 21 Feb '22

21 Feb '22

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27265 ) Change subject: scripts/osmo-ci-docker-rebuild: x86: skip deb11 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3 Gerrit-Change-Number: 27265 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 09:28:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: initial conn-oriented forwarding
by pespin 21 Feb '22

21 Feb '22

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 ) Change subject: bsc_nat_fsm: initial conn-oriented forwarding ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/ea9ab676_9dbf1989 PS2, Line 82: return 1; Do you really need to return 1 here? isn't 0 enough? I wouldn't complicate function signatures for no reason. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82 Gerrit-Change-Number: 27260 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 09:27:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: scripts/osmo-ci-docker-rebuild: x86: skip deb11
by osmith 21 Feb '22

21 Feb '22

Attention is currently required from: pespin, fixeria. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/27265 to look at the new patch set (#2). Change subject: scripts/osmo-ci-docker-rebuild: x86: skip deb11 ...................................................................... scripts/osmo-ci-docker-rebuild: x86: skip deb11 Don't attempt to build debian-bullseye (11) in docker on debian 10 x86, as it results in: GPG error: http://security.debian.org/debian-security bullseye-security InRelease: At least one invalid signature was encountered. E: The repository 'http://security.debian.org/debian-security bullseye-security InRelease' is not signed. This is a temporary measure until we've upgraded the only jenkins node that runs debian 10 on x86, gtp0-deb10build32. Related: OS#5453 Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3 --- M scripts/osmo-ci-docker-rebuild.sh 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/65/27265/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3 Gerrit-Change-Number: 27265 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log