Attention is currently required from: manawyrm, tnt.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317 )
Change subject: manual: add info and renders to show to set TE/NT mode
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I5999dc60850da2cd02d9bbc7db5727cdebf041c6
Gerrit-Change-Number: 27317
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 10:12:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, tnt.
manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317 )
Change subject: manual: add info and renders to show to set TE/NT mode
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Nice pics BTW 😊
A picture is worth a thousand words 😊 Thanks!
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I5999dc60850da2cd02d9bbc7db5727cdebf041c6
Gerrit-Change-Number: 27317
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 08:39:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: comment
Attention is currently required from: laforge, tnt.
manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317 )
Change subject: manual: add info and renders to show to set TE/NT mode
......................................................................
Patch Set 2:
(1 comment)
File doc/manuals/chapters/hardware.adoc:
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317/comment/46302c0b_9430…
PS1, Line 69: The icE1usb is shipped in TE configuration. Using a 1:1 patch cable, it can be connected to another device in NT mode. +
> I'd remove this paragraph ( maybe just leave the default setting as a reminder ). […]
Yep, hadn't seen that commit yet. I changed it accordingly.
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I5999dc60850da2cd02d9bbc7db5727cdebf041c6
Gerrit-Change-Number: 27317
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 08:28:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: comment
Attention is currently required from: manawyrm, laforge.
Hello Jenkins Builder, laforge, tnt,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317
to look at the new patch set (#2).
Change subject: manual: add info and renders to show to set TE/NT mode
......................................................................
manual: add info and renders to show to set TE/NT mode
The page break is currently a bit ugly, but I didn't see an easy way
to fix it. The images and info text should make the process much clearer.
Change-Id: I5999dc60850da2cd02d9bbc7db5727cdebf041c6
---
M doc/manuals/chapters/hardware.adoc
A doc/manuals/images/nt_t.png
A doc/manuals/images/te_t.png
3 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/17/27317/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I5999dc60850da2cd02d9bbc7db5727cdebf041c6
Gerrit-Change-Number: 27317
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: manawyrm, laforge.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317 )
Change subject: manual: add info and renders to show to set TE/NT mode
......................................................................
Patch Set 1:
(1 comment)
File doc/manuals/chapters/hardware.adoc:
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317/comment/1b39f166_bfcf…
PS1, Line 69: The icE1usb is shipped in TE configuration. Using a 1:1 patch cable, it can be connected to another device in NT mode. +
I'd remove this paragraph ( maybe just leave the default setting as a reminder ).
Because it's all taken care of in https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27316 already with a slightly more extensive explanation.
So just leave this section about the "how to change mode".
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I5999dc60850da2cd02d9bbc7db5727cdebf041c6
Gerrit-Change-Number: 27317
Gerrit-PatchSet: 1
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 24 Feb 2022 08:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment