dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41272?usp=email )
Change subject: smdpp_Tests: add comments to mp_es9plus_server_port_ module parameters
......................................................................
smdpp_Tests: add comments to mp_es9plus_server_port_ module parameters
Let's add an explanatory comment to mp_es9plus_server_port_nist and
mp_es9plus_server_port_brp
Related: SYS#7339
Change-Id: I7e3f0292256b21a75da5b756ee9af6ec58318de1
---
M smdpp/smdpp_Tests.ttcn
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn
index c268e0e..da4d054 100644
--- a/smdpp/smdpp_Tests.ttcn
+++ b/smdpp/smdpp_Tests.ttcn
@@ -67,8 +67,12 @@
boolean mp_use_custom_tls_cert := true;
charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only
- integer mp_es9plus_server_port_nist := 8000;
- integer mp_es9plus_server_port_brp := 8001;
+
+ /* Sets the server port of the ES9+ server (SM-DP+, NIST certificates) */
+ integer mp_es9plus_server_port_nist := 8000;
+
+ /* Sets the server port of the ES9+ server (SM-DP+, Brainpool certificates) */
+ integer mp_es9plus_server_port_brp := 8001;
}
/* C++ handles only crypto, TTCN-3 handles ASN.1 encoding/decoding most of the time */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41272?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7e3f0292256b21a75da5b756ee9af6ec58318de1
Gerrit-Change-Number: 41272
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41276?usp=email )
Change subject: smdpp_Tests: rename f_rsp_client_init to f_init_es9plus
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41276?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I865b9dfc3597f9a962225880b7a5cda838b8377e
Gerrit-Change-Number: 41276
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Oct 2025 13:04:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41275?usp=email )
Change subject: smdpp_Tests: improve messages when setting verdict in f_init_es9plus
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41275?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6b55d0bb6d5bd698241a990cf8388adc68a99543
Gerrit-Change-Number: 41275
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Oct 2025 13:01:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes