- gerrit-log - lists.osmocom.org

[XL] Change in osmo-ttcn3-hacks[master]: stp: Introduce STP_Tests_TCAP
by lynxis lazus 31 Oct '25

31 Oct '25

lynxis lazus has uploaded a new patch set (#6) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: stp: Introduce STP_Tests_TCAP ...................................................................... stp: Introduce STP_Tests_TCAP The network topology and test infrastructure already allows testing TCAP forwarding at STP over IPA<->IPA, M3UA<->IPA and M3UA<->M3UA. Co-authored: Alexander Couzens <lynxis(a)fe80.eu> Related: SYS#5423 Change-Id: I4340bdf126118c66af861f5a447e90883783920e --- M stp/STP_Tests_Common.ttcn A stp/STP_Tests_TCAP.cfg A stp/STP_Tests_TCAP.ttcn M stp/expected-results.xml M stp/gen_links.sh A stp/osmo-stp-tcap.confmerge M stp/regen_makefile.sh A stp/testenv_tcap.cfg 8 files changed, 1,062 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/41136/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e Gerrit-Change-Number: 41136 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: xua_msg_copy(): add missing check if xua_msg_alloc() fails
by lynxis lazus 31 Oct '25

31 Oct '25

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41205?usp=email ) Change subject: xua_msg_copy(): add missing check if xua_msg_alloc() fails ...................................................................... xua_msg_copy(): add missing check if xua_msg_alloc() fails Change-Id: I7f2e098dcf7790862eb509357f8d214c87212381 --- M src/xua_msg.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/xua_msg.c b/src/xua_msg.c index 0652277..1761fee 100644 --- a/src/xua_msg.c +++ b/src/xua_msg.c @@ -62,6 +62,8 @@ { struct xua_msg_part *part; struct xua_msg *xua_cpy = xua_msg_alloc(); + if (!xua_cpy) + return NULL; xua_cpy->hdr = xua_in->hdr; xua_cpy->mtp = xua_in->mtp; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7f2e098dcf7790862eb509357f8d214c87212381 Gerrit-Change-Number: 41205 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-ttcn3-hacks[master]: stp: Introduce STP_Tests_TCAP
by lynxis lazus 31 Oct '25

31 Oct '25

lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email ) Change subject: stp: Introduce STP_Tests_TCAP ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e Gerrit-Change-Number: 41136 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 31 Oct 2025 14:42:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-ttcn3-hacks[master]: stp: Introduce STP_Tests_TCAP
by lynxis lazus 31 Oct '25

31 Oct '25

lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email ) Change subject: stp: Introduce STP_Tests_TCAP ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e Gerrit-Change-Number: 41136 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 31 Oct 2025 14:33:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: library: TCAP: ts_TCAP_UNITDATA_req: allow to define the returnOption
by lynxis lazus 31 Oct '25

31 Oct '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41291?usp=email ) Change subject: library: TCAP: ts_TCAP_UNITDATA_req: allow to define the returnOption ...................................................................... library: TCAP: ts_TCAP_UNITDATA_req: allow to define the returnOption TCAP loadsharing will use RETURN_OPTION_ON_ERROR option to test UDTS when no TCAP ranges matches. Related: SYS#5423 Change-Id: Ie4f6d9e02f65687c3158cae41f28aa30b95f85f8 --- M library/tcap/TCAP_CodecPort.ttcn 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/41291/1 diff --git a/library/tcap/TCAP_CodecPort.ttcn b/library/tcap/TCAP_CodecPort.ttcn index 50b0eed..882a288 100644 --- a/library/tcap/TCAP_CodecPort.ttcn +++ b/library/tcap/TCAP_CodecPort.ttcn @@ -20,6 +20,9 @@ import from TCAPMessages language "ASN.1:1997" all; import from TCAP_Types all; +const BIT8n RETURN_OPTION_DISCARD := '00000000'B; +const BIT8n RETURN_OPTION_ON_ERROR := '00000001'B; + type record TCAP_N_CONNECT_req { SCCP_PAR_Address calledAddress, @@ -187,11 +190,12 @@ template (value) TCAP_N_UNITDATA_req ts_TCAP_UNITDATA_req(SCCP_PAR_Address called, SCCP_PAR_Address calling, - template (value) TCMessage payload) := { + template (value) TCMessage payload, + template (omit) SCCP_PAR_Return_Option returns := omit) := { calledAddress := called, callingAddress := calling, sequenceControl := omit, - returnOption := omit, + returnOption := returns, userData := payload, importance := omit } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41291?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4f6d9e02f65687c3158cae41f28aa30b95f85f8 Gerrit-Change-Number: 41291 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: library: TCAP: add tr_TCAP_N_NOTICE_ind
by lynxis lazus 31 Oct '25

31 Oct '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41292?usp=email ) Change subject: library: TCAP: add tr_TCAP_N_NOTICE_ind ...................................................................... library: TCAP: add tr_TCAP_N_NOTICE_ind A SCCP UTDS will be passed to the TCAP layer as TCAP_N_NOTICE_ind. Will be used by utds testsing of tcap loadsharing. Related: SYS#5423 Change-Id: I002afabb8e827dc35cd9f4e37a6970d91600ee37 --- M library/tcap/TCAP_CodecPort.ttcn 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/41292/1 diff --git a/library/tcap/TCAP_CodecPort.ttcn b/library/tcap/TCAP_CodecPort.ttcn index 882a288..cb52814 100644 --- a/library/tcap/TCAP_CodecPort.ttcn +++ b/library/tcap/TCAP_CodecPort.ttcn @@ -230,6 +230,16 @@ SCCP_PAR_Importance importance optional } +template (present) TCAP_N_NOTICE_ind tr_TCAP_N_NOTICE_ind(template SCCP_PAR_Address called, + template SCCP_PAR_Address calling, + template SCCP_PAR_Reason_For_Return reason, + template TCMessage payload) := { + calledAddress := called, + callingAddress := calling, + reasonForReturn := reason, + userData := payload, + importance := * +} private function f_dec_ConnectInd(in ASP_SCCP_N_CONNECT_ind pin, out TCAP_N_CONNECT_ind pout) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41292?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I002afabb8e827dc35cd9f4e37a6970d91600ee37 Gerrit-Change-Number: 41292 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: IPA: Introduce new OSMO extension TCAP_ROUTING
by lynxis lazus 31 Oct '25

31 Oct '25

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41135?usp=email ) Change subject: IPA: Introduce new OSMO extension TCAP_ROUTING ...................................................................... IPA: Introduce new OSMO extension TCAP_ROUTING TCAP_ROUTING is an extension to IPA/SCCP where the node can requests to receive only certain TCAP traffic to support loadsharing. Related: SYS#5423 Change-Id: Ibfcf633f7bd8773f557901fdff7580f5879391a1 --- A library/IPA_EXT_TCAP_ROUTING.ttcn M library/IPA_Emulation.ttcnpp M library/IPA_Types.ttcn 3 files changed, 142 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/library/IPA_EXT_TCAP_ROUTING.ttcn b/library/IPA_EXT_TCAP_ROUTING.ttcn new file mode 100644 index 0000000..a7f890c --- /dev/null +++ b/library/IPA_EXT_TCAP_ROUTING.ttcn @@ -0,0 +1,98 @@ +/* IPA Osmo Extension: TCAP_ROUTING, used to set up TCAP routes in osmo-stp. + * (C) 2025 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module IPA_EXT_TCAP_ROUTING { + +import from General_Types all; +import from Osmocom_Types all; +import from Native_Functions all; + +type enumerated IPA_EXT_TCAP_ROUTING_MsgType { + IPA_EXT_TCAP_ROUTING_MSG_TID_ADD_RANGE ('01'O), + IPA_EXT_TCAP_ROUTING_MSG_TID_ACK ('02'O), + IPA_EXT_TCAP_ROUTING_MSG_TID_NACK ('03'O) +} with { variant "FIELDLENGTH(8)" }; + +type record IPA_EXT_TCAP_ROUTING_Hdr { + IPA_EXT_TCAP_ROUTING_MsgType msg_type, + uint32_t seq_nr +} with { variant "" }; + +const uint8_t IPA_EXT_TCAP_ROUTING_SSN_WILDCARD := 0; +const uint32_t IPA_EXT_TCAP_ROUTING_PC_WILDCARD := 4294967295; + +type record IPA_EXT_TCAP_ROUTING_ADD_RANGE { + uint32_t tid_start, + uint32_t tid_end, + uint32_t pc, + uint8_t ssn +} with { variant "" }; + +type record IPA_EXT_TCAP_ROUTING_ACK { +} with { variant "" }; + +type record IPA_EXT_TCAP_ROUTING_NACK { + uint8_t cause +} with { variant "" }; + +type union IPA_EXT_TCAP_ROUTING_MsgUnion { + IPA_EXT_TCAP_ROUTING_ADD_RANGE add_range, + IPA_EXT_TCAP_ROUTING_ACK ack, + IPA_EXT_TCAP_ROUTING_NACK nack +} with { variant "" }; + +type record IPA_EXT_TCAP_ROUTING_Message { + IPA_EXT_TCAP_ROUTING_MsgType msg_type, + uint32_t seq_nr, + IPA_EXT_TCAP_ROUTING_MsgUnion u +} with { variant (u) "CROSSTAG(add_range, msg_type = IPA_EXT_TCAP_ROUTING_MSG_TID_ADD_RANGE; + ack, msg_type = IPA_EXT_TCAP_ROUTING_MSG_TID_ACK; + nack, msg_type = IPA_EXT_TCAP_ROUTING_MSG_TID_NACK)" +}; + +external function enc_IPA_EXT_TCAP_ROUTING_Message(in IPA_EXT_TCAP_ROUTING_Message pdu) return octetstring + with { extension "prototype(convert) encode(RAW)" }; +external function dec_IPA_EXT_TCAP_ROUTING_Message(in octetstring stream) return IPA_EXT_TCAP_ROUTING_Message + with { extension "prototype(convert) decode(RAW)" }; + +/* Generic template for matching messages by type */ +template (present) IPA_EXT_TCAP_ROUTING_Message +tr_IPA_EXT_TCAP_ROUTING_Message(template (present) IPA_EXT_TCAP_ROUTING_MsgType msg_type := ?) := { + msg_type := msg_type, + seq_nr := ?, + u := ? +} + +template (present) IPA_EXT_TCAP_ROUTING_Message +tr_IPA_EXT_TCAP_ROUTING_ACK := tr_IPA_EXT_TCAP_ROUTING_Message(IPA_EXT_TCAP_ROUTING_MSG_TID_ACK); + +template (present) IPA_EXT_TCAP_ROUTING_Message +tr_IPA_EXT_TCAP_ROUTING_NACK := tr_IPA_EXT_TCAP_ROUTING_Message(IPA_EXT_TCAP_ROUTING_MSG_TID_NACK); + +template (value) IPA_EXT_TCAP_ROUTING_Message +ts_IPA_EXT_TCAP_ROUTING_ADD_RANGE(template (value) uint32_t seq_nr, + template (value) uint32_t tid_start, + template (value) uint32_t tid_end, + template (value) uint32_t pc, + template (value) uint8_t ssn) := { + msg_type := IPA_EXT_TCAP_ROUTING_MSG_TID_ADD_RANGE, + seq_nr := seq_nr, + u := { + add_range := { + tid_start := tid_start, + tid_end := tid_end, + pc := pc, + ssn := ssn + } + } +} + + +} with { encode "RAW" }; diff --git a/library/IPA_Emulation.ttcnpp b/library/IPA_Emulation.ttcnpp index 2df598a..9105f41 100644 --- a/library/IPA_Emulation.ttcnpp +++ b/library/IPA_Emulation.ttcnpp @@ -60,6 +60,10 @@ import from PCUIF_Types all; #endif +#ifdef IPA_EMULATION_TCAP_ROUTING +import from IPA_EXT_TCAP_ROUTING all; +#endif + modulepar { /* Use Osmocom extended IPA mux header */ boolean mp_ipa_mgcp_uses_osmo_ext := true; @@ -202,6 +206,12 @@ } with { extension "internal" } #endif +#ifdef IPA_EMULATION_TCAP_ROUTING +/* Client port for Osmocom PCU extension inside IPA */ +type port IPA_TCAP_ROUTING_PT message { + inout IPA_EXT_TCAP_ROUTING_Message, ASP_IPA_Event; +} with { extension "internal" } +#endif type component IPA_Emulation_CT { @@ -242,6 +252,10 @@ /* up-facing port for RSPRO */ port IPA_OSMO_PCU_PT IPA_OSMO_PCU_PORT; #endif +#ifdef IPA_EMULATION_TCAP_ROUTING + /* up-facing port for RSPRO */ + port IPA_TCAP_ROUTING_PT IPA_TCAP_ROUTING_PORT; +#endif /* up-facing port for other streams */ port IPA_SP_PT IPA_SP_PORT; @@ -410,6 +424,11 @@ IPA_OSMO_PCU_PORT.send(evt); } #endif +#ifdef IPA_EMULATION_TCAP_ROUTING + if (IPA_TCAP_ROUTING_PORT.checkstate("Connected")) { + IPA_TCAP_ROUTING_PORT.send(evt); + } +#endif /* FIXME: to other ports */ } @@ -657,6 +676,13 @@ } #endif +#ifdef IPA_EMULATION_TCAP_ROUTING +private function f_tcap_routing_to_user(octetstring msg) runs on IPA_Emulation_CT { + var IPA_EXT_TCAP_ROUTING_Message pcuif_msg := dec_IPA_EXT_TCAP_ROUTING_Message(msg); + IPA_TCAP_ROUTING_PORT.send(pcuif_msg); +} +#endif + #ifdef IPA_EMULATION_MGCP private function f_mgcp_to_user(octetstring msg) runs on IPA_Emulation_CT { var charstring msg_ch := oct2char(msg); @@ -734,6 +760,9 @@ #ifdef IPA_EMULATION_OSMO_PCU var PCUIF_Message pcu; #endif +#ifdef IPA_EMULATION_TCAP_ROUTING + var IPA_EXT_TCAP_ROUTING_Message tcap_routing; +#endif /* Set function for dissecting the binary */ var f_IPL4_getMsgLen vl_f := refers(f_IPL4_fixedMsgLen); @@ -815,6 +844,11 @@ f_osmo_pcu_to_user(ipa_rx.msg); } #endif +#ifdef IPA_EMULATION_TCAP_ROUTING + case (IPAC_PROTO_EXT_TCAP_ROUTING) { + f_tcap_routing_to_user(ipa_rx.msg); + } +#endif case else { IPA_SP_PORT.send(f_to_asp(ipa_rx)); } @@ -916,6 +950,14 @@ } #endif +#ifdef IPA_EMULATION_TCAP_ROUTING + [] IPA_TCAP_ROUTING_PORT.receive(IPA_EXT_TCAP_ROUTING_Message:?) -> value tcap_routing { + payload := enc_IPA_EXT_TCAP_ROUTING_Message(tcap_routing); + ipa_ud := valueof(t_ASP_IPA_UD(IPAC_PROTO_OSMO, payload, IPAC_PROTO_EXT_TCAP_ROUTING)); + IPA_PORT.send(f_from_asp(f_ipa_conn_id(), ipa_ud)); + } +#endif + #ifdef IPA_EMULATION_RSL /* Received RSL -> down into IPA */ [] IPA_RSL_PORT.receive(ASP_RSL_Unitdata:?) -> value rsl { diff --git a/library/IPA_Types.ttcn b/library/IPA_Types.ttcn index fc729fb..4329f00 100644 --- a/library/IPA_Types.ttcn +++ b/library/IPA_Types.ttcn @@ -36,7 +36,8 @@ IPAC_PROTO_EXT_GSUP ('05'H), IPAC_PROTO_EXT_OAP ('06'H), IPAC_PROTO_EXT_RSPRO ('07'H), - IPAC_PROTO_EXT_OSMO_PCU ('08'H) + IPAC_PROTO_EXT_OSMO_PCU ('08'H), + IPAC_PROTO_EXT_TCAP_ROUTING ('09'H) } with { variant "FIELDLENGTH(8)" } external function enc_PDU_IPA(in PDU_IPA pdu) return octetstring -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfcf633f7bd8773f557901fdff7580f5879391a1 Gerrit-Change-Number: 41135 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: IPA: Introduce new OSMO extension TCAP_ROUTING
by lynxis lazus 31 Oct '25

31 Oct '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41135?usp=email ) Change subject: IPA: Introduce new OSMO extension TCAP_ROUTING ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: 1+1 = 2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfcf633f7bd8773f557901fdff7580f5879391a1 Gerrit-Change-Number: 41135 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Oct 2025 14:31:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: pySim-shell: allow user friendly selection of the pin type
by osmith 31 Oct '25

31 Oct '25

Attention is currently required from: dexter. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41251?usp=email ) Change subject: pySim-shell: allow user friendly selection of the pin type ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0b58c402d95cbc4fe690e6edb214829d463e9f2c Gerrit-Change-Number: 41251 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Oct 2025 14:02:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: pySim-shell: allow user friendly selection of the pin type
by laforge 31 Oct '25

31 Oct '25

Attention is currently required from: dexter, osmith. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41251?usp=email ) Change subject: pySim-shell: allow user friendly selection of the pin type ...................................................................... Patch Set 2: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/41251/comment/320cb227_e9bab154?usp=em… : PS2, Line 942: vague hypothesis regarding the linter error: it might be that (the linter things) this is not possible for a staticmethod, as it might be called from some very early code at runtime at a time the inverse property has not been set up yet? Otherwise I don't see why in line 857 the same approach passses the linter, while here it doesn't -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0b58c402d95cbc4fe690e6edb214829d463e9f2c Gerrit-Change-Number: 41251 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Oct 2025 14:00:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log