Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-pcap failed to build in openSUSE_Leap_15.2/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-pcap
Last lines of build log:
[ 35s] checking how to run the C preprocessor... gcc -E
[ 35s] checking for grep that handles long lines and -e... /usr/bin/grep
[ 35s] checking for egrep... /usr/bin/grep -E
[ 35s] checking for ANSI C header files... yes
[ 35s] checking whether to enable VTY tests... no
[ 35s] checking for pcap-config... /usr/bin/pcap-config
[ 35s] checking for libosmocore >= 1.6.0... no
[ 36s] configure: error: Package requirements (libosmocore >= 1.6.0) were not met:
[ 36s]
[ 36s] Package 'libsctp', required by 'libosmocore', not found
[ 36s]
[ 36s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 36s] installed software in a non-standard prefix.
[ 36s]
[ 36s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS
[ 36s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config.
[ 36s] See the pkg-config man page for more details.
[ 36s] error: Bad exit status from /var/tmp/rpm-tmp.patfK2 (%build)
[ 36s]
[ 36s]
[ 36s] RPM build errors:
[ 36s] Bad exit status from /var/tmp/rpm-tmp.patfK2 (%build)
[ 36s] ### VM INTERACTION START ###
[ 36s] [ 29.696995] sysrq: Power Off
[ 36s] [ 29.700878] reboot: Power down
[ 36s] ### VM INTERACTION END ###
[ 36s]
[ 36s] lamb17 failed "build osmo-pcap.spec" at Mon Mar 28 00:32:25 UTC 2022.
[ 36s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27580 )
Change subject: libosmovty: Link libosmovty against libpthread
......................................................................
libosmovty: Link libosmovty against libpthread
Ever since Change-Id If76a4bd2cc7b3c7adf5d84790a944d78be70e10a in 2020
(part of libosmocore >= 1.4.0) we have introduced cpu_sched_vty.c, which
directly uses libpthread. As a result, libosmovty should be using
pthread compiler flags and link against libpthread.
This missing dependency is causing osmocom applications to
fail to link on OpenWRT (at leats for ath79-generic).
Change-Id: I7febbf88cbe61eacd05f46a9316e773b5c148e77
Related: SYS#4986
---
M src/vty/Makefile.am
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/27580/1
diff --git a/src/vty/Makefile.am b/src/vty/Makefile.am
index c73dbb2..37faad6 100644
--- a/src/vty/Makefile.am
+++ b/src/vty/Makefile.am
@@ -4,7 +4,7 @@
LIBVERSION=10:0:1
AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include
-AM_CFLAGS = -Wall $(TALLOC_CFLAGS)
+AM_CFLAGS = -Wall $(TALLOC_CFLAGS) $(PTHREAD_CFLAGS)
if ENABLE_VTY
lib_LTLIBRARIES = libosmovty.la
@@ -14,5 +14,5 @@
fsm_vty.c talloc_ctx_vty.c \
cpu_sched_vty.c tdef_vty.c
libosmovty_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined
-libosmovty_la_LIBADD = $(top_builddir)/src/libosmocore.la $(TALLOC_LIBS)
+libosmovty_la_LIBADD = $(top_builddir)/src/libosmocore.la $(TALLOC_LIBS) $(PTHREAD_LIBS)
endif
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27580
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7febbf88cbe61eacd05f46a9316e773b5c148e77
Gerrit-Change-Number: 27580
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27579 )
Change subject: usb: Deal with truncated ISO IN transfers
......................................................................
usb: Deal with truncated ISO IN transfers
It seems that in some circumstances, an ISO IN transfer can be
truncated by the bus / host. In such situation we'd currently pass
a non-modulo-32 length to the mux_demux (deframer) code, and it ASSERTs
on that. Let's try to handle this more gracefully by substituting
random garbage and letting higher layers deal with massive bit errors.
Related: OS#5490
Change-Id: Ic453325b93b0e12727625a1495a948d96df4b542
---
M src/usb.c
1 file changed, 24 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/79/27579/1
diff --git a/src/usb.c b/src/usb.c
index 4d30742..074e836 100644
--- a/src/usb.c
+++ b/src/usb.c
@@ -201,9 +201,9 @@
{
struct e1_usb_flow *flow = (struct e1_usb_flow *) xfr->user_data;
struct e1_usb_intf_data *id = (struct e1_usb_intf_data *) flow->line->intf->drv_data;
- int j, rv, len;
+ int j, rv, size;
- len = 0;
+ size = 0;
/* FIXME: Check transfer status ? Error handling ? */
@@ -211,16 +211,34 @@
if (flow->ep & 0x80) {
for (j = 0; j < flow->ppx; j++) {
struct libusb_iso_packet_descriptor *iso_pd = &xfr->iso_packet_desc[j];
+ int len = (int) iso_pd->actual_length;
if (iso_pd->status != LIBUSB_TRANSFER_COMPLETED) {
LOGPLI(flow->line, DE1D, LOGL_ERROR, "IN EP %02x ISO packet %d failed with status %s\n",
flow->ep, j, get_value_string(libusb_status_str, iso_pd->status));
+ } else if (len > 4 && (len - 4) % 32) {
+ /* some ISO IN packet was truncated. Apparently this
+ * does happen, see https://osmocom.org/issues/5490 -
+ * there is little we can do here, but instead of the
+ * earlier ASSERT, we just feed some garbage for the
+ * last few timeslots, resulting in bit errors etc. */
+ LOGPLI(flow->line, DE1D, LOGL_ERROR, "IN EP %02x ISO packet %d truncated: len-4 = %u\n",
+ flow->ep, j, len-4);
+
+ /* The assumption here is that only the last E1 frame is
+ * truncated, as we have no idea how many E1 frames the
+ * USB device firmware wanted to send us. */
+ len += 32 - (len % 32);
+ /* don't overflow the underlying buffer */
+ if (len > (int) iso_pd->length)
+ len = iso_pd->length;
}
+
flow->cb(flow,
libusb_get_iso_packet_buffer_simple(xfr, j),
- (iso_pd->status == LIBUSB_TRANSFER_COMPLETED) ? (int)iso_pd->actual_length : -1,
+ (iso_pd->status == LIBUSB_TRANSFER_COMPLETED) ? len : -1,
iso_pd->length
);
- len += (iso_pd->length = flow->size);
+ size += (iso_pd->length = flow->size);
}
} else {
for (j = 0; j < flow->ppx; j++) {
@@ -229,12 +247,12 @@
LOGPLI(flow->line, DE1D, LOGL_ERROR, "OUT EP %02x ISO packet %d failed with status %s\n",
flow->ep, j, get_value_string(libusb_status_str, iso_pd->status));
}
- len += (iso_pd->length = flow->cb(flow, &xfr->buffer[len], flow->size, flow->size));
+ size += (iso_pd->length = flow->cb(flow, &xfr->buffer[size], flow->size, flow->size));
}
}
libusb_fill_iso_transfer(xfr, id->devh, flow->ep,
- xfr->buffer, len, flow->ppx,
+ xfr->buffer, size, flow->ppx,
_e1uf_xfr, flow, 0
);
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27579
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ic453325b93b0e12727625a1495a948d96df4b542
Gerrit-Change-Number: 27579
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: astrid smith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27575 )
Change subject: ts_31_103: Correct file-id of EF.DOMAIN in ADF.ISIM
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/27575
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idd572ab064ea38e74dffd583c27ea505b23214a2
Gerrit-Change-Number: 27575
Gerrit-PatchSet: 2
Gerrit-Owner: astrid smith <astrid(a)shady.tel>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: astrid smith <astrid(a)shady.tel>
Gerrit-Comment-Date: Sun, 27 Mar 2022 11:47:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment