- gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: libosmo-gtlv: add C code generator for IE structs and arrays
by neels 28 Mar '22

28 Mar '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27219 ) Change subject: libosmo-gtlv: add C code generator for IE structs and arrays ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: combine votes -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ifb3ea54d2797ce060b95834aa117725ec2d6c4cf Gerrit-Change-Number: 27219 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 11:41:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: libosmo-gtlv: add TLIV capability
by neels 28 Mar '22

28 Mar '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27529 ) Change subject: libosmo-gtlv: add TLIV capability ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: combine votes -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I0a076e54dfba6038cc779cb7c8f3967d212226aa Gerrit-Change-Number: 27529 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 11:41:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: libosmo-pfcp: add pfcp_proto.h pfcp_strs.h
by neels 28 Mar '22

28 Mar '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27221 ) Change subject: libosmo-pfcp: add pfcp_proto.h pfcp_strs.h ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Patchset: PS7: combine votes -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I568b821e89007ed52eeefcdbcb6edd8052a8b5be Gerrit-Change-Number: 27221 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 11:41:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: libosmo-pfcp: implement/generate TLV and IE value coding
by neels 28 Mar '22

28 Mar '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27222 ) Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ...................................................................... Patch Set 11: Code-Review+2 (1 comment) Patchset: PS11: combine votes -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 Gerrit-Change-Number: 27222 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 11:41:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: libosmo-gtlv: add generic TLV de- and encoder
by neels 28 Mar '22

28 Mar '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27217 ) Change subject: libosmo-gtlv: add generic TLV de- and encoder ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: sure, can do. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib0fd00d9f288ffe13b7e67701f3e47073587404a Gerrit-Change-Number: 27217 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 11:39:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in meta-telephony[laforge/nightly]: libosmocore: depend on lksctp-tools
by pespin 28 Mar '22

28 Mar '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27589 ) Change subject: libosmocore: depend on lksctp-tools ...................................................................... Patch Set 1: (1 comment) File recipes-osmocom/libosmocore/libosmocore.inc: https://gerrit.osmocom.org/c/meta-telephony/+/27589/comment/3ab4cf45_ae2c4e… PS1, Line 5: INC_PR="r2.${META_TELEPHONY_OSMO_INC}" > I don't think it's strictly necessary. […] Ack -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ife02efc7efc8f55745ea868fd9e3919bc779da28 Gerrit-Change-Number: 27589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 11:07:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in meta-telephony[laforge/nightly]: libosmocore: depend on lksctp-tools
by osmith 28 Mar '22

28 Mar '22

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27589 ) Change subject: libosmocore: depend on lksctp-tools ...................................................................... Patch Set 1: (1 comment) File recipes-osmocom/libosmocore/libosmocore.inc: https://gerrit.osmocom.org/c/meta-telephony/+/27589/comment/19652429_1044e6… PS1, Line 5: INC_PR="r2.${META_TELEPHONY_OSMO_INC}" > You missed incrementing PR here. I don't think it's strictly necessary. if somebody installed the previous package already, they will be able to upgrade to a newer package with this patch applied since it's built from a newer git revision. so practically it shouldn't make a difference. However if it's important to you I could submit a follow-up patch that bumps the PR. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ife02efc7efc8f55745ea868fd9e3919bc779da28 Gerrit-Change-Number: 27589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 10:52:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in meta-telephony[laforge/nightly]: libosmocore: depend on lksctp-tools
by pespin 28 Mar '22

28 Mar '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27589 ) Change subject: libosmocore: depend on lksctp-tools ...................................................................... Patch Set 1: (1 comment) File recipes-osmocom/libosmocore/libosmocore.inc: https://gerrit.osmocom.org/c/meta-telephony/+/27589/comment/33421801_a8af15… PS1, Line 5: INC_PR="r2.${META_TELEPHONY_OSMO_INC}" You missed incrementing PR here. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ife02efc7efc8f55745ea868fd9e3919bc779da28 Gerrit-Change-Number: 27589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 10:26:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: OCTOI: initial support for E1oIP forwarding
by laforge 28 Mar '22

28 Mar '22

Attention is currently required from: manawyrm, laforge, tnt. Hello Jenkins Builder, manawyrm, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/27588 to look at the new patch set (#5). Change subject: OCTOI: initial support for E1oIP forwarding ...................................................................... OCTOI: initial support for E1oIP forwarding This introduces initial support for operation as OCTOI (Osmocom Community TDMoIP) server and client operation. Various features are still absent (user authentication, support for re-ordered packets), but this version is already able to provide services to clients with dynamic IP addresses as well as servers. The bulk of the OCTOI / E1oIP code is implemented as a shared library, to facilitate the development of other servers and clients in the future, and also to minimize the impact on the existing osmo-e1d code base. More information is available at https://osmocom.org/projects/octoi/wiki Change-Id: I05f5ff697ca8f7dccdcf89660f12089babfcc92e --- M Makefile.am M configure.ac M debian/control A debian/libosmo-octoi-dev.install A debian/libosmo-octoi0.install M include/Makefile.am M include/osmocom/e1d/proto.h A include/osmocom/octoi/e1oip_proto.h A include/osmocom/octoi/octoi.h A libosmo-octoi.pc.in M src/Makefile.am M src/ctl.c M src/e1d.h A src/e1oip.c M src/intf_line.c M src/mux_demux.c A src/octoi/Makefile.am A src/octoi/e1oip.c A src/octoi/e1oip.h A src/octoi/frame_fifo.c A src/octoi/frame_fifo.h A src/octoi/libosmo-octoi.map A src/octoi/octoi.c A src/octoi/octoi.h A src/octoi/octoi_clnt_fsm.c A src/octoi/octoi_clnt_vty.c A src/octoi/octoi_fsm.c A src/octoi/octoi_fsm.h A src/octoi/octoi_sock.c A src/octoi/octoi_sock.h A src/octoi/octoi_srv_fsm.c A src/octoi/octoi_srv_vty.c A src/octoi/octoi_vty.h M src/osmo-e1d.c M src/usb.c M src/vty.c 36 files changed, 3,427 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/88/27588/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I05f5ff697ca8f7dccdcf89660f12089babfcc92e Gerrit-Change-Number: 27588 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newpatchset

1 0

Change in osmo-e1d[master]: intf_line: Ensure unique rate counter group indexes
by laforge 28 Mar '22

28 Mar '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27585 ) Change subject: intf_line: Ensure unique rate counter group indexes ...................................................................... intf_line: Ensure unique rate counter group indexes When we have multiple interfaces, we cannot simply use the line->id as rate counter group index, but should use a combination of interface id and line id. Change-Id: I515c1f39285489845f88c3403ebf16835571e154 --- M src/intf_line.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved tnt: Looks good to me, but someone else must approve diff --git a/src/intf_line.c b/src/intf_line.c index 9146368..bd7a393 100644 --- a/src/intf_line.c +++ b/src/intf_line.c @@ -247,7 +247,7 @@ } else line->id = line_id; - line->ctrs = rate_ctr_group_alloc(line, &line_ctrg_desc, line->id); + line->ctrs = rate_ctr_group_alloc(line, &line_ctrg_desc, intf->id << 8 | line->id); OSMO_ASSERT(line->ctrs); osmo_timer_setup(&line->ts0.timer, _ts0_tmr_cb, line); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I515c1f39285489845f88c3403ebf16835571e154 Gerrit-Change-Number: 27585 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log