- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: struct gsm_encr: store alg_id in human-readable format
by neels 29 Mar '22

29 Mar '22

Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27509 ) Change subject: struct gsm_encr: store alg_id in human-readable format ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Patchset: PS3: reading this patch makes me feel nerdy good File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/c7cb4261_71a13098 PS3, Line 168: %d (it's a uint8_t. at least it now outputs the correct human readable nr...) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ieb50c9a352cfa5481aebac2379e0a461663543ec Gerrit-Change-Number: 27509 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 11:42:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: Add ss7 instances to osmo_ss7_instances in creation order
by pespin 29 Mar '22

29 Mar '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 to look at the new patch set (#2). Change subject: Add ss7 instances to osmo_ss7_instances in creation order ...................................................................... Add ss7 instances to osmo_ss7_instances in creation order Otherwise when configuring ss7 instances in numerical order in the VTY and then printing the VTY configuration they end up ordered this way: cs7 instance 2 cs7 instance 1 cs7 instance 0 Related: SYS#5912 Change-Id: Id4d0a20cc5b0811b505b2d1051d496f8bd17d54c --- M src/osmo_ss7.c M tests/vty/ss7_asp_test.vty 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/99/27599/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Id4d0a20cc5b0811b505b2d1051d496f8bd17d54c Gerrit-Change-Number: 27599 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-sccp[master]: Add ss7 instances to osmo_ss7_instances in creation order
by pespin 29 Mar '22

29 Mar '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 ) Change subject: Add ss7 instances to osmo_ss7_instances in creation order ...................................................................... Add ss7 instances to osmo_ss7_instances in creation order Otherwise when configuring ss7 instances in numerical order in the VTY and then printing the VTY configuration they end up ordered this way: cs7 instance 2 cs7 instance 1 cs7 instance 0 Related: SYS#5912 Change-Id: Id4d0a20cc5b0811b505b2d1051d496f8bd17d54c --- M src/osmo_ss7.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/99/27599/1 diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 99536d3..a4af727 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -399,7 +399,7 @@ inst->cfg.pc_fmt.component_len[1] = 8; inst->cfg.pc_fmt.component_len[2] = 3; - llist_add(&inst->list, &osmo_ss7_instances); + llist_add_tail(&inst->list, &osmo_ss7_instances); INIT_LLIST_HEAD(&inst->cfg.sccp_address_book); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Id4d0a20cc5b0811b505b2d1051d496f8bd17d54c Gerrit-Change-Number: 27599 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: hodec2: add penalty-time low-rxqual-ho
by pespin 29 Mar '22

29 Mar '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27596 ) Change subject: hodec2: add penalty-time low-rxqual-ho ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I057b156604a104a26a7ce45d1c7adadbf452c932 Gerrit-Change-Number: 27596 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:43:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: hodec2: add penalty-time low-rxqual-ho
by pespin 29 Mar '22

29 Mar '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27596 ) Change subject: hodec2: add penalty-time low-rxqual-ho ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: You forgot to update one vty file -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I057b156604a104a26a7ce45d1c7adadbf452c932 Gerrit-Change-Number: 27596 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:40:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Add tests for CBSP MESSAGE STATUS QUERY procedure
by pespin 29 Mar '22

29 Mar '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27594 ) Change subject: bsc: Add tests for CBSP MESSAGE STATUS QUERY procedure ...................................................................... Patch Set 1: (1 comment) File library/CBSP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27594/comment/15260429_4940… PS1, Line 713: function ts_CBSP_MSG_STATUS_QUERY_FAIL(template (value) uint16_t msg_id, template (value) uint16_t old_ser_nr, we usually have f_ts_* and f_tr_* for functions like this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I124a69c515d634bc054ed35e430af6b3c11ad46e Gerrit-Change-Number: 27594 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:39:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: CBSP_Types: Fix typo num_bcats_compl -> num_bcast_compl
by pespin 29 Mar '22

29 Mar '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27593 ) Change subject: CBSP_Types: Fix typo num_bcats_compl -> num_bcast_compl ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic51b3071ea9233a053cb1ee837b910d9250010d2 Gerrit-Change-Number: 27593 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:36:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: CBSP: implement MESSAGE STATUS QUERY
by pespin 29 Mar '22

29 Mar '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27592 ) Change subject: CBSP: implement MESSAGE STATUS QUERY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3b738dc29d0ead4f735abeeb6960d3675cb05ae2 Gerrit-Change-Number: 27592 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:36:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: libosmocore.pc.in: put libsctp in Requires.private
by pespin 29 Mar '22

29 Mar '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27597 ) Change subject: libosmocore.pc.in: put libsctp in Requires.private ...................................................................... libosmocore.pc.in: put libsctp in Requires.private The libsctp use in libosmocore is internal, not exposed to applications. Hence, it must not be in "Requires" but in "Requires.private". Fixes: 12eed19066a11aece6f346b54b85326bc6ba7f0b Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 --- M libosmocore.pc.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/libosmocore.pc.in b/libosmocore.pc.in index 3bb9b9a..6296417 100644 --- a/libosmocore.pc.in +++ b/libosmocore.pc.in @@ -6,7 +6,8 @@ Name: Osmocom Core Library Description: C Utility Library Version: @VERSION@ -Requires: talloc, libsctp +Requires: talloc +Requires.private: libsctp Libs: -L${libdir} -losmocore Libs.private: @PTHREAD_LIBS@ Cflags: -I${includedir}/ @PTHREAD_CFLAGS@ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 Gerrit-Change-Number: 27597 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmocore[master]: libosmocore.pc.in: put libsctp in Requires.private
by pespin 29 Mar '22

29 Mar '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27597 ) Change subject: libosmocore.pc.in: put libsctp in Requires.private ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 Gerrit-Change-Number: 27597 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:05:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log