- gerrit-log - lists.osmocom.org

Change in osmo-mgw[master]: mgcp_network: fix typo RTPC -> RTCP
by pespin 31 Mar '22

31 Mar '22

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27607 ) Change subject: mgcp_network: fix typo RTPC -> RTCP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3274441a1bf6f4f015f01017ef03451b7f79310a Gerrit-Change-Number: 27607 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:23:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: mgcp_network: do not try to convert RTCP packets
by pespin 31 Mar '22

31 Mar '22

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27606 ) Change subject: mgcp_network: do not try to convert RTCP packets ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/27606/comment/71248817_37cc5b67 PS1, Line 1514: rc = rx_rtp(msg, proto); proto is already available in mc (which is contained in msg). No need to pass it as param. https://gerrit.osmocom.org/c/osmo-mgw/+/27606/comment/57f82291_2a7a4a86 PS1, Line 1537: if (proto == MGCP_PROTO_RTP && amr_oa_bwe_convert_indicated(conn_src->end.codec)) { mc = OSMO_RTP_MSG_CTX(msg); mc->proto == GCP_PROTO_RTP -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b Gerrit-Change-Number: 27606 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:23:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: tcpdump capture script: check permissions to fix running in a netns
by Hoernchen 31 Mar '22

31 Mar '22

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 ) Change subject: tcpdump capture script: check permissions to fix running in a netns ...................................................................... Patch Set 1: (1 comment) File ttcn3-tcpdump-start.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604/comment/8a88f280_b878… PS1, Line 48: getpcaps doesntmatter 2>&1 | grep -e cap_net_admin | grep -q -e cap_net_raw > Where does this "getpcaps" come from? I'm not really understanding this patch tbh. from the same libcap2-bin package as the setcap command in the line above. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d Gerrit-Change-Number: 27604 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:21:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: mgcp_network: log RTP/RTCP reception failures
by dexter 31 Mar '22

31 Mar '22

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27608 ) Change subject: mgcp_network: log RTP/RTCP reception failures ...................................................................... mgcp_network: log RTP/RTCP reception failures When the reception of an RTP or RTCP packet fails on the very last step, no error is logged. Change-Id: Ic0e60fe2fb9d96b8ae18bb862b5715359a10e849 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/08/27608/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index c66a168..6f3b5b8 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1512,6 +1512,10 @@ forward_data_tap(fd->fd, &conn_src->tap_in, msg); rc = rx_rtp(msg, proto); + if (rc < 0) { + LOG_CONN_RTP(conn_src, LOGL_ERROR, "rx %s packet failed\n", + proto == MGCP_PROTO_RTP ? "RTP" : "RTCP"); + } out: msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic0e60fe2fb9d96b8ae18bb862b5715359a10e849 Gerrit-Change-Number: 27608 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-mgw[master]: mgcp_network: do not try to convert RTCP packets
by dexter 31 Mar '22

31 Mar '22

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27606 ) Change subject: mgcp_network: do not try to convert RTCP packets ...................................................................... mgcp_network: do not try to convert RTCP packets Make sure that RTCP packets do not enter the code path where AMR OA and BWE is converted. The conversion will fail and the RTCP packet will be dropped. Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b Related: SYS#5902 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/06/27606/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 0ea8c25..ba4d5ee 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -75,7 +75,7 @@ rtpconn_rate_ctr_add(conn_rtp, endp, id, 1); } -static int rx_rtp(struct msgb *msg); +static int rx_rtp(struct msgb *msg, enum rtp_proto proto); static bool addr_is_any(const struct osmo_sockaddr *osa) { @@ -1511,14 +1511,14 @@ /* Forward a copy of the RTP data to a debug ip/port */ forward_data_tap(fd->fd, &conn_src->tap_in, msg); - rc = rx_rtp(msg); + rc = rx_rtp(msg, proto); out: msgb_free(msg); return rc; } -static int rx_rtp(struct msgb *msg) +static int rx_rtp(struct msgb *msg, enum rtp_proto proto) { struct osmo_rtp_msg_ctx *mc = OSMO_RTP_MSG_CTX(msg); struct mgcp_conn_rtp *conn_src = mc->conn_src; @@ -1534,7 +1534,7 @@ * framing mode (octet-aligned vs. bandwith-efficient is explicitly * define, then we check if the incoming payload matches that * expectation. */ - if (amr_oa_bwe_convert_indicated(conn_src->end.codec)) { + if (proto == MGCP_PROTO_RTP && amr_oa_bwe_convert_indicated(conn_src->end.codec)) { int oa = amr_oa_check((char*)msgb_data(msg), msgb_length(msg)); if (oa < 0) return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b Gerrit-Change-Number: 27606 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-mgw[master]: mgcp_network: fix typo RTPC -> RTCP
by dexter 31 Mar '22

31 Mar '22

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27607 ) Change subject: mgcp_network: fix typo RTPC -> RTCP ...................................................................... mgcp_network: fix typo RTPC -> RTCP Change-Id: I3274441a1bf6f4f015f01017ef03451b7f79310a --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/07/27607/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index ba4d5ee..c66a168 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1471,7 +1471,7 @@ msgb_put(msg, ret); LOG_CONN_RTP(conn_src, LOGL_DEBUG, "%s: rx %u bytes from %s:%u\n", - proto == MGCP_PROTO_RTP ? "RTP" : "RTPC", + proto == MGCP_PROTO_RTP ? "RTP" : "RTCP", msgb_length(msg), osmo_sockaddr_ntop(&addr.u.sa, ipbuf), osmo_sockaddr_port(&addr.u.sa)); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3274441a1bf6f4f015f01017ef03451b7f79310a Gerrit-Change-Number: 27607 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_num
by pespin 31 Mar '22

31 Mar '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27605 ) Change subject: BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_num ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I169c482ea5de040df63db4c605ac9cae19f8d28f Gerrit-Change-Number: 27605 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:13:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: tcpdump capture script: check permissions to fix running in a netns
by pespin 31 Mar '22

31 Mar '22

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 ) Change subject: tcpdump capture script: check permissions to fix running in a netns ...................................................................... Patch Set 1: (1 comment) File ttcn3-tcpdump-start.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604/comment/f974b6e9_4f75… PS1, Line 48: getpcaps doesntmatter 2>&1 | grep -e cap_net_admin | grep -q -e cap_net_raw Where does this "getpcaps" come from? I'm not really understanding this patch tbh. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d Gerrit-Change-Number: 27604 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:12:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: msc tests: fix test so they don't depend on previous test runs
by pespin 31 Mar '22

31 Mar '22

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603 ) Change subject: msc tests: fix test so they don't depend on previous test runs ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can you describe better the issue you are fixing here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebaecd28a426b15baf4729f40b46dd33da79cbae Gerrit-Change-Number: 27603 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:08:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: Add ss7 instances to osmo_ss7_instances in creation order
by pespin 31 Mar '22

31 Mar '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 ) Change subject: Add ss7 instances to osmo_ss7_instances in creation order ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > should not cause downstream test fallout. […] All tests on all projects run fine here after applying the patch -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Id4d0a20cc5b0811b505b2d1051d496f8bd17d54c Gerrit-Change-Number: 27599 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:07:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log