- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: jenkins: Validate gsm 08.58 IEs are added to tlv_definition
by pespin 05 Apr '22

05 Apr '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27646 ) Change subject: jenkins: Validate gsm 08.58 IEs are added to tlv_definition ...................................................................... Patch Set 3: (2 comments) File include/osmocom/gsm/protocol/gsm_08_58.h: https://gerrit.osmocom.org/c/libosmocore/+/27646/comment/3b749c45_48dbde71 PS3, Line 388: RSL_IE_IPAC_RTP_PAYLOAD2 = 0xfc, > Why changing spacing in this patch? It is needed to have same syntax in all enums, with a separation between name and equal. Making them more regular makes easy to parse the code. File src/gsm/rsl.c: https://gerrit.osmocom.org/c/libosmocore/+/27646/comment/58aa171f_35fc812a PS3, Line 128: [RSL_IE_IPAC_SRTP_CONFIG] = { TLV_TYPE_TLV }, > This looks unrelated, please submit a separate change. It's not unrelated, precisely having this line makes the new contrib/jenkins.sh pass, since the new checks detects they are lacking. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id8a679ca43eb0fcc4882780e9a95ec21c7f51972 Gerrit-Change-Number: 27646 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 10:26:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: rsl: Fix tlv_parse of IPAC_DLCX_IND message
by pespin 05 Apr '22

05 Apr '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27644 ) Change subject: rsl: Fix tlv_parse of IPAC_DLCX_IND message ...................................................................... Patch Set 1: (1 comment) File tests/abis/abis_test.c: https://gerrit.osmocom.org/c/libosmocore/+/27644/comment/6eecb9b0_0bfb6ee8 PS1, Line 251: sys5915 > I don't think it's a good idea to use/mention Sysmocom's internal ticket numbers in the code, becaus […] It is still fine to add a suffix to it in case we want to test decoding same message type using different content. I could have added a "potato" suffix to identify the test, but using a ticket number is more useful, even if some people cannot access it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib637197ef3508ec94aec05d08d4e6aa15ddea055 Gerrit-Change-Number: 27644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 10:24:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_dl_llc_sapi_priority
by pespin 05 Apr '22

05 Apr '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27633 ) Change subject: pcu: Introduce test TC_dl_llc_sapi_priority ...................................................................... pcu: Introduce test TC_dl_llc_sapi_priority Related: OS#5508 Related: SYS#5908 Change-Id: I26308a59718a6470853c964583a39986006e59c0 --- M pcu/PCU_Tests.ttcn 1 file changed, 99 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 0a67486..8012daa 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -3022,6 +3022,104 @@ f_shutdown(__BFILE__, __LINE__, final := true); } +/* OS#5508: Verify scheduling of LLC frames with SAPI=1 (GMM) takes precedence + * over SAPI2/7/8 which in turn take prececende over others */ +testcase TC_dl_llc_sapi_priority() runs on RAW_PCU_Test_CT { + var octetstring data_sapi1 := f_pad_oct('01'O, 19, 'ff'O); + var octetstring data_sapi2 := f_pad_oct('02'O, 19, 'ff'O); + var octetstring data_sapi7 := f_pad_oct('07'O, 19, 'ff'O); + var octetstring data_sapi8 := f_pad_oct('08'O, 19, 'ff'O); + var octetstring data_sapi_other := f_pad_oct('03'O, 19, 'ff'O); + var RlcmacDlBlock dl_block; + var uint32_t dl_fn; + var GprsMS ms; + var integer state := 1; + + /* Initialize NS/BSSGP side */ + f_init_bssgp(); + /* Initialize GPRS MS side */ + f_init_gprs_ms(); + ms := g_ms[0]; /* We only use first MS in this test */ + + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename(), ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS)); + + /* Lock to CS1 to keep same DL RLCMAC data block size: */ + g_cs_initial_dl := 1; + g_mcs_max_dl := 1; + f_pcuvty_set_allowed_cs_mcs(); + + /* Establish BSSGP connection to the PCU */ + f_bssgp_establish(); + f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); + + /* SGSN sends some low prio DL data, PCU will page on CCCH (PCH) */ + for (var integer i := 0; i < 10; i := i + 1) { + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data_sapi_other)); + } + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data_sapi2)); + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data_sapi7)); + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data_sapi8)); + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data_sapi1)); + f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + + /* Wait timer X2002 and DL block is available after CCCH IMM ASS */ + f_sleep(X2002); + + while (state != 0) { + var OCT1 rx_sapi; + f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, ?, ?); + rx_sapi := dl_block.data.blocks[0].payload[0]; + + select (state) { + case(1) { /* We expect the first GMM LLC frame here (SAPI=1, highest prio) */ + if (rx_sapi != '01'O) { + setverdict(fail, "Wrong prio: Expected LLC SAPI 1 (GMM) but got ", rx_sapi); + f_shutdown(__BFILE__, __LINE__); + } + state := 2; + } + case(2) { /* We expect the second LLC frame here (SAPI=2, middle prio) */ + if (rx_sapi != '02'O) { + setverdict(fail, "Wrong prio: Expected LLC SAPI 2 but got ", rx_sapi); + f_shutdown(__BFILE__, __LINE__); + } + state := 7; + } + case(7) { /* We expect the third LLC frame here (SAPI=7, middle prio) */ + if (rx_sapi != '07'O) { + setverdict(fail, "Wrong prio: Expected LLC SAPI 7 but got ", rx_sapi); + f_shutdown(__BFILE__, __LINE__); + } + state := 8; + } + case(8) { /* We expect the fourth LLC frame here (SAPI=8, middle prio) */ + if (rx_sapi != '08'O) { + setverdict(fail, "Wrong prio: Expected LLC SAPI 8 but got ", rx_sapi); + f_shutdown(__BFILE__, __LINE__); + } + state := 3; + } + case(3) { /* We expect the other LLC frame here (SAPI=3, lower prio) */ + if (rx_sapi != '03'O) { + setverdict(fail, "Wrong prio: Expected LLC SAPI 3 but got ", rx_sapi); + f_shutdown(__BFILE__, __LINE__); + } + state := 0; /* Done, break */ + } + } + /* Keep Ack/Nack description updated (except for last BSN) */ + f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block); + + if (f_dl_block_rrbp_valid(dl_block)) { + f_ms_tx_ul_block(ms, ts_RLCMAC_DL_ACK_NACK(ms.dl_tbf.tfi, ms.dl_tbf.acknack_desc), + f_dl_block_ack_fn(dl_block, dl_fn)); + } + } + + f_shutdown(__BFILE__, __LINE__, final := true); +} + /* Verify allocation and use of multislot tbf, triggered by MS class provided in SGSN. SYS#5131 */ testcase TC_dl_multislot_tbf_ms_class_from_sgsn() runs on RAW_PCU_Test_CT { var PCUIF_info_ind info_ind := valueof(ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS)); @@ -6724,6 +6822,7 @@ execute( TC_dl_flow_more_blocks() ); execute( TC_ul_flow_multiple_llc_blocks() ); execute( TC_dl_no_ack_retrans_imm_ass() ); + execute( TC_dl_llc_sapi_priority() ); execute( TC_paging_cs_from_bts() ); execute( TC_paging_cs_from_sgsn_sign_ptmsi() ); execute( TC_paging_cs_from_sgsn_sign() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26308a59718a6470853c964583a39986006e59c0 Gerrit-Change-Number: 27633 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDec: Fix bug decoding LI[0]=0
by pespin 05 Apr '22

05 Apr '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27632 ) Change subject: RLCMAC_EncDec: Fix bug decoding LI[0]=0 ...................................................................... RLCMAC_EncDec: Fix bug decoding LI[0]=0 Change-Id: I86c1b48c922f50013257c8dce405cbad1d77d868 --- M library/RLCMAC_EncDec.cc 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc index 97bd0be..1b56984 100644 --- a/library/RLCMAC_EncDec.cc +++ b/library/RLCMAC_EncDec.cc @@ -513,8 +513,17 @@ if (ret_val.blocks().is_bound()) { for (int i = 0; i < ret_val.blocks().size_of(); i++) { unsigned int length = ret_val.blocks()[i].hdr()().length__ind(); + + /* LI[0]=0 indicates: The current LLC PDU would fit within + current RLC data block but the addition of the length + indicator octet (to indicate the LLC PDU boundary) causes the + LLC PDU to extend into another RLC data block */ + if (i == 0 && length == 0) + length = ttcn_buffer.get_read_len(); + if (length > ttcn_buffer.get_read_len()) length = ttcn_buffer.get_read_len(); + ret_val.blocks()[i].payload() = OCTETSTRING(length, ttcn_buffer.get_read_data()); ttcn_buffer.increase_pos(length); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86c1b48c922f50013257c8dce405cbad1d77d868 Gerrit-Change-Number: 27632 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_dl_llc_sapi_priority
by pespin 05 Apr '22

05 Apr '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27633 ) Change subject: pcu: Introduce test TC_dl_llc_sapi_priority ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26308a59718a6470853c964583a39986006e59c0 Gerrit-Change-Number: 27633 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 10:22:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDec: Fix bug decoding LI[0]=0
by pespin 05 Apr '22

05 Apr '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27632 ) Change subject: RLCMAC_EncDec: Fix bug decoding LI[0]=0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86c1b48c922f50013257c8dce405cbad1d77d868 Gerrit-Change-Number: 27632 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 10:22:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...osmo_dia2gsup[master]: docs: add a simple example to use configuration file
by pespin 05 Apr '22

05 Apr '22

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647 ) Change subject: docs: add a simple example to use configuration file ...................................................................... Patch Set 1: (1 comment) File README.md: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647/comment/cb2b191b_… PS1, Line 33: $ rebar3 shell --config ./examples/sys.config Isn'tn this the same as above but with config? why not merging both sections? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I013f03779508bc3ee5bb378c357a5c94b40b74a0 Gerrit-Change-Number: 27647 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 05 Apr 2022 10:20:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: tests/llc: Add test_llc_meta_pdu_life_expire
by lynxis lazus 05 Apr '22

05 Apr '22

Attention is currently required from: osmith, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27642 ) Change subject: tests/llc: Add test_llc_meta_pdu_life_expire ...................................................................... Patch Set 1: (1 comment) File tests/llc/LlcTest.ok: https://gerrit.osmocom.org/c/osmo-pcu/+/27642/comment/c7a603e2_33c6b388 PS1, Line 6: === end test_llc_meta_pdu_life_expire === > Not related to this patch, but I wonder why the test output is split across stdout + stderr instead […] IMHO: usually stdout should be always the same if the test succeed. while stderr can contains more detailed logs. but the detailed logs might contain dynamic parts (e.g. pointer). so they can't be used as part of the test output and should not be the same. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7ba6be32778e2c2b22723db10fa66655812c8452 Gerrit-Change-Number: 27642 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 09:56:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: llc: schedule frames to MS based on SAPI priority
by lynxis lazus 05 Apr '22

05 Apr '22

Attention is currently required from: pespin, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27627 ) Change subject: llc: schedule frames to MS based on SAPI priority ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie8bd91eeac4fa7487d4f11b808dea95737041c7e Gerrit-Change-Number: 27627 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 09:47:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: gprs_ms_storage: MS always has non NULL ms->bts
by lynxis lazus 05 Apr '22

05 Apr '22

Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27636 ) Change subject: gprs_ms_storage: MS always has non NULL ms->bts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27636 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie9ed9341a82b5edaee09da9156e95a616088f950 Gerrit-Change-Number: 27636 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 09:45:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log