- gerrit-log - lists.osmocom.org

Change in osmo-bsc-nat[master]: bssap: name bssmap functions properly
by osmith 11 Apr '22

11 Apr '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27703 ) Change subject: bssap: name bssmap functions properly ...................................................................... bssap: name bssmap functions properly Almost all functions in bssap.c actually handle bssmap, so name them accordingly. Related: SYS#5560 Change-Id: Ib583b64187bcf3138399e7a099248ee79492bb03 --- M include/osmocom/bsc_nat/bssap.h M src/osmo-bsc-nat/bssap.c M src/osmo-bsc-nat/msc_fsm.c 3 files changed, 13 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/include/osmocom/bsc_nat/bssap.h b/include/osmocom/bsc_nat/bssap.h index ca387c2..f474909 100644 --- a/include/osmocom/bsc_nat/bssap.h +++ b/include/osmocom/bsc_nat/bssap.h @@ -24,4 +24,4 @@ int bssap_handle_udt(struct bsc_nat_sccp_inst *sccp_inst, struct osmo_sccp_addr *addr, struct msgb *msgb, unsigned int length); -int bssap_tx_reset(struct bsc_nat_sccp_inst *sccp_inst, struct osmo_sccp_addr *addr); +int bssmap_tx_reset(struct bsc_nat_sccp_inst *sccp_inst, struct osmo_sccp_addr *addr); diff --git a/src/osmo-bsc-nat/bssap.c b/src/osmo-bsc-nat/bssap.c index 67a06fb..94a450a 100644 --- a/src/osmo-bsc-nat/bssap.c +++ b/src/osmo-bsc-nat/bssap.c @@ -27,7 +27,7 @@ #include <osmocom/bsc_nat/logging.h> #include <osmocom/bsc_nat/msc.h> -int bssap_tx_reset(struct bsc_nat_sccp_inst *sccp_inst, struct osmo_sccp_addr *addr) +int bssmap_tx_reset(struct bsc_nat_sccp_inst *sccp_inst, struct osmo_sccp_addr *addr) { enum bsc_nat_net net = sccp_inst == g_bsc_nat->cn.sccp_inst ? BSC_NAT_NET_CN : BSC_NAT_NET_RAN; @@ -38,7 +38,7 @@ return osmo_sccp_tx_unitdata_msg(sccp_inst->scu, &sccp_inst->addr, addr, msg); } -static int bssap_cn_handle_reset_ack(struct osmo_sccp_addr *addr, struct msgb *msg, unsigned int length) +static int bssmap_cn_handle_reset_ack(struct osmo_sccp_addr *addr, struct msgb *msg, unsigned int length) { struct msc *msc = msc_get(); @@ -54,13 +54,13 @@ return 0; } -static int bssap_cn_rcvmsg_udt(struct osmo_sccp_addr *addr, struct msgb *msg, unsigned int length) +static int bssmap_cn_rcvmsg_udt(struct osmo_sccp_addr *addr, struct msgb *msg, unsigned int length) { int ret = 0; switch (msg->l3h[0]) { case BSS_MAP_MSG_RESET_ACKNOWLEDGE: - ret = bssap_cn_handle_reset_ack(addr, msg, length); + ret = bssmap_cn_handle_reset_ack(addr, msg, length); break; default: LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssmap_name(msg->l3h[0])); @@ -70,7 +70,7 @@ return ret; } -static int bssap_ran_handle_reset(struct osmo_sccp_addr *addr, struct msgb *msg, unsigned int length) +static int bssmap_ran_handle_reset(struct osmo_sccp_addr *addr, struct msgb *msg, unsigned int length) { struct bsc_nat_sccp_inst *sccp_inst = g_bsc_nat->ran.sccp_inst; struct bsc *bsc; @@ -87,13 +87,13 @@ return osmo_sccp_tx_unitdata_msg(sccp_inst->scu, &sccp_inst->addr, addr, msg); } -static int bssap_ran_rcvmsg_udt(struct osmo_sccp_addr *addr, struct msgb *msg, unsigned int length) +static int bssmap_ran_rcvmsg_udt(struct osmo_sccp_addr *addr, struct msgb *msg, unsigned int length) { int ret = 0; switch (msg->l3h[0]) { case BSS_MAP_MSG_RESET: - ret = bssap_ran_handle_reset(addr, msg, length); + ret = bssmap_ran_handle_reset(addr, msg, length); break; default: LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssmap_name(msg->l3h[0])); @@ -103,7 +103,7 @@ return ret; } -static int bssap_rcvmsg_udt(struct bsc_nat_sccp_inst *sccp_inst, struct osmo_sccp_addr *addr, struct msgb *msg, +static int bssmap_rcvmsg_udt(struct bsc_nat_sccp_inst *sccp_inst, struct osmo_sccp_addr *addr, struct msgb *msg, unsigned int length) { if (length < 1) { @@ -114,8 +114,8 @@ LOGP(DMAIN, LOGL_NOTICE, "Rx UDT BSSMAP %s\n", gsm0808_bssmap_name(msg->l3h[0])); if (sccp_inst == g_bsc_nat->cn.sccp_inst) - return bssap_cn_rcvmsg_udt(addr, msg, length); - return bssap_ran_rcvmsg_udt(addr, msg, length); + return bssmap_cn_rcvmsg_udt(addr, msg, length); + return bssmap_ran_rcvmsg_udt(addr, msg, length); } int bssap_handle_udt(struct bsc_nat_sccp_inst *sccp_inst, struct osmo_sccp_addr *addr, struct msgb *msgb, @@ -140,7 +140,7 @@ switch (bs->type) { case BSSAP_MSG_BSS_MANAGEMENT: msgb->l3h = &msgb->l2h[sizeof(*bs)]; - rc = bssap_rcvmsg_udt(sccp_inst, addr, msgb, length - sizeof(*bs)); + rc = bssmap_rcvmsg_udt(sccp_inst, addr, msgb, length - sizeof(*bs)); break; default: LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssap_name(bs->type)); diff --git a/src/osmo-bsc-nat/msc_fsm.c b/src/osmo-bsc-nat/msc_fsm.c index e660c57..fc8beaf 100644 --- a/src/osmo-bsc-nat/msc_fsm.c +++ b/src/osmo-bsc-nat/msc_fsm.c @@ -63,7 +63,7 @@ case MSC_FSM_EV_TX_RESET: LOGP(DMAIN, LOGL_DEBUG, "Tx RESET to %s\n", talloc_get_name(msc)); - if (bssap_tx_reset(g_bsc_nat->cn.sccp_inst, &msc->addr) < 0) { + if (bssmap_tx_reset(g_bsc_nat->cn.sccp_inst, &msc->addr) < 0) { LOGP(DMAIN, LOGL_ERROR, "Could not send RESET to MSC (SCCP not up yet?)\n"); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ib583b64187bcf3138399e7a099248ee79492bb03 Gerrit-Change-Number: 27703 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc-nat[master]: bssap: make "not implemented" log msgs consistent
by osmith 11 Apr '22

11 Apr '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27701 ) Change subject: bssap: make "not implemented" log msgs consistent ...................................................................... bssap: make "not implemented" log msgs consistent Use LOGL_ERROR and word them the same way as the not implemented message in sccp_sap_up_cn and sccp_sap_up_ran. Related: SYS#5560 Change-Id: Ice8d67a30064a91d68256f43dcfb052d237e5594 --- M src/osmo-bsc-nat/bssap.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-bsc-nat/bssap.c b/src/osmo-bsc-nat/bssap.c index f88bb20..a7f629e 100644 --- a/src/osmo-bsc-nat/bssap.c +++ b/src/osmo-bsc-nat/bssap.c @@ -63,7 +63,7 @@ ret = bssap_cn_handle_reset_ack(addr, msg, length); break; default: - LOGP(DMAIN, LOGL_NOTICE, "Unimplemented BSSMAP UDT %s\n", gsm0808_bssap_name(msg->l3h[0])); + LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssap_name(msg->l3h[0])); break; } @@ -96,7 +96,7 @@ ret = bssap_ran_handle_reset(addr, msg, length); break; default: - LOGP(DMAIN, LOGL_NOTICE, "Unimplemented BSSMAP UDT %s\n", gsm0808_bssap_name(msg->l3h[0])); + LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssap_name(msg->l3h[0])); break; } @@ -143,7 +143,7 @@ rc = bssap_rcvmsg_udt(sccp_inst, addr, msgb, length - sizeof(*bs)); break; default: - LOGP(DMAIN, LOGL_NOTICE, "Unimplemented msg type: %s\n", gsm0808_bssap_name(bs->type)); + LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssap_name(bs->type)); } return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ice8d67a30064a91d68256f43dcfb052d237e5594 Gerrit-Change-Number: 27701 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc-nat[master]: bssap: fix printing bssmap names
by osmith 11 Apr '22

11 Apr '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27702 ) Change subject: bssap: fix printing bssmap names ...................................................................... bssap: fix printing bssmap names Use the proper function to print BSSMAP names, so it doesn't say "unknown 0x52" etc. Related: SYS#5560 Change-Id: I353a9d13b14de6d0ba9aabe8cb3057dd7a98cb51 --- M src/osmo-bsc-nat/bssap.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-bsc-nat/bssap.c b/src/osmo-bsc-nat/bssap.c index a7f629e..67a06fb 100644 --- a/src/osmo-bsc-nat/bssap.c +++ b/src/osmo-bsc-nat/bssap.c @@ -63,7 +63,7 @@ ret = bssap_cn_handle_reset_ack(addr, msg, length); break; default: - LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssap_name(msg->l3h[0])); + LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssmap_name(msg->l3h[0])); break; } @@ -96,7 +96,7 @@ ret = bssap_ran_handle_reset(addr, msg, length); break; default: - LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssap_name(msg->l3h[0])); + LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssmap_name(msg->l3h[0])); break; } @@ -111,7 +111,7 @@ return -1; } - LOGP(DMAIN, LOGL_NOTICE, "Rx UDT BSSMAP %s\n", gsm0808_bssap_name(msg->l3h[0])); + LOGP(DMAIN, LOGL_NOTICE, "Rx UDT BSSMAP %s\n", gsm0808_bssmap_name(msg->l3h[0])); if (sccp_inst == g_bsc_nat->cn.sccp_inst) return bssap_cn_rcvmsg_udt(addr, msg, length); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I353a9d13b14de6d0ba9aabe8cb3057dd7a98cb51 Gerrit-Change-Number: 27702 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc-nat[master]: bssap: forward paging from MSC to all BSCs
by osmith 11 Apr '22

11 Apr '22

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27704 ) Change subject: bssap: forward paging from MSC to all BSCs ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: > I think it is ok to merge this kind of approach now, but for later we definitely want to be smarter […] Thanks, copied your reply into this issue: https://osmocom.org/issues/5522 PS1: 1+1+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I2532d94aab82d136b932d57fa53c8ecf2d8d1fd9 Gerrit-Change-Number: 27704 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 11 Apr 2022 08:20:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: tune waiting timeout in TC_rsl_ms_pwr_dyn_up
by osmith 11 Apr '22

11 Apr '22

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27697 ) Change subject: BTS_Tests: tune waiting timeout in TC_rsl_ms_pwr_dyn_up ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9266f7284fcdb0afa3473f575640689e334e89a8 Gerrit-Change-Number: 27697 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 08:04:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmo-bts-trx: bts_report_interf_meas(): remove unused fn param
by fixeria 11 Apr '22

11 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27727 ) Change subject: osmo-bts-trx: bts_report_interf_meas(): remove unused fn param ...................................................................... osmo-bts-trx: bts_report_interf_meas(): remove unused fn param Change-Id: Iec25b28e418ce1f66bbc7e0696a3ceebb02e9c82 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/27/27727/1 diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index d772620..382ddae 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -118,8 +118,7 @@ gsm_lchan_interf_meas_push((struct gsm_lchan *) lchan, interf_avg); } -static void bts_report_interf_meas(const struct gsm_bts *bts, - const uint32_t fn) +static void bts_report_interf_meas(const struct gsm_bts *bts) { const struct gsm_bts_trx *trx; unsigned int tn, ln; @@ -270,7 +269,7 @@ /* Report interference measurements */ if (fn % 104 == 0) /* SACCH period */ - bts_report_interf_meas(bts, fn); + bts_report_interf_meas(bts); /* send time indication */ l1if_mph_time_ind(bts, fn); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iec25b28e418ce1f66bbc7e0696a3ceebb02e9c82 Gerrit-Change-Number: 27727 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bts[master]: l1sap: l1sap_chan_act(): alloc DTX FSM only for TCH
by fixeria 11 Apr '22

11 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27725 ) Change subject: l1sap: l1sap_chan_act(): alloc DTX FSM only for TCH ...................................................................... l1sap: l1sap_chan_act(): alloc DTX FSM only for TCH Change-Id: Ieb5728b7a9e7d7c58449deaa5a6c4d8755b6e213 --- M src/common/l1sap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/27725/1 diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 502bcef..6ef5e3b 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1947,7 +1947,7 @@ return -RSL_ERR_EQUIPMENT_FAIL; /* Init DTX DL FSM if necessary */ - if (trx->bts->dtxd && lchan->type != GSM_LCHAN_SDCCH) { + if (trx->bts->dtxd && lchan_is_tch(lchan)) { lchan->tch.dtx.dl_amr_fsm = osmo_fsm_inst_alloc(&dtx_dl_amr_fsm, tall_bts_ctx, lchan, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ieb5728b7a9e7d7c58449deaa5a6c4d8755b6e213 Gerrit-Change-Number: 27725 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bts[master]: l1sap: l1sap_chan_act(): remove unused *tp argument
by fixeria 11 Apr '22

11 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27726 ) Change subject: l1sap: l1sap_chan_act(): remove unused *tp argument ...................................................................... l1sap: l1sap_chan_act(): remove unused *tp argument Change-Id: I2030f05b55fc9370e71ff12b26ffe1142f4acfc8 --- M include/osmo-bts/l1sap.h M src/common/l1sap.c M src/common/pcu_sock.c M src/common/rsl.c M tests/handover/handover_test.c 5 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/26/27726/1 diff --git a/include/osmo-bts/l1sap.h b/include/osmo-bts/l1sap.h index 93c532f..e28a53b 100644 --- a/include/osmo-bts/l1sap.h +++ b/include/osmo-bts/l1sap.h @@ -96,7 +96,7 @@ uint32_t timestamp, bool marker); /* channel control */ -int l1sap_chan_act(struct gsm_bts_trx *trx, uint8_t chan_nr, struct tlv_parsed *tp); +int l1sap_chan_act(struct gsm_bts_trx *trx, uint8_t chan_nr); int l1sap_chan_rel(struct gsm_bts_trx *trx, uint8_t chan_nr); int l1sap_chan_deact_sacch(struct gsm_bts_trx *trx, uint8_t chan_nr); int l1sap_chan_modify(struct gsm_bts_trx *trx, uint8_t chan_nr); diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 6ef5e3b..e9bab61 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1927,7 +1927,7 @@ return l1sap_down(trx, &l1sap); } -int l1sap_chan_act(struct gsm_bts_trx *trx, uint8_t chan_nr, struct tlv_parsed *tp) +int l1sap_chan_act(struct gsm_bts_trx *trx, uint8_t chan_nr) { struct gsm_lchan *lchan = get_lchan_by_chan_nr(trx, chan_nr); int rc; diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 94b45f3..9d0d87c 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -884,7 +884,7 @@ return -EINVAL; } if (act_req->activate) - l1sap_chan_act(trx, gsm_lchan2chan_nr(lchan), NULL); + l1sap_chan_act(trx, gsm_lchan2chan_nr(lchan)); else l1sap_chan_rel(trx, gsm_lchan2chan_nr(lchan)); diff --git a/src/common/rsl.c b/src/common/rsl.c index 5112ee5..9469894 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1941,7 +1941,7 @@ lchan->top_acch_active = false; /* actually activate the channel in the BTS */ - rc = l1sap_chan_act(lchan->ts->trx, dch->chan_nr, &tp); + rc = l1sap_chan_act(lchan->ts->trx, dch->chan_nr); if (rc < 0) return rsl_tx_chan_act_acknack(lchan, -rc); diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index 9c9b020..231be98 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -102,12 +102,12 @@ /* create two lchans for handover */ lchan = &trx->ts[1].lchan[0]; lchan->type = GSM_LCHAN_SDCCH; - l1sap_chan_act(lchan->ts->trx, 0x09, NULL); + l1sap_chan_act(lchan->ts->trx, 0x09); lchan = &trx->ts[2].lchan[0]; lchan->type = GSM_LCHAN_TCH_F; lchan->ho.active = HANDOVER_ENABLED; lchan->ho.ref = 23; - l1sap_chan_act(lchan->ts->trx, 0x0a, NULL); + l1sap_chan_act(lchan->ts->trx, 0x0a); OSMO_ASSERT(msgb_dequeue(&trx->rsl_link->tx_list)); OSMO_ASSERT(msgb_dequeue(&trx->rsl_link->tx_list)); OSMO_ASSERT(!msgb_dequeue(&trx->rsl_link->tx_list)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2030f05b55fc9370e71ff12b26ffe1142f4acfc8 Gerrit-Change-Number: 27726 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-e1d[master]: vty: Print only applicable information during 'show line'
by tnt 11 Apr '22

11 Apr '22

Attention is currently required from: manawyrm, laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27719 ) Change subject: vty: Print only applicable information during 'show line' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I7b55ae8a5e1d352f90e14342d7f7e82e4848118a Gerrit-Change-Number: 27719 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 10 Apr 2022 18:18:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmo-bts-virtual: remove unused 'codec_mode_request' argument
by fixeria 11 Apr '22

11 Apr '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27724 ) Change subject: osmo-bts-virtual: remove unused 'codec_mode_request' argument ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I would expect once the #if0 blocks are properly implemented we need to know the AMR phase (CMC/CMR) […] This block is related to the hack, that was introduced in the early days to detect and compensate lost Uplink speech blocks in the Downlink burst handler. This makes no sense in the context of osmo-bts-virtual, so I suggest to remove it completely. Note that this block is also present in the osmo-bts-trx specific copy of tx_tch_common(), and there it's uncommented: https://gitea.osmocom.org/cellular-infrastructure/osmo-bts/src/branch/maste…. I proposed to remove it back in 2020: https://gerrit.osmocom.org/c/osmo-bts/+/20674, because with a) per-lchan burst loss detection and b) NOPE.ind it makes no sense to keep it anymore. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If5001d7b19820478d0e88fea3126e5dd4fbd2634 Gerrit-Change-Number: 27724 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 10 Apr 2022 17:46:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log