Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423 )
Change subject: ggsn: Initial testing of open5gs Gy interface
......................................................................
Patch Set 3:
(1 comment)
File library/DIAMETER_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423/comment/ecb14e48_d443…
PS3, Line 1226: /* FIXME: change this to use "Validity-Time" instead of "CC-Time" */
> Is the unresolved fixme here kept on purpose?
This is actually fixed, thanks for noticing.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I10027d4f8adc6b47ce97b90514d1f13e9aa3d40d
Gerrit-Change-Number: 27423
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Apr 2022 11:09:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27732 )
Change subject: pgw: Wait for component to get out of SUT's Diameter SUSPECt list
......................................................................
pgw: Wait for component to get out of SUT's Diameter SUSPECt list
Similar fix was applied to GGSN_Tests when adding Diameter support in
commit 0bcfd9de8ff359673ddb71e013dbad44bf9510cc.
Change-Id: I95ddf6c1048f0bfd6590bae574aea15c4fc2710b
---
M pgw/PGW_Tests.ttcn
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/27732/1
diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn
index 9846dab..2b74418 100644
--- a/pgw/PGW_Tests.ttcn
+++ b/pgw/PGW_Tests.ttcn
@@ -146,6 +146,12 @@
vc_DIAMETER.start(DIAMETER_Emulation.main(ops, pars, id));
f_diameter_wait_capability(DIAMETER_UNIT);
+ /* Give some time for our emulation to get out of SUSPECT list of SUT (3 watchdong ping-pongs):
+ * RFC6733 sec 5.1
+ * RFC3539 sec 3.4.1 [5]
+ * https://github.com/freeDiameter/freeDiameter/blob/master/libfdcore/p_psm.c#…
+ */
+ f_sleep(1.0);
}
private function f_init(float guard_timeout := 60.0) runs on PGW_Test_CT {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27732
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I95ddf6c1048f0bfd6590bae574aea15c4fc2710b
Gerrit-Change-Number: 27732
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: laforge, pespin, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423 )
Change subject: ggsn: Initial testing of open5gs Gy interface
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File ggsn_tests/GGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423/comment/f63efc20_1b0f…
PS3, Line 2229: /* Sent some data and validate it is reported in the TERMINATION_REQUEST (triggered by PFCP Session Deletion Response): */
very long line
File library/DIAMETER_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423/comment/e968996f_7fc2…
PS3, Line 1226: /* FIXME: change this to use "Validity-Time" instead of "CC-Time" */
Is the unresolved fixme here kept on purpose?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I10027d4f8adc6b47ce97b90514d1f13e9aa3d40d
Gerrit-Change-Number: 27423
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Apr 2022 10:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711 )
Change subject: Make subscr_conn_get_next_id RAN specific
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I77b0ef33f94c401d24f38eb8d79e1007234e0ab4
Gerrit-Change-Number: 27711
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Apr 2022 10:42:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27730 )
Change subject: DIAMETER_Emulation: Fix typo in comment
......................................................................
DIAMETER_Emulation: Fix typo in comment
Change-Id: I6163fc9153082598c7211b16a7c18fb95cf3d08a
---
M library/DIAMETER_Emulation.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/27730/1
diff --git a/library/DIAMETER_Emulation.ttcn b/library/DIAMETER_Emulation.ttcn
index e53f4e5..0f1b9fe 100644
--- a/library/DIAMETER_Emulation.ttcn
+++ b/library/DIAMETER_Emulation.ttcn
@@ -399,7 +399,7 @@
inout DIAMETEREM_register;
} with { extension "internal" };
-/* Function that can be used as create_cb and will usse the expect table */
+/* Function that can be used as create_cb and will use the expect table */
function ExpectedCreateCallback(PDU_DIAMETER msg, hexstring imsi, charstring id)
runs on DIAMETER_Emulation_CT return DIAMETER_ConnHdlr {
var DIAMETER_ConnHdlr ret := null;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27730
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6163fc9153082598c7211b16a7c18fb95cf3d08a
Gerrit-Change-Number: 27730
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange