- gerrit-log - lists.osmocom.org

Change in osmo-e1d[master]: Use the error counters for remote alarm + remote CRC error
by laforge 04 Jan '22

04 Jan '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26709 ) Change subject: Use the error counters for remote alarm + remote CRC error ...................................................................... Use the error counters for remote alarm + remote CRC error Some time ago we added various error counters, but for two of them we missed to actually ever increment them at all. Change-Id: Ieb83a2e2e83e334c543bee83726f04f83b19227a --- M src/mux_demux.c 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/mux_demux.c b/src/mux_demux.c index b0a9cf2..a588829 100644 --- a/src/mux_demux.c +++ b/src/mux_demux.c @@ -359,8 +359,10 @@ /* A bit is present in each odd frame */ if (frame_nr % 2) { - if (frame[0] & 0x20) + if (frame[0] & 0x20) { line->ts0.cur_errmask |= E1L_TS0_RX_ALARM; + line_ctr_add(line, LINE_CTR_RX_REMOTE_A, 1); + } } /* E bits are present in frame 13 + 15 */ @@ -368,8 +370,10 @@ line->ts0.e_bits = frame[0] & 0x80 ? 2 : 0; if (frame_nr == 15) { line->ts0.e_bits |= frame[0] & 0x80 ? 1 : 0; - if (line->ts0.e_bits != 3) + if (line->ts0.e_bits != 3) { line->ts0.cur_errmask |= E1L_TS0_RX_CRC4_ERR; + line_ctr_add(line, LINE_CTR_RX_REMOTE_E, 1); + } } /* cur_errmask is being cleared once per second via line->ts0.timer */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ieb83a2e2e83e334c543bee83726f04f83b19227a Gerrit-Change-Number: 26709 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

Change in osmo-e1d[master]: Add support for icE1usb RAI interrupt error flag
by laforge 04 Jan '22

04 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26710 ) Change subject: Add support for icE1usb RAI interrupt error flag ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ie1994968e792c37f9272b9854547db95a41cab5b Gerrit-Change-Number: 26710 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:30:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: Use the error counters for remote alarm + remote CRC error
by laforge 04 Jan '22

04 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26709 ) Change subject: Use the error counters for remote alarm + remote CRC error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ieb83a2e2e83e334c543bee83726f04f83b19227a Gerrit-Change-Number: 26709 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:30:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-sip-connector[master]: Add TODO-RELEASE
by laforge 04 Jan '22

04 Jan '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/26714 ) Change subject: Add TODO-RELEASE ...................................................................... Add TODO-RELEASE Change-Id: I32acbec597ff8bb79b3576f9d13ab051d5c5b938 --- A TODO-RELEASE 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE new file mode 100644 index 0000000..7ac9302 --- /dev/null +++ b/TODO-RELEASE @@ -0,0 +1,9 @@ +# When cleaning up this file: bump API version in corresponding Makefile.am and rename corresponding debian/lib*.install +# according to https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info… +# In short: +# LIBVERSION=c:r:a +# If the library source code has changed at all since the last update, then increment revision: c:r + 1:a. +# If any interfaces have been added, removed, or changed since the last update: c + 1:0:0. +# If any interfaces have been added since the last public release: c:r:a + 1. +# If any interfaces have been removed or changed since the last public release: c:r:0. +#library what description / commit summary line -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/26714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I32acbec597ff8bb79b3576f9d13ab051d5c5b938 Gerrit-Change-Number: 26714 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-sip-connector[master]: Add TODO-RELEASE
by laforge 04 Jan '22

04 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/26714 ) Change subject: Add TODO-RELEASE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/26714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I32acbec597ff8bb79b3576f9d13ab051d5c5b938 Gerrit-Change-Number: 26714 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:30:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: mgw: Introduce test TC_two_crcx_mdcx_and_iuup
by laforge 04 Jan '22

04 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26720 ) Change subject: mgw: Introduce test TC_two_crcx_mdcx_and_iuup ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0866fb499c6d426386d9811d075a7fe8386c5cb1 Gerrit-Change-Number: 26720 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:29:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: RTP_Emulation: Several fixes and improvements for IuUP streams
by laforge 04 Jan '22

04 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26719 ) Change subject: RTP_Emulation: Several fixes and improvements for IuUP streams ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4f8b02a8123bb30b659c40148c8ab4c7c2078a1 Gerrit-Change-Number: 26719 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:28:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: RTP IuUP Emulation: Avoid spamming with retransmitted Init
by laforge 04 Jan '22

04 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26685 ) Change subject: RTP IuUP Emulation: Avoid spamming with retransmitted Init ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8e299a3fe49f9d31cae182f7ed4dc0ea3fc22ba2 Gerrit-Change-Number: 26685 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:28:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: iuup: Submit RNL-STATUS-Initialization.ind upon rx of Init
by laforge 04 Jan '22

04 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26721 ) Change subject: iuup: Submit RNL-STATUS-Initialization.ind upon rx of Init ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I63ee780b4aa162ea097410b234e73984000c0965 Gerrit-Change-Number: 26721 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:27:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: logging: Fix Not enough tailroom msgb_put in _output_buf callers
by laforge 04 Jan '22

04 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26726 ) Change subject: logging: Fix Not enough tailroom msgb_put in _output_buf callers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8d71bd1a0dad37606acb8302b05c2ae338112e57 Gerrit-Change-Number: 26726 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:26:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log