- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: tests/bsc/Makefile.am: remove duplicate CFLAGS
by pespin 21 Apr '22

21 Apr '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27877 ) Change subject: tests/bsc/Makefile.am: remove duplicate CFLAGS ...................................................................... tests/bsc/Makefile.am: remove duplicate CFLAGS Change-Id: I7af974a9920558af03495b6ca297b158caebc007 --- M tests/bsc/Makefile.am 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/77/27877/1 diff --git a/tests/bsc/Makefile.am b/tests/bsc/Makefile.am index 8fcda3a..5056c18 100644 --- a/tests/bsc/Makefile.am +++ b/tests/bsc/Makefile.am @@ -13,7 +13,6 @@ $(LIBOSMOLEGACYMGCP_CFLAGS) \ $(LIBOSMOSIGTRAN_CFLAGS) \ $(LIBOSMOMGCPCLIENT_CFLAGS) \ - $(LIBOSMOSIGTRAN_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7af974a9920558af03495b6ca297b158caebc007 Gerrit-Change-Number: 27877 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: paging: Use define available in libosmogsm
by pespin 21 Apr '22

21 Apr '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27878 ) Change subject: paging: Use define available in libosmogsm ...................................................................... paging: Use define available in libosmogsm Change-Id: I6425a9cb1100391404d79ead66dfb1337bbcbcab --- M src/osmo-bsc/paging.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/27878/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 512f39c..73c1175 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -288,8 +288,7 @@ log_set_context(LOG_CTX_BSC_SUBSCR, NULL); } -#define GSM_FRAME_DURATION_us 4615 -#define GSM51_MFRAME_DURATION_us (51 * GSM_FRAME_DURATION_us) /* 235365 us */ +#define GSM51_MFRAME_DURATION_us (51 * GSM_TDMA_FN_DURATION_uS) /* 235365 us */ static unsigned int calculate_timer_3113(struct gsm_bts *bts) { unsigned int to_us, to; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27878 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6425a9cb1100391404d79ead66dfb1337bbcbcab Gerrit-Change-Number: 27878 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: firmware/tiffs/readfile: fix -Wbuiltin-declaration-mismatch
by fixeria 21 Apr '22

21 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27875 ) Change subject: firmware/tiffs/readfile: fix -Wbuiltin-declaration-mismatch ...................................................................... firmware/tiffs/readfile: fix -Wbuiltin-declaration-mismatch Change-Id: Id8ec64054f24fe43cfec66d2d331e18b780b3951 --- M src/target/firmware/tiffs/readfile.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/75/27875/1 diff --git a/src/target/firmware/tiffs/readfile.c b/src/target/firmware/tiffs/readfile.c index c93b106..3c330d0 100644 --- a/src/target/firmware/tiffs/readfile.c +++ b/src/target/firmware/tiffs/readfile.c @@ -26,7 +26,7 @@ #include <tiffs.h> #include "globals.h" -extern char *index(); +extern char *index(const char *, int); #define MAX_FN_COMPONENT 20 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8ec64054f24fe43cfec66d2d331e18b780b3951 Gerrit-Change-Number: 27875 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: firmware/battery: fix -Wunused-variable in battery_compal_e88_timer_cb()
by fixeria 21 Apr '22

21 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27876 ) Change subject: firmware/battery: fix -Wunused-variable in battery_compal_e88_timer_cb() ...................................................................... firmware/battery: fix -Wunused-variable in battery_compal_e88_timer_cb() Change-Id: I3e9bbc21aec57dea84034d233a2ba1902602bdb2 --- M src/target/firmware/battery/compal_e88.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/76/27876/1 diff --git a/src/target/firmware/battery/compal_e88.c b/src/target/firmware/battery/compal_e88.c index 42f77f2..788d8ab 100644 --- a/src/target/firmware/battery/compal_e88.c +++ b/src/target/firmware/battery/compal_e88.c @@ -352,7 +352,6 @@ static void battery_compal_e88_timer_cb(void *p){ struct osmo_timer_list *tmr = (struct osmo_timer_list*)p; - int i; if(bat_compal_e88_adc_read()){ /* read back ADCs after a brief delay */ osmo_timer_schedule(tmr,ADC_TIMER_DELAY); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3e9bbc21aec57dea84034d233a2ba1902602bdb2 Gerrit-Change-Number: 27876 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: firmware/apps/rssi: remove redundant block in handle_pm()
by fixeria 21 Apr '22

21 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27872 ) Change subject: firmware/apps/rssi: remove redundant block in handle_pm() ...................................................................... firmware/apps/rssi: remove redundant block in handle_pm() Below in the common path for both true and false branches we do have a conditional block setting ARFCN_UPLINK if uplink is true. Change-Id: If3adc5d1f11d3f43cb4c17bdb355b160ab61dc56 --- M src/target/firmware/apps/rssi/main.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/72/27872/1 diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 94ecc3b..29c5430 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -916,8 +916,6 @@ a = arfcn; if (pcs && arfcn >= PCS_MIN && arfcn <= PCS_MAX) a |= ARFCN_PCS; - if (uplink) - a |= ARFCN_UPLINK; e = a; pm_mode = PM_SENT; } else { /* mode == MODE_SPECTRUM */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If3adc5d1f11d3f43cb4c17bdb355b160ab61dc56 Gerrit-Change-Number: 27872 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: firmware/apps/hello_world: remove unused test[] buffer
by fixeria 21 Apr '22

21 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27874 ) Change subject: firmware/apps/hello_world: remove unused test[] buffer ...................................................................... firmware/apps/hello_world: remove unused test[] buffer Change-Id: I20d41111d6f611202dcefada8091ccda0cc51dad --- M src/target/firmware/apps/hello_world/main.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/74/27874/1 diff --git a/src/target/firmware/apps/hello_world/main.c b/src/target/firmware/apps/hello_world/main.c index aeb5739..ecacc18 100644 --- a/src/target/firmware/apps/hello_world/main.c +++ b/src/target/firmware/apps/hello_world/main.c @@ -165,8 +165,6 @@ void key_handler(enum key_codes code, enum key_states state) { - char test[16]; - if (state != PRESSED) return; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I20d41111d6f611202dcefada8091ccda0cc51dad Gerrit-Change-Number: 27874 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: firmware/apps/layer1: remove unused 'atrLength' in main()
by fixeria 21 Apr '22

21 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27873 ) Change subject: firmware/apps/layer1: remove unused 'atrLength' in main() ...................................................................... firmware/apps/layer1: remove unused 'atrLength' in main() Change-Id: I4bb1dae28c07218e8b801bc162b82d03fd083bad --- M src/target/firmware/apps/layer1/main.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/73/27873/1 diff --git a/src/target/firmware/apps/layer1/main.c b/src/target/firmware/apps/layer1/main.c index 701d95f..8135468 100644 --- a/src/target/firmware/apps/layer1/main.c +++ b/src/target/firmware/apps/layer1/main.c @@ -57,7 +57,6 @@ int main(void) { uint8_t atr[20]; - uint8_t atrLength = 0; board_init(1); @@ -101,7 +100,7 @@ puts("Power up simcard:\n"); memset(atr,0,sizeof(atr)); - atrLength = calypso_sim_powerup(atr); + calypso_sim_powerup(atr); read_factory_rf_calibration(); layer1_init(); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4bb1dae28c07218e8b801bc162b82d03fd083bad Gerrit-Change-Number: 27873 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: firmware/layer1: fix 'MFNONE' not handled in switch [-Wswitch]
by fixeria 21 Apr '22

21 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27869 ) Change subject: firmware/layer1: fix 'MFNONE' not handled in switch [-Wswitch] ...................................................................... firmware/layer1: fix 'MFNONE' not handled in switch [-Wswitch] Change-Id: I4c38599b29de73e26e9b603564f63b88e65e16b9 --- M src/target/firmware/layer1/l23_api.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/69/27869/1 diff --git a/src/target/firmware/layer1/l23_api.c b/src/target/firmware/layer1/l23_api.c index afcf9f5..2bd57d2 100644 --- a/src/target/firmware/layer1/l23_api.c +++ b/src/target/firmware/layer1/l23_api.c @@ -133,6 +133,9 @@ case MF26ODD: TASK_SET(MF_TASK_NEIGH_PM26O); break; + default: + /* no neighbor measurement */ + break; } break; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27869 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4c38599b29de73e26e9b603564f63b88e65e16b9 Gerrit-Change-Number: 27869 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: firmware/layer1: fix unused variable 'l1h' [-Wunused-variable]
by fixeria 21 Apr '22

21 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27870 ) Change subject: firmware/layer1: fix unused variable 'l1h' [-Wunused-variable] ...................................................................... firmware/layer1: fix unused variable 'l1h' [-Wunused-variable] Change-Id: If8c3da3908c1dab7a93e69daee13426f9bdbccad --- M src/target/firmware/layer1/l23_api.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/70/27870/1 diff --git a/src/target/firmware/layer1/l23_api.c b/src/target/firmware/layer1/l23_api.c index 2bd57d2..11d4195 100644 --- a/src/target/firmware/layer1/l23_api.c +++ b/src/target/firmware/layer1/l23_api.c @@ -344,10 +344,8 @@ } /* receive a L1CTL_DM_REL_REQ from L23 */ -static void l1ctl_rx_dm_rel_req(struct msgb *msg) +static void l1ctl_rx_dm_rel_req(void) { - struct l1ctl_hdr *l1h = (struct l1ctl_hdr *) msg->data; - printd("L1CTL_DM_REL_REQ\n"); l1a_mftask_set(0); l1s.dedicated.type = GSM_DCHAN_NONE; @@ -672,7 +670,7 @@ l1ctl_rx_dm_est_req(msg); break; case L1CTL_DM_REL_REQ: - l1ctl_rx_dm_rel_req(msg); + l1ctl_rx_dm_rel_req(); break; case L1CTL_PARAM_REQ: l1ctl_rx_param_req(msg); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If8c3da3908c1dab7a93e69daee13426f9bdbccad Gerrit-Change-Number: 27870 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm()
by fixeria 21 Apr '22

21 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27871 ) Change subject: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm() ...................................................................... firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm() In this function we have the following condition: if (pm_mode == PM_IDLE && (mode == MODE_MAIN || mode == MODE_SPECTRUM)) so the 'mode' can be either MODE_MAIN or MODE_SPECTRUM. Still, GCC throws false-positive warnings that 'a' and 'e' may be used uninitialized in handle_pm(). Let's eliminate these warnings by using 'if-else' statement. Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890 --- M src/target/firmware/apps/rssi/main.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/71/27871/1 diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 9a3f87c..94ecc3b 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -920,8 +920,7 @@ a |= ARFCN_UPLINK; e = a; pm_mode = PM_SENT; - } - if (mode == MODE_SPECTRUM) { + } else { /* mode == MODE_SPECTRUM */ if (pcs && arfcn >= PCS_MIN && arfcn <= PCS_MAX) { a = PCS_MIN | ARFCN_PCS; e = PCS_MAX | ARFCN_PCS; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890 Gerrit-Change-Number: 27871 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log