- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: paging: Prioritize requests for new subscribers over retransmitions
by pespin 26 Apr '22

26 Apr '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27897 ) Change subject: paging: Prioritize requests for new subscribers over retransmitions ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1ae6d97152c458247bc538233b97c2d245196359 Gerrit-Change-Number: 27897 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 14:12:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: paging: Submit up to 20 paging requests in a single work iteration
by pespin 26 Apr '22

26 Apr '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27885 ) Change subject: paging: Submit up to 20 paging requests in a single work iteration ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I609fa67834b426456f48f6fb2acb601c5905f178 Gerrit-Change-Number: 27885 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 14:12:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: firmware/layer1: fix unused variable 'l1h' [-Wunused-variable]
by pespin 26 Apr '22

26 Apr '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27870 ) Change subject: firmware/layer1: fix unused variable 'l1h' [-Wunused-variable] ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If8c3da3908c1dab7a93e69daee13426f9bdbccad Gerrit-Change-Number: 27870 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 14:12:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: Check RSPRO component type; print error if type doesn't match
by laforge 26 Apr '22

26 Apr '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/27929 ) Change subject: Check RSPRO component type; print error if type doesn't match ...................................................................... Check RSPRO component type; print error if type doesn't match If one component connects to another component, verify that the remote component type (bank/server/client) matches our expectation. This is important in order to detect a misconfiguration of port numbers, for example. Closes: OS#5548 Change-Id: I89a4fc4331e8a0622f8f146c7fc235d34d990497 --- M src/bankd/bankd_main.c M src/client/remsim_client.c 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/29/27929/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index fcdbf76..40c1f08 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -174,6 +174,13 @@ switch (pdu->msg.present) { case RsproPDUchoice_PR_connectBankRes: + if (pdu->msg.choice.connectBankRes.identity.type != ComponentType_remsimServer) { + LOGPFSML(srvc->fi, LOGL_ERROR, "Server connection to a ComponentType(%u) != RemsimServer? " + "Check your IP/Port configuration\n", + pdu->msg.choice.connectBankRes.identity.type); + osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_DISCONNECT, NULL); + return -1; + } /* Store 'identity' of server in srvc->peer_comp_id */ rspro_comp_id_retrieve(&srvc->peer_comp_id, &pdu->msg.choice.connectBankRes.identity); osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_CLIENT_CONN_RES, (void *) pdu); diff --git a/src/client/remsim_client.c b/src/client/remsim_client.c index 8da82ef..19e8f0a 100644 --- a/src/client/remsim_client.c +++ b/src/client/remsim_client.c @@ -67,6 +67,13 @@ switch (pdu->msg.present) { case RsproPDUchoice_PR_connectClientRes: + if (pdu->msg.choice.connectClientRes.identity.type != ComponentType_remsimBankd) { + LOGPFSML(bankdc->fi, LOGL_ERROR, "Server connection to a ComponentType(%u) != RemsimBankd? " + "Check your IP/Port configuration\n", + pdu->msg.choice.connectClientRes.identity.type); + osmo_fsm_inst_dispatch(bankdc->fi, SRVC_E_DISCONNECT, NULL); + return -1; + } /* Store 'identity' of bankd to in peer_comp_id */ rspro_comp_id_retrieve(&bankdc->peer_comp_id, &pdu->msg.choice.connectClientRes.identity); osmo_fsm_inst_dispatch(bankdc->fi, SRVC_E_CLIENT_CONN_RES, (void *) pdu); @@ -94,6 +101,13 @@ switch (pdu->msg.present) { case RsproPDUchoice_PR_connectClientRes: + if (pdu->msg.choice.connectClientRes.identity.type != ComponentType_remsimServer) { + LOGPFSML(srvc->fi, LOGL_ERROR, "Server connection to a ComponentType(%u) != RemsimServer? " + "Check your IP/Port configuration\n", + pdu->msg.choice.connectClientRes.identity.type); + osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_DISCONNECT, NULL); + return -1; + } /* Store 'identity' of server in srvc->peer_comp_id */ rspro_comp_id_retrieve(&srvc->peer_comp_id, &pdu->msg.choice.connectClientRes.identity); osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_CLIENT_CONN_RES, (void *) pdu); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/27929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I89a4fc4331e8a0622f8f146c7fc235d34d990497 Gerrit-Change-Number: 27929 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: osmobts: list all features of latest osmobts
by osmith 25 Apr '22

25 Apr '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: osmobts: list all features of latest osmobts ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/bts_osmobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/51824e9e_efd6a2f1 PS1, Line 213: osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_ABIS_OSMO_PCU); > Yes. […] *freq hopping -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 13:49:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: osmobts: list all features of latest osmobts
by osmith 25 Apr '22

25 Apr '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: osmobts: list all features of latest osmobts ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/bts_osmobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/75426a0e_324d9a09 PS1, Line 213: osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_ABIS_OSMO_PCU); > So in here you are actually putting up to date the expected set of features an up-to-date osmo-bts s […] Yes. The idea was that we put here everything that OsmoBTS may support the most, and then can use this to verify the VTY commands before the OsmoBTS reported the available features. See channel hopping for example (now in this patch). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 13:48:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: abis_nm: don't compare assumed/reported features
by osmith 25 Apr '22

25 Apr '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27919 ) Change subject: abis_nm: don't compare assumed/reported features ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27919/comment/d5559cdc_82524105 PS1, Line 603: if (i >= _NUM_BTS_FEAT) { > I'd rather put this check before the osmo_bts_has_feature() one, because otherwise you'll probably n […] Done in https://gerrit.osmocom.org/c/osmo-bsc/+/27928/1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd79bc7ef802d8e95e05d746df182ff974b78e29 Gerrit-Change-Number: 27919 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 13:47:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Always use reported features if available
by osmith 25 Apr '22

25 Apr '22

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27921 ) Change subject: Always use reported features if available ...................................................................... Patch Set 1: (2 comments) File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27921/comment/2186f4b5_ab576150 PS1, Line 693: !osmo_bts_has_feature(&bts->features, BTS_FEAT_GPRS)) { > note: model->features field can probably be turned const in the struct definition? This would need some refactoring, currently the various bts models make use of osmo_bts_set_feature(&model.features to set the model's features on initialization. File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27921/comment/9f822830_16cb1905 PS1, Line 346: return CMD_WARNING; > Have you tested that starting osmo-bsc with 'model osmo-bts' and hopping parameters is still possibl […] Right, only the later patch https://gerrit.osmocom.org/c/osmo-bsc/+/27923/1 will make the features available in the bts model (so they are used before the bts reports its features). I've moved the change with "return CMD_WARNING" to that patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf2d933aa8b03b1f708e56a08707fe6c620a97aa Gerrit-Change-Number: 27921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 13:46:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: abis_nm: tweak unknown feature check
by osmith 25 Apr '22

25 Apr '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27928 ) Change subject: abis_nm: tweak unknown feature check ...................................................................... abis_nm: tweak unknown feature check Print the log message about an unknown feature regardless if the feature is enabled or not. Related: SYS#5922, OS#5538 Change-Id: Iabe016b6dca54492bf177ac84fda4357b5be404d --- M src/osmo-bsc/abis_nm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/28/27928/1 diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 1c21bc2..3a3b254 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -598,7 +598,7 @@ /* Check each BTS feature in the reported vector */ for (i = 0; i < len * 8; i++) { bool Frep = osmo_bts_has_feature(&bts->features, i); - if (i >= _NUM_BTS_FEAT && Frep) { + if (i >= _NUM_BTS_FEAT) { LOGPMO(&bts->mo, DNM, LOGL_NOTICE, "Get Attributes Response: " "unknown feature 0x%02x. Consider upgrading osmo-bsc.\n", i); continue; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iabe016b6dca54492bf177ac84fda4357b5be404d Gerrit-Change-Number: 27928 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: abis_nm: don't compare assumed/reported features
by osmith 25 Apr '22

25 Apr '22

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27919 to look at the new patch set (#2). Change subject: abis_nm: don't compare assumed/reported features ...................................................................... abis_nm: don't compare assumed/reported features Just log all reported features, instead of comparing them against an expected set of features and logging mismatches. The point of reporting features from the BTS at runtime is that the BSC can support various BTS versions with various feature sets. Related: SYS#5922, OS#5538 Change-Id: Ibd79bc7ef802d8e95e05d746df182ff974b78e29 --- M src/osmo-bsc/abis_nm.c 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/27919/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd79bc7ef802d8e95e05d746df182ff974b78e29 Gerrit-Change-Number: 27919 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log