pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27943 )
Change subject: paging: Check C0 RSL link instead of OML link
......................................................................
paging: Check C0 RSL link instead of OML link
PAging happens over C0 RSL link, not over OML, so let's actually
validate that the C0 RSL link is up before paging instead of the OML
one.
Change-Id: I11e5bb6f952534763935aa01470e514d4af247ed
---
M src/osmo-bsc/paging.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c
index 74a550d..3da5f18 100644
--- a/src/osmo-bsc/paging.c
+++ b/src/osmo-bsc/paging.c
@@ -196,7 +196,7 @@
}
/* Skip paging if the bts is down. */
- if (!bts->oml_link)
+ if (!bts->c0->rsl_link_primary)
goto sched_next_iter;
/* do while loop: Try send at most first MAX_PAGE_REQ_PER_ITER paging
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27943
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I11e5bb6f952534763935aa01470e514d4af247ed
Gerrit-Change-Number: 27943
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27935 )
Change subject: paging: Estimate available_slots based on BTS config when no CCCH Load Ind received
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27935/comment/e0e1b35c_586925ae
PS3, Line 2344: sd.bts->ccch_load_ind_period
> can you put the explanation as comment in the code?
Done here: https://gerrit.osmocom.org/c/osmo-bsc/+/27985
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27935
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2df68e10eb549d62765ad3b25429f7fe2d5bb0b9
Gerrit-Change-Number: 27935
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Apr 2022 15:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, laforge, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 )
Change subject: Check VTY config against features reported by BTS
......................................................................
Patch Set 7:
(2 comments)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/67eb271c_82a1bcae
PS6, Line 502: if (!bts_gprs_mode_is_compat(bts, bts->gprs.mode)) {
> && instead of nested if?
Done on purpose here, so we have a if (bts->features_known) { ... } block where we can have multiple checks in the future. If it's strongly preferred to use && here however, I'd change it.
File src/osmo-bsc/bts_osmobts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/5740a709_cffda913
PS6, Line 208: /* Adjust bts_init/bts_model_init in OsmoBTS to report new features.
> i wonder what this comment attempts to say, sounds like legacy that we can drop?
I just added this comment recently. What I meant with it is: when OsmoBTS supports a new feature, OsmoBTS code should be adjusted to report this feature. Instead of just adding the feature here to the BTS model, as it had been done sometimes in the past.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa
Gerrit-Change-Number: 27923
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Apr 2022 13:39:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, laforge, fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 )
Change subject: Check VTY config against features reported by BTS
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/33f56416_35dee4ad
PS6, Line 502: if (!bts_gprs_mode_is_compat(bts, bts->gprs.mode)) {
&& instead of nested if?
File src/osmo-bsc/bts_osmobts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/ab7009b7_0617aac9
PS6, Line 208: /* Adjust bts_init/bts_model_init in OsmoBTS to report new features.
i wonder what this comment attempts to say, sounds like legacy that we can drop?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa
Gerrit-Change-Number: 27923
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Apr 2022 13:34:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment