- gerrit-log - lists.osmocom.org

Change in osmo-remsim[master]: encode actual hostname in RSPRO
by pespin 04 May '22

04 May '22

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28020 ) Change subject: encode actual hostname in RSPRO ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I14925f16ae242dae89fa853a2fe31c5c1b32981d Gerrit-Change-Number: 28020 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 May 2022 16:07:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: remsim: server: TC_connect_{client,bankd}_duplicate
by pespin 04 May '22

04 May '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28025 ) Change subject: remsim: server: TC_connect_{client,bankd}_duplicate ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29023f6b5ba430338c77bf01508c81bd6d8c99fa Gerrit-Change-Number: 28025 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 May 2022 16:04:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: encode actual hostname in RSPRO
by laforge 04 May '22

04 May '22

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/28020 to look at the new patch set (#3). Change subject: encode actual hostname in RSPRO ...................................................................... encode actual hostname in RSPRO The RSPRO ComponentIdentity includes a 'name' for each remsim component. So far we always used "fixme-name" instead of something meaningful. Let's use the hostname of the system instead. Change-Id: I14925f16ae242dae89fa853a2fe31c5c1b32981d --- M src/bankd/bankd_main.c M src/client/user_ifdhandler.c M src/server/remsim_server.c 3 files changed, 16 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/20/28020/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I14925f16ae242dae89fa853a2fe31c5c1b32981d Gerrit-Change-Number: 28020 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-abis[master]: stats: add site_id scope to ipa-rsl tcp stat names
by laforge 04 May '22

04 May '22

Attention is currently required from: iedemam. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28024 ) Change subject: stats: add site_id scope to ipa-rsl tcp stat names ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b44319fb4bc6a812800001c58dfe1a664645b43 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Tue, 03 May 2022 15:54:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: server: Fix segfault in error path (client component ID != client)
by laforge 04 May '22

04 May '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28026 ) Change subject: server: Fix segfault in error path (client component ID != client) ...................................................................... server: Fix segfault in error path (client component ID != client) When we terminate the FSM instance, we must immediately return. Change-Id: I8dff45daa6584ed111a8469e7b3bf90e7c939612 --- M src/server/rspro_server.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/26/28026/1 diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index c003202..c4d4d79 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -138,6 +138,7 @@ if (conn->comp_id.type != ComponentType_remsimClient) { LOGPFSML(fi, LOGL_ERROR, "ConnectClientReq from identity != Client ?!?\n"); osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); + return; } /* reparent us from srv->connections to srv->clients */ @@ -180,6 +181,7 @@ if (conn->comp_id.type != ComponentType_remsimBankd) { LOGPFSML(fi, LOGL_ERROR, "ConnectBankReq from identity != Bank ?!?\n"); osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); + return; } /* FIXME: check for unique-ness */ conn->bank.bank_id = cbreq->bankId; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8dff45daa6584ed111a8469e7b3bf90e7c939612 Gerrit-Change-Number: 28026 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-remsim[master]: server: Fix various error paths if startup fails
by laforge 04 May '22

04 May '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28028 ) Change subject: server: Fix various error paths if startup fails ...................................................................... server: Fix various error paths if startup fails Don't segfault or use heap after free if osmo-remsim-server cannot fully initialize, e.g. due to ports already in use. Change-Id: I558e6a0ea089a779f916aa5576341d1c55da1271 --- M src/server/remsim_server.c M src/server/rest_api.c M src/server/rspro_server.c 3 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/28/28028/1 diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index a2c1a8c..9c46aa1 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -139,7 +139,6 @@ close(g_event_ofd.fd); out_rps: talloc_free(g_rps->slotmaps); - talloc_free(g_rps); out_rspro: rspro_server_destroy(g_rps); diff --git a/src/server/rest_api.c b/src/server/rest_api.c index 540fbd4..d3279c4 100644 --- a/src/server/rest_api.c +++ b/src/server/rest_api.c @@ -512,6 +512,7 @@ if (ulfius_start_framework(&g_instance) != U_OK) { LOGP(DREST, LOGL_FATAL, "Cannot start REST API on port %u\n", port); + ulfius_clean_instance(&g_instance); return -1; } return 0; diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index b753993..4ff4714 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -854,6 +854,11 @@ pthread_rwlock_unlock(&srv->rwlock); srv->link = ipa_server_link_create(ctx, NULL, host, port, accept_cb, srv); + if (!srv->link) { + talloc_free(srv); + return NULL; + } + ipa_server_link_open(srv->link); return srv; @@ -865,5 +870,6 @@ ipa_server_link_destroy(srv->link); srv->link = NULL; + pthread_rwlock_destroy(&srv->rwlock); talloc_free(srv); } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I558e6a0ea089a779f916aa5576341d1c55da1271 Gerrit-Change-Number: 28028 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-remsim[master]: server: Detect duplicate client/bankd connection; drop new ones
by laforge 04 May '22

04 May '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28027 ) Change subject: server: Detect duplicate client/bankd connection; drop new ones ...................................................................... server: Detect duplicate client/bankd connection; drop new ones we're dropping the current (new) connection as we don't really know which is the "right" one. Dropping the new gives the old connection time to timeout, or to continue to operate. If we were to drop the old connection, this could interrupt a perfectly working connection and opens some kind of DoS. Related: OS#5527 Change-Id: I00387dbc19d689415470e2f08df08a47a78b81c0 --- M asn1/RSPRO.asn M include/osmocom/rspro/ResultCode.h M src/rspro/ResultCode.c M src/server/rspro_server.c 4 files changed, 61 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/27/28027/1 diff --git a/asn1/RSPRO.asn b/asn1/RSPRO.asn index d49345d..7cba1b9 100644 --- a/asn1/RSPRO.asn +++ b/asn1/RSPRO.asn @@ -87,6 +87,7 @@ illegalSlotId (3), unsupportedProtocolVersion (4), unknownSlotmap (5), + identityInUse (6), -- no card is present in given slot cardNotPresent (100), diff --git a/include/osmocom/rspro/ResultCode.h b/include/osmocom/rspro/ResultCode.h index 1342990..9a2cbd2 100644 --- a/include/osmocom/rspro/ResultCode.h +++ b/include/osmocom/rspro/ResultCode.h @@ -25,6 +25,7 @@ ResultCode_illegalSlotId = 3, ResultCode_unsupportedProtocolVersion = 4, ResultCode_unknownSlotmap = 5, + ResultCode_identityInUse = 6, ResultCode_cardNotPresent = 100, ResultCode_cardUnresponsive = 101, ResultCode_cardTransmissionError = 102 diff --git a/src/rspro/ResultCode.c b/src/rspro/ResultCode.c index f60bf0c..76ca2fa 100644 --- a/src/rspro/ResultCode.c +++ b/src/rspro/ResultCode.c @@ -89,15 +89,17 @@ { 3, 13, "illegalSlotId" }, { 4, 26, "unsupportedProtocolVersion" }, { 5, 14, "unknownSlotmap" }, + { 6, 13, "identityInUse" }, { 100, 14, "cardNotPresent" }, { 101, 16, "cardUnresponsive" }, { 102, 21, "cardTransmissionError" } /* This list is extensible */ }; static const unsigned int asn_MAP_ResultCode_enum2value_1[] = { - 6, /* cardNotPresent(100) */ - 8, /* cardTransmissionError(102) */ - 7, /* cardUnresponsive(101) */ + 7, /* cardNotPresent(100) */ + 9, /* cardTransmissionError(102) */ + 8, /* cardUnresponsive(101) */ + 6, /* identityInUse(6) */ 2, /* illegalBankId(2) */ 1, /* illegalClientId(1) */ 3, /* illegalSlotId(3) */ @@ -109,8 +111,8 @@ static const asn_INTEGER_specifics_t asn_SPC_ResultCode_specs_1 = { asn_MAP_ResultCode_value2enum_1, /* "tag" => N; sorted by tag */ asn_MAP_ResultCode_enum2value_1, /* N => "tag"; sorted by N */ - 9, /* Number of elements in the maps */ - 10, /* Extensions before this member */ + 10, /* Number of elements in the maps */ + 11, /* Extensions before this member */ 1, /* Strict enumeration */ 0, /* Native long size */ 0 diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index c4d4d79..b753993 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -76,6 +76,7 @@ CLNTC_ST_WAIT_CONF_RES, /* waiting for ConfigClientRes */ CLNTC_ST_CONNECTED_BANKD, CLNTC_ST_CONNECTED_CLIENT, + CLNTC_ST_REJECTED, }; enum remsim_server_client_event { @@ -119,6 +120,7 @@ static void clnt_st_established(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct rspro_client_conn *conn = fi->priv; + struct rspro_client_conn *previous_conn; const RsproPDU_t *pdu = data; const ConnectClientReq_t *cclreq = NULL; const ConnectBankReq_t *cbreq = NULL; @@ -141,11 +143,6 @@ return; } - /* reparent us from srv->connections to srv->clients */ - pthread_rwlock_wrlock(&conn->srv->rwlock); - llist_del(&conn->list); - llist_add_tail(&conn->list, &conn->srv->clients); - pthread_rwlock_unlock(&conn->srv->rwlock); if (!cclreq->clientSlot) { #if 0 @@ -161,7 +158,6 @@ osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); #endif } else { - /* FIXME: check for unique-ness */ rspro2client_slot(&conn->client.slot, cclreq->clientSlot); osmo_fsm_inst_update_id_f(fi, "C%u:%u", conn->client.slot.client_id, conn->client.slot.slot_nr); @@ -169,6 +165,30 @@ conn->client.slot.client_id, conn->client.slot.slot_nr); LOGPFSML(fi, LOGL_INFO, "Client connected from %s:%s\n", ip_str, port_str); + + /* check for unique-ness */ + previous_conn = client_conn_by_slot(conn->srv, &conn->client.slot); + if (previous_conn && previous_conn != conn) { + /* we're dropping the current (new) connection as we don't really know which + * is the "right" one. Dropping the new gives the old connection time to + * timeout, or to continue to operate. If we were to drop the old + * connection, this could interrupt a perfectly working connection and opens + * some kind of DoS. */ + LOGPFSML(fi, LOGL_ERROR, "New client connection from %s:%s, but we already " + "have a connection from %s:%u. Dropping new connection.\n", + ip_str, port_str, previous_conn->peer->addr, previous_conn->peer->port); + resp = rspro_gen_ConnectClientRes(&conn->srv->comp_id, ResultCode_identityInUse); + client_conn_send(conn, resp); + osmo_fsm_inst_state_chg(fi, CLNTC_ST_REJECTED, 1, 2); + return; + } + + /* reparent us from srv->connections to srv->clients */ + pthread_rwlock_wrlock(&conn->srv->rwlock); + llist_del(&conn->list); + llist_add_tail(&conn->list, &conn->srv->clients); + pthread_rwlock_unlock(&conn->srv->rwlock); + resp = rspro_gen_ConnectClientRes(&conn->srv->comp_id, ResultCode_ok); client_conn_send(conn, resp); osmo_fsm_inst_state_chg(fi, CLNTC_ST_CONNECTED_CLIENT, 0, 0); @@ -183,7 +203,6 @@ osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); return; } - /* FIXME: check for unique-ness */ conn->bank.bank_id = cbreq->bankId; conn->bank.num_slots = cbreq->numberOfSlots; osmo_fsm_inst_update_id_f(fi, "B%u", conn->bank.bank_id); @@ -196,6 +215,23 @@ "as they must be able to reach the bankd!\n", ip_str); } + /* check for unique-ness */ + previous_conn = bankd_conn_by_id(conn->srv, conn->bank.bank_id); + if (previous_conn && previous_conn != conn) { + /* we're dropping the current (new) connection as we don't really know which + * is the "right" one. Dropping the new gives the old connection time to + * timeout, or to continue to operate. If we were to drop the old + * connection, this could interrupt a perfectly working connection and opens + * some kind of DoS. */ + LOGPFSML(fi, LOGL_ERROR, "New bankd connection from %s:%s, but we already " + "have a connection from %s:%u. Dropping new connection.\n", + ip_str, port_str, previous_conn->peer->addr, previous_conn->peer->port); + resp = rspro_gen_ConnectClientRes(&conn->srv->comp_id, ResultCode_identityInUse); + client_conn_send(conn, resp); + osmo_fsm_inst_state_chg(fi, CLNTC_ST_REJECTED, 1, 2); + return; + } + /* reparent us from srv->connections to srv->banks */ pthread_rwlock_wrlock(&conn->srv->rwlock); llist_del(&conn->list); @@ -445,6 +481,10 @@ case 1: /* No ClientConnectReq received:disconnect */ return 1; /* ask core to terminate FSM */ + case 2: + /* Timeout after rejecting client */ + LOGPFSML(fi, LOGL_NOTICE, "Closing connection of rejected peer\n"); + return 1; /* ask core to terminate FSM */ default: OSMO_ASSERT(0); } @@ -471,7 +511,7 @@ .name = "ESTABLISHED", .in_event_mask = S(CLNTC_E_CLIENT_CONN) | S(CLNTC_E_BANK_CONN), .out_state_mask = S(CLNTC_ST_CONNECTED_CLIENT) | S(CLNTC_ST_WAIT_CONF_RES) | - S(CLNTC_ST_CONNECTED_BANKD), + S(CLNTC_ST_CONNECTED_BANKD) | S(CLNTC_ST_REJECTED), .action = clnt_st_established, }, [CLNTC_ST_WAIT_CONF_RES] = { @@ -493,6 +533,10 @@ .action = clnt_st_connected_bankd, .onenter = clnt_st_connected_bankd_onenter, }, + [CLNTC_ST_REJECTED] = { + .name = "REJECTED", + /* no events permitted, no action required */ + } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I00387dbc19d689415470e2f08df08a47a78b81c0 Gerrit-Change-Number: 28027 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: remsim: server: TC_connect_{client,bankd}_duplicate
by laforge 04 May '22

04 May '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28025 ) Change subject: remsim: server: TC_connect_{client,bankd}_duplicate ...................................................................... remsim: server: TC_connect_{client,bankd}_duplicate Add two new tests for the remsim-server, which simulate what happens if a client or bankd with identical ID connects twice. We expect the second connection to get rejected at RSPRO level, and to be closed. Change-Id: I29023f6b5ba430338c77bf01508c81bd6d8c99fa Ralated: OS#5527 --- M remsim/RSPRO.asn M remsim/RemsimServer_Tests.ttcn 2 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/28025/1 diff --git a/remsim/RSPRO.asn b/remsim/RSPRO.asn index faf9cec..5e2c05b 100644 --- a/remsim/RSPRO.asn +++ b/remsim/RSPRO.asn @@ -87,6 +87,7 @@ illegalSlotId (3), unsupportedProtocolVersion (4), unknownSlotmap (5), + identityInUse (6), -- no card is present in given slot cardNotPresent (100), diff --git a/remsim/RemsimServer_Tests.ttcn b/remsim/RemsimServer_Tests.ttcn index 135ce15..6d2b27d 100644 --- a/remsim/RemsimServer_Tests.ttcn +++ b/remsim/RemsimServer_Tests.ttcn @@ -133,6 +133,44 @@ setverdict(pass); } +/* duplicate connection from Same Client/Slot ID */ +testcase TC_connect_client_duplicate() runs on test_CT { + var ComponentIdentity rspro_id := valueof(ts_CompId(remsimClient, "foobar")); + var JsRoot js; + + f_init(); + f_rsres_init(); + f_rspro_init(rspro[0], mp_server_ip, mp_server_port, rspro_id, 0); + rspro[0].rspro_client_slot := valueof(ts_ClientSlot(13,1)); + + js := f_rsres_get("/api/backend/v1/clients"); + if (not match(js.clients, JsClients:{})) { + setverdict(fail, "Initial state not empty"); + mtc.stop; + } + f_rspro_connect_client(0); + js := f_rsres_get("/api/backend/v1/clients"); + if (not match(js.clients[0], tr_JsClient(CONNECTED_CLIENT, rspro[0].rspro_id))) { + setverdict(fail, "Non-matching JSON response"); + mtc.stop; + } + + /* connect a second time for same Client ID */ + f_rspro_init(rspro[1], mp_server_ip, mp_server_port, rspro_id, 1); + rspro[1].rspro_client_slot := valueof(ts_ClientSlot(13,1)); + f_rspro_connect_client(1, identityInUse); + f_rspro_exp_disconnect(1); + + /* expect the first connection still to be active */ + js := f_rsres_get("/api/backend/v1/clients"); + if (not match(js.clients[0], tr_JsClient(CONNECTED_CLIENT, rspro[0].rspro_id))) { + setverdict(fail, "Non-matching JSON response"); + mtc.stop; + } + + setverdict(pass); +} + testcase TC_connect_bank() runs on test_CT { var ComponentIdentity rspro_id := valueof(ts_CompId(remsimBankd, "foobar")); var JsRoot js; @@ -158,6 +196,50 @@ setverdict(pass); } +testcase TC_connect_bank_duplicate() runs on test_CT { + var ComponentIdentity rspro_id := valueof(ts_CompId(remsimBankd, "foobar")); + var JsRoot js; + + f_init(); + f_rsres_init(); + f_rspro_init(rspro[0], mp_server_ip, mp_server_port, rspro_id, 0); + rspro[0].rspro_bank_id := 1; + rspro[0].rspro_bank_nslots := 8; + + js := f_rsres_get("/api/backend/v1/banks"); + if (not match(js.banks, JsBanks:{})) { + setverdict(fail, "Initial state not empty"); + mtc.stop; + } + f_rspro_connect_client(0); + js := f_rsres_get("/api/backend/v1/banks"); + if (not match(js.banks[0], tr_JsBank(CONNECTED_BANKD, rspro[0].rspro_id, rspro[0].rspro_bank_id, + rspro[0].rspro_bank_nslots))) { + setverdict(fail, "Non-matching JSON response"); + mtc.stop; + } + + /* connect a second time for same Bank ID */ + f_rspro_init(rspro[1], mp_server_ip, mp_server_port, rspro_id, 1); + rspro[1].rspro_bank_id := 1; + rspro[1].rspro_bank_nslots := 23; + f_rspro_connect_client(1, identityInUse); + + /* expect only the first bank to survive */ + js := f_rsres_get("/api/backend/v1/banks"); + if (not match(js.banks[0], tr_JsBank(CONNECTED_BANKD, rspro[0].rspro_id, rspro[0].rspro_bank_id, + rspro[0].rspro_bank_nslots))) { + setverdict(fail, "Non-matching JSON response"); + mtc.stop; + } + + /* wait for T2/rejected timer to expire in server */ + f_sleep(2.0); + + setverdict(pass); +} + + function f_ensure_slotmaps(template JsSlotmaps maps) runs on http_CT { var JsRoot js; @@ -508,7 +590,9 @@ control { execute( TC_connect_and_nothing() ); execute( TC_connect_client() ); + execute( TC_connect_client_duplicate() ); execute( TC_connect_bank() ); + execute( TC_connect_bank_duplicate() ); execute( TC_slotmap_add() ); execute( TC_slotmap_add_conn_cl_b() ); execute( TC_slotmap_add_out_of_range() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29023f6b5ba430338c77bf01508c81bd6d8c99fa Gerrit-Change-Number: 28025 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in libosmo-abis[master]: stats: add site_id scope to ipa-rsl tcp stat names
by pespin 04 May '22

04 May '22

Attention is currently required from: iedemam. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28024 ) Change subject: stats: add site_id scope to ipa-rsl tcp stat names ...................................................................... Patch Set 1: (1 comment) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/28024/comment/f77aa1a0_8c62c981 PS1, Line 299: char tcp_stat_name[32]; 32 may be too small here, I'd better use 64 now. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b44319fb4bc6a812800001c58dfe1a664645b43 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Tue, 03 May 2022 14:50:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-abis[master]: stats: add site_id scope to ipa-rsl tcp stat names
by pespin 04 May '22

04 May '22

Attention is currently required from: iedemam. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28024 ) Change subject: stats: add site_id scope to ipa-rsl tcp stat names ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b44319fb4bc6a812800001c58dfe1a664645b43 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Tue, 03 May 2022 14:49:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log