- gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: ggsn: Append MS TimeZone IE to CreatePDPCtxReq
by pespin 17 May '22

17 May '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28123 to look at the new patch set (#2). Change subject: ggsn: Append MS TimeZone IE to CreatePDPCtxReq ...................................................................... ggsn: Append MS TimeZone IE to CreatePDPCtxReq TS 29.060 states that it shall be included for primary PDP context activation if the information is available, so let's add it by default. Change-Id: I8c7e491a07cadfe09403504a82d34e412673a531 --- M ggsn_tests/GGSN_Tests.ttcn M library/GTP_Templates.ttcn 2 files changed, 51 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/28123/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c7e491a07cadfe09403504a82d34e412673a531 Gerrit-Change-Number: 28123 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ttcn3-hacks[master]: ggsn: Append MS TimeZone IE to CreatePDPCtxReq
by fixeria 17 May '22

17 May '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28123 ) Change subject: ggsn: Append MS TimeZone IE to CreatePDPCtxReq ...................................................................... Patch Set 1: (3 comments) File library/GTP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28123/comment/66ebf617_ebc6… PS1, Line 143: template template (value) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28123/comment/78f559dd_4e24… PS1, Line 144: template (value) BIT2 daylightSavingTime := '00'B) := { Something is wrong with this line. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28123/comment/4ecae63c_bd7e… PS1, Line 168: template (present) BIT2 daylightSavingTime := ?) := { Something is wrong with this line. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c7e491a07cadfe09403504a82d34e412673a531 Gerrit-Change-Number: 28123 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 May 2022 14:49:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: tests: Remove sms.db{-wal,-shm} files, not just sms.db
by fixeria 17 May '22

17 May '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28124 ) Change subject: tests: Remove sms.db{-wal,-shm} files, not just sms.db ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iecd380f598edbd1635361e4c340d54d092739919 Gerrit-Change-Number: 28124 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 May 2022 14:44:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: tests: Remove sms.db{-wal,-shm} files, not just sms.db
by pespin 16 May '22

16 May '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28124 ) Change subject: tests: Remove sms.db{-wal,-shm} files, not just sms.db ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iecd380f598edbd1635361e4c340d54d092739919 Gerrit-Change-Number: 28124 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 May 2022 12:39:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: tests: Remove sms.db{-wal,-shm} files, not just sms.db
by laforge 16 May '22

16 May '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/28124 ) Change subject: tests: Remove sms.db{-wal,-shm} files, not just sms.db ...................................................................... tests: Remove sms.db{-wal,-shm} files, not just sms.db ERROR: files left in build directory after distclean: ./sms.db-shm ./tests/sms.db-shm ./tests/sms.db-wal ./sms.db-wal Change-Id: Iecd380f598edbd1635361e4c340d54d092739919 --- M tests/Makefile.am 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/24/28124/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index c765158..d25fe16 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -69,7 +69,7 @@ IU=0 osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v endif $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db + rm -f $(top_builddir)/sms.db* # Run a specific transcript test with: 'make vty-transcript-test VTY_TEST=osmo-msc.vty' VTY_TEST ?= *.vty @@ -82,7 +82,7 @@ -n OsmoMSC -p 4254 \ -r "$(top_builddir)/src/osmo-msc/osmo-msc -c $(top_srcdir)/doc/examples/osmo-msc/osmo-msc.cfg" \ $(U) $(srcdir)/$(VTY_TEST) - rm -f $(builddir)/sms.db + rm -f $(builddir)/sms.db* # don't run multiple tests concurrently so that the ports don't conflict vty-test: @@ -91,7 +91,7 @@ ctrl-python-test: $(BUILT_SOURCES) $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db + rm -f $(top_builddir)/sms.db* # To update the CTRL script from current application behavior, # pass -u to ctrl_script_runner.py by doing: @@ -106,7 +106,7 @@ smpp-test: $(srcdir)/smpp_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db + rm -f $(top_builddir)/sms.db* check-local: atconfig $(TESTSUITE) $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iecd380f598edbd1635361e4c340d54d092739919 Gerrit-Change-Number: 28124 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: ggsn: Append MS TimeZone IE to CreatePDPCtxReq
by pespin 16 May '22

16 May '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28123 ) Change subject: ggsn: Append MS TimeZone IE to CreatePDPCtxReq ...................................................................... ggsn: Append MS TimeZone IE to CreatePDPCtxReq TS 29.060 states that it shall be included for primary PDP context activation if the information is available, so let's add it by default. Change-Id: I8c7e491a07cadfe09403504a82d34e412673a531 --- M ggsn_tests/GGSN_Tests.ttcn M library/GTP_Templates.ttcn 2 files changed, 51 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/28123/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index c1ef7fb..c18e78e 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -100,7 +100,8 @@ OCT1 ratType optional, UserLocationInformation uli optional, OCT2 charging_char optional, - OCT8 imeisv optional + OCT8 imeisv optional, + MS_TimeZone ms_tz optional } type component GT_CT { @@ -359,7 +360,8 @@ } }, charging_char := '0000'O, - imeisv := f_rnd_imeisv() + imeisv := f_rnd_imeisv(), + ms_tz := f_ts_MS_TimeZone('03'O, '01'B) } /* send GTP-C for a given context and increment sequence number */ @@ -520,7 +522,7 @@ f_send_gtpc(ts_GTPC_CreatePDP(g_peer_c, g_c_seq_nr, ctx.imsi, g_restart_ctr, ctx.teid, ctx.teic, ctx.nsapi, ctx.eua, ctx.apn, g_sgsn_ip_c, g_sgsn_ip_u, ctx.msisdn, ctx.pco_req, ctx.ratType, - ctx.uli, ctx.charging_char, ctx.imeisv)); + ctx.uli, ctx.charging_char, ctx.imeisv, ctx.ms_tz)); T_default.start; d := activate(pingpong()); if (Gx_PROC.checkstate("Connected")) { @@ -2016,7 +2018,8 @@ ctx[next_req_ctx].teid, ctx[next_req_ctx].teic, ctx[next_req_ctx].nsapi, ctx[next_req_ctx].eua, ctx[next_req_ctx].apn, g_sgsn_ip_c, g_sgsn_ip_u, ctx[next_req_ctx].msisdn, ctx[next_req_ctx].pco_req, ctx[next_req_ctx].ratType, - ctx[next_req_ctx].uli, ctx[next_req_ctx].charging_char, ctx[next_req_ctx].imeisv)); + ctx[next_req_ctx].uli, ctx[next_req_ctx].charging_char, ctx[next_req_ctx].imeisv, + ctx[next_req_ctx].ms_tz)); next_req_ctx := next_req_ctx + 1; if (next_req_ctx < num_ctx) { T_next.start; @@ -2130,7 +2133,8 @@ ctx.teid, ctx.teic, ctx.nsapi, ctx.eua, ctx.apn, g_sgsn_ip_c, g_sgsn_ip_u, ctx.msisdn, ctx.pco_req, ctx.ratType, - ctx.uli, ctx.charging_char, ctx.imeisv)); + ctx.uli, ctx.charging_char, ctx.imeisv, + ctx.ms_tz)); next_req_ctx := next_req_ctx + 1; } T_next.start; diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 22d8632..14758f3 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -139,6 +139,42 @@ imeisv := imeisv } + // MS Time Zone - 7.7.52 + template MS_TimeZone ts_MS_TimeZone(template (value) OCT1 timeZone := '00'O, + template (value) BIT2 daylightSavingTime := '00'B) := { + type_gtpc := '99'O, + lengthf := 2, + timeZone := timeZone, + daylightSavingTime := daylightSavingTime, + spare1 := '000'B, + sgsnAttempsToUpdateMS := '0'B, /* propietary, use it as spare */ + spare2 := '00'B + } + function f_ts_MS_TimeZone(template (omit) OCT1 timeZone, template (omit) BIT2 daylightSavingTime) + return template (omit) MS_TimeZone { + if (istemplatekind(timeZone, "omit") and istemplatekind(daylightSavingTime, "omit")) { + return omit; + } + if (istemplatekind(timeZone, "omit")) { + return ts_MS_TimeZone(daylightSavingTime := daylightSavingTime); + } + if (istemplatekind(daylightSavingTime, "omit")) { + return ts_MS_TimeZone(timeZone); + } + return ts_MS_TimeZone(timeZone, daylightSavingTime); + } + + template MS_TimeZone tr_MS_TimeZone(template (present) OCT1 timeZone := ?, + template (present) BIT2 daylightSavingTime := ?) := { + type_gtpc := '99'O, + lengthf := 2, + timeZone := timeZone, + daylightSavingTime := daylightSavingTime, + spare1 := '000'B, + sgsnAttempsToUpdateMS := '0'B, /* propietary, use it as spare */ + spare2 := '00'B + } + /* Charging Characteristics IE TS 29.060 7.7.23 */ template ChargingCharacteristics_GTPC ts_ChargingCharacteristics(template (value) OCT2 chargingChar) := { type_gtpc := '1A'O, @@ -400,7 +436,8 @@ template (omit) OCT1 ratType := omit, template (omit) UserLocationInformation uli := omit, template (omit) OCT2 charging_char := omit, - template (omit) OCT8 imeisv := omit) := { + template (omit) OCT8 imeisv := omit, + template(omit) MS_TimeZone ms_tz := omit) := { createPDPContextRequest := { imsi := ts_Imsi(imsi), rai := omit, @@ -441,7 +478,7 @@ aPN_Restriction := omit, ratType := f_ts_RATType(ratType), userLocationInformation := uli, - mS_TimeZone := omit, + mS_TimeZone := ms_tz, imeisv := f_ts_IMEISV(imeisv), camelChargingInformationContainer := omit, additionalTraceInfo := omit, @@ -465,13 +502,14 @@ template (omit) OCT1 ratType := omit, template (omit) UserLocationInformation uli := omit, template (omit) OCT2 charging_char := omit, - template (omit) OCT8 imeisv := omit) := { + template (omit) OCT8 imeisv := omit, + template(omit) MS_TimeZone ms_tz := omit) := { peer := peer, gtpc := ts_GTP1C_PDU(createPDPContextRequest, '00000000'O, valueof(ts_CreatePdpPDU(imsi, restart_ctr, teid_data, teid_ctrl, nsapi, eua, apn, sgsn_ip_sign, sgsn_ip_data, msisdn, pco, ratType, uli, - charging_char, imeisv)), seq) + charging_char, imeisv, ms_tz)), seq) } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c7e491a07cadfe09403504a82d34e412673a531 Gerrit-Change-Number: 28123 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-msc[master]: sms_queue: merge sms_pending_add into sms_pending_from
by fixeria 16 May '22

16 May '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28119 ) Change subject: sms_queue: merge sms_pending_add into sms_pending_from ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaf37234b3caafd568dd4fe17739be9ec842c2a8d Gerrit-Change-Number: 28119 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 May 2022 12:12:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: sms_queue: refactor sms_pending add/remove code
by fixeria 16 May '22

16 May '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28118 ) Change subject: sms_queue: refactor sms_pending add/remove code ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice4c73727ef2d7e4118f0ef5fe24cae943c7528f Gerrit-Change-Number: 28118 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 May 2022 12:11:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: sms_queue: refactor sms_pending add/remove code
by fixeria 16 May '22

16 May '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28118 ) Change subject: sms_queue: refactor sms_pending add/remove code ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice4c73727ef2d7e4118f0ef5fe24cae943c7528f Gerrit-Change-Number: 28118 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 May 2022 10:53:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: coding: properly handle AFS_SID_UPDATE frames in DTX mode
by laforge 16 May '22

16 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28122 ) Change subject: coding: properly handle AFS_SID_UPDATE frames in DTX mode ...................................................................... coding: properly handle AFS_SID_UPDATE frames in DTX mode There are two similar values in enum gsm0503_amr_dtx_frames: * AFS_SID_UPDATE - precursor of SID UPDATE, * AFS_SID_UPDATE_CN - the actual SID UPDATE. The former is internally used by libosmocoding to mark the current frame as a precursor of the actual SID UPDATE frame - the later. +---+---+---+---+---+---+---+---+ | _ | _ | _ | _ | a | b | c | d | AFS_SID_UPDATE +---+---+---+---+---+---+---+---+ | a | b | c | d | _ | _ | _ | _ | AFS_SID_UPDATE_CN +---+---+---+---+---+---+---+---+ This is required because function gsm0503_tch_afs_decode_dtx() is invoked by TDMA scheduler on every 4th received burst, while the burst buffer is 8 bursts wide. Currently, whenever gsm0503_detect_afs_dtx_frame() detects an AFS_SID_UPDATE frame, we still attempt to decode it as a speech or data below in gsm0503_tch_afs_decode_dtx(). This is indeed a bug, which results in unexpected BER values: * expected BER 0/212, * actual BER 252/448. We should return immediately once we have detected an AFS_SID_UPDATE. This patch fixes unexpected BER-SUB values during DTXu silence periods. Change-Id: I813081a4c0865958eee2496fe251ae17235ac842 Related: SYS#5853 --- M src/coding/gsm0503_coding.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 6f19ed9..98439e3 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -2222,6 +2222,7 @@ tch_amr_reassemble(tch_data, conv, 39); len = 5; goto out; + case AFS_SID_UPDATE: case AFS_ONSET: len = 0; goto out; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I813081a4c0865958eee2496fe251ae17235ac842 Gerrit-Change-Number: 28122 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log