Attention is currently required from: lynxis lazus.
osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/docker-playground/+/41390?usp=email )
Change subject: osmo-stp: add support for tcap-loadsharing
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41390?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ib58f07d28a38109b4dd053479ddbdb1937eda64e
Gerrit-Change-Number: 41390
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 10 Nov 2025 08:29:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email )
Change subject: Fix lint errors: don't use star imports
......................................................................
Patch Set 2:
(1 comment)
File tests/test_construct.py:
https://gerrit.osmocom.org/c/python/pyosmocom/+/41384/comment/f87bcc9a_d4fd… :
PS2, Line 8: DnsAdapter,
> we're not using this parenthesized list with one item per line anywhere else. […]
So far we don't have a "from X import" line in pyosmocom that exceeds the 120 character limit which we use for lines, so we need to introduce a new way of writing this if we don't use star imports anymore.
The alternatives would be:
```
from osmocom.construct import Asn1DerInteger, Bytes, DnsAdapter, GreedyInteger, GreedyBytes, PlmnAdapter, \
StripHeaderAdapter, StripTrailerAdapter, Ucs2Adapter, filter_dict
```
Or:
```
from osmocom.construct import (Asn1DerInteger, Bytes, DnsAdapter, GreedyInteger, GreedyBytes, PlmnAdapter,
StripHeaderAdapter, StripTrailerAdapter, Ucs2Adapter, filter_dict)
```
Which IMHO are both less readable and less diff-friendly. The one item per line syntax is also what one gets with `ruff format` if the line exceeds the character limit, which is based on PEP 8 and the rules from "black" that are widely used (Django, pytest, [many more...](https://github.com/psf/black?tab=readme-ov-file#used-by)).
With that being said, if you think another syntax is better then I can update the patch to use that. What do you think?
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266
Gerrit-Change-Number: 41384
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 10 Nov 2025 08:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: Add TCAP based loadsharing/routing
......................................................................
Add TCAP based loadsharing/routing
TCAP based loadsharing will share the load based on the TCAP oTID and
dTID.
Because TCAP are session based, a TCAP session based tracking is implemented,
to allow following traffic to forwarded to the same ASP.
This TCAP session tracking is similar to IP connection tracking.
ASPs within an AS can use the new IPA TCAP ROUTING protocol to register
for specific TCAP ranges.
TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP),
will use the oTID of the `TCAP Begin` to loadshare and select a ASP.
Further if the TCAP session was initiated by a `loadshared` ASP, the oTID
will be added to the session tracking.
Co-authored-by: Harald Welte <laforge(a)osmocom.org>
Co-authored-by: Daniel Willmann <dwillmann(a)sysmocom.de>
Related: SYS#5423
Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
---
M examples/sccp_demo_user.c
M src/Makefile.am
M src/ipa.c
M src/m3ua.c
M src/ss7_as.c
M src/ss7_as.h
A src/ss7_as_loadshare_tcap.c
A src/ss7_as_loadshare_tcap.h
M src/ss7_as_vty.c
M src/ss7_asp.c
M src/ss7_asp.h
M src/ss7_internal.h
A src/tcap_transaction_tracking.c
A src/tcap_transaction_tracking.h
M src/xua_as_fsm.c
M stp/stp_main.c
M tests/tcap/Makefile.am
A tests/tcap/tcap_transaction_tracking_test.c
A tests/tcap/tcap_transaction_tracking_test.ok
M tests/testsuite.at
M tests/vty/osmo_stp_test.vty
21 files changed, 1,968 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/8
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add TCAP based loadsharing/routing
......................................................................
Add TCAP based loadsharing/routing
TCAP based loadsharing will share the load based on the TCAP oTID and
dTID.
Because TCAP are session based, a TCAP session based tracking is implemented,
to allow following traffic to forwarded to the same ASP.
This TCAP session tracking is similar to IP connection tracking.
ASPs within an AS can use the new IPA TCAP ROUTING protocol to register
for specific TCAP ranges.
TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP),
will use the oTID of the `TCAP Begin` to loadshare and select a ASP.
Further if the TCAP session was initiated by a `loadshared` ASP, the oTID
will be added to the session tracking.
Co-authored-by: Harald Welte <laforge(a)osmocom.org>
Co-authored-by: Daniel Willmann <dwillmann(a)sysmocom.de>
Related: SYS#5423
Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
---
M examples/sccp_demo_user.c
M src/Makefile.am
M src/ipa.c
M src/m3ua.c
M src/ss7_as.c
M src/ss7_as.h
A src/ss7_as_loadshare_tcap.c
A src/ss7_as_loadshare_tcap.h
M src/ss7_as_vty.c
M src/ss7_asp.c
M src/ss7_asp.h
M src/ss7_internal.h
A src/tcap_transaction_tracking.c
A src/tcap_transaction_tracking.h
M src/xua_as_fsm.c
M stp/stp_main.c
M tests/tcap/Makefile.am
A tests/tcap/tcap_transaction_tracking_test.c
A tests/tcap/tcap_transaction_tracking_test.ok
M tests/testsuite.at
M tests/vty/osmo_stp_test.vty
21 files changed, 1,968 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/7
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/41388?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: jobs: libosmo-sigtran: add support for TCAP loadsharing
......................................................................
jobs: libosmo-sigtran: add support for TCAP loadsharing
TCAP loadsharing requires an additional library libosmo-asn1-tcap.
./contrib/jenkins.sh is using the env TCAP={0,1} to select this feature.
Unclear if we should also put it into our default build.
Change-Id: I47c193d8f5ce695fdc6c368eee94d21c5a4b2c6e
---
M coverity/build_Osmocom.sh
M coverity/prepare_source_Osmocom.sh
M jobs/gerrit-verifications.yml
M jobs/master-builds.yml
4 files changed, 31 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/88/41388/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41388?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I47c193d8f5ce695fdc6c368eee94d21c5a4b2c6e
Gerrit-Change-Number: 41388
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ci/+/41388?usp=email )
Change subject: jobs: libosmo-sigtran: add support for TCAP loadsharing
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
@osmith@sysmocom.de hey this is untested, please take a closer look. I'm not familiar with the osmo-ci stuff anymore.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41388?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I47c193d8f5ce695fdc6c368eee94d21c5a4b2c6e
Gerrit-Change-Number: 41388
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 09 Nov 2025 11:51:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No