- gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: add pfcp msg test
by neels 07 Jun '22

07 Jun '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 to look at the new patch set (#6). Change subject: add pfcp msg test ...................................................................... add pfcp msg test Related: SYS#5599 Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d --- M configure.ac M tests/Makefile.am A tests/libosmo-pfcp/Makefile.am A tests/libosmo-pfcp/pfcp_test.c A tests/libosmo-pfcp/pfcp_test.ok M tests/testsuite.at 6 files changed, 706 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/38/27638/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d Gerrit-Change-Number: 27638 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-upf[master]: add pfcp msg test
by neels 07 Jun '22

07 Jun '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27638 ) Change subject: add pfcp msg test ...................................................................... Patch Set 5: (1 comment) File tests/libosmo-pfcp/pfcp_test.c: https://gerrit.osmocom.org/c/osmo-upf/+/27638/comment/822a6972_536e213e PS5, Line 44: #define v4_gtp { \ well, works like this. fair enough. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d Gerrit-Change-Number: 27638 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 07 Jun 2022 00:11:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: add pfcp msg test
by neels 07 Jun '22

07 Jun '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 to look at the new patch set (#5). Change subject: add pfcp msg test ...................................................................... add pfcp msg test Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d --- M configure.ac M tests/Makefile.am A tests/libosmo-pfcp/Makefile.am A tests/libosmo-pfcp/pfcp_test.c A tests/libosmo-pfcp/pfcp_test.ok M tests/testsuite.at 6 files changed, 706 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/38/27638/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d Gerrit-Change-Number: 27638 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-upf[master]: add pfcp msg test
by neels 07 Jun '22

07 Jun '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27638 ) Change subject: add pfcp msg test ...................................................................... Patch Set 4: (1 comment) File tests/libosmo-pfcp/pfcp_test.c: https://gerrit.osmocom.org/c/osmo-upf/+/27638/comment/46a051af_487b3833 PS4, Line 42: const struct osmo_sockaddr v4_gtp = { I have a problem now. You can see v4_gtp is const. (also tried with static const) At home with gcc (Debian 8.3.0-6) 8.3.0 it compiles fine. Jenkins however says: pfcp_test.c:61:10: error: initializer element is not constant .v4 = v4_gtp, ^~~~~~ Same for a couple more similar cases below. stackoverflow suggests these should be #defines instead. any better idea anyone? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d Gerrit-Change-Number: 27638 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 06 Jun 2022 23:59:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: add pfcp msg test
by neels 07 Jun '22

07 Jun '22

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 to look at the new patch set (#4). Change subject: add pfcp msg test ...................................................................... add pfcp msg test Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d --- M configure.ac M tests/Makefile.am A tests/libosmo-pfcp/Makefile.am A tests/libosmo-pfcp/pfcp_test.c A tests/libosmo-pfcp/pfcp_test.ok M tests/testsuite.at 6 files changed, 699 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/38/27638/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d Gerrit-Change-Number: 27638 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-upf[master]: add pfcp msg test
by neels 07 Jun '22

07 Jun '22

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 to look at the new patch set (#3). Change subject: add pfcp msg test ...................................................................... add pfcp msg test Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d --- M configure.ac M tests/Makefile.am A tests/libosmo-pfcp/Makefile.am A tests/libosmo-pfcp/pfcp_test.c A tests/libosmo-pfcp/pfcp_test.ok M tests/testsuite.at 6 files changed, 699 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/38/27638/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d Gerrit-Change-Number: 27638 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-upf[master]: libosmo-pfcp: implement PFCP header and msg handling
by neels 07 Jun '22

07 Jun '22

Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27631 ) Change subject: libosmo-pfcp: implement PFCP header and msg handling ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3f85ea052a6b7c064244a8093777e53a47c8c61e Gerrit-Change-Number: 27631 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 06 Jun 2022 23:45:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: pfcp/Makefile.am: add missing pfcp_ies_auto.h entry
by neels 07 Jun '22

07 Jun '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/28224 ) Change subject: pfcp/Makefile.am: add missing pfcp_ies_auto.h entry ...................................................................... pfcp/Makefile.am: add missing pfcp_ies_auto.h entry Even though it is a generated header, it must still be listed in pfcp_HEADERS. Change-Id: I6fbfe1fcd084f2d16334bb3e44d9891d9485d59f --- M include/osmocom/pfcp/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/24/28224/1 diff --git a/include/osmocom/pfcp/Makefile.am b/include/osmocom/pfcp/Makefile.am index 4bfc194..65b0102 100644 --- a/include/osmocom/pfcp/Makefile.am +++ b/include/osmocom/pfcp/Makefile.am @@ -1,5 +1,6 @@ pfcp_HEADERS = \ pfcp_ies_custom.h \ + pfcp_ies_auto.h \ pfcp_proto.h \ pfcp_strs.h \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I6fbfe1fcd084f2d16334bb3e44d9891d9485d59f Gerrit-Change-Number: 28224 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-upf[master]: pfcp ie: tweak CP Function Features
by neels 07 Jun '22

07 Jun '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/28225 ) Change subject: pfcp ie: tweak CP Function Features ...................................................................... pfcp ie: tweak CP Function Features The spec indicates three bytes of CP Function Features, but both wireshark and ttcn3 expect only one byte. This makes sense because only eight CP F.F. flags are defined. Drop those two always-zero bytes, hence pass the wireshark dissector and ttcn3 parsing without warnings. Change-Id: Icda891a2f3401e58f142f229465403d5dc8befe5 --- M include/osmocom/pfcp/pfcp_ies_custom.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/25/28225/1 diff --git a/include/osmocom/pfcp/pfcp_ies_custom.h b/include/osmocom/pfcp/pfcp_ies_custom.h index 9f26550..c28fdb2 100644 --- a/include/osmocom/pfcp/pfcp_ies_custom.h +++ b/include/osmocom/pfcp/pfcp_ies_custom.h @@ -73,7 +73,7 @@ * printf("%s\n", osmo_pfcp_bits_to_str_c(x.bits, osmo_pfcp_cp_feature_strs)); */ struct osmo_pfcp_ie_cp_function_features { - uint8_t bits[3]; + uint8_t bits[1]; }; /* 3GPP TS 29.244 8.2.37 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Icda891a2f3401e58f142f229465403d5dc8befe5 Gerrit-Change-Number: 28225 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-upf[master]: api: osmo_pfcp_ie_node_id_to_str_c
by neels 07 Jun '22

07 Jun '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/28226 ) Change subject: api: osmo_pfcp_ie_node_id_to_str_c ...................................................................... api: osmo_pfcp_ie_node_id_to_str_c Change-Id: I5c580bc510afce58a03dea0861db9630b063b2ae --- M include/osmocom/pfcp/pfcp_ies_custom.h M src/libosmo-pfcp/pfcp_ies_custom.c 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/26/28226/1 diff --git a/include/osmocom/pfcp/pfcp_ies_custom.h b/include/osmocom/pfcp/pfcp_ies_custom.h index c28fdb2..08e62d1 100644 --- a/include/osmocom/pfcp/pfcp_ies_custom.h +++ b/include/osmocom/pfcp/pfcp_ies_custom.h @@ -48,6 +48,9 @@ }; }; +int osmo_pfcp_ie_node_id_to_str_buf(char *buf, size_t buflen, const struct osmo_pfcp_ie_node_id *node_id); +char *osmo_pfcp_ie_node_id_to_str_c(void *ctx, const struct osmo_pfcp_ie_node_id *node_id); + bool osmo_pfcp_bits_get(const uint8_t *bits, unsigned int bitpos); void osmo_pfcp_bits_set(uint8_t *bits, unsigned int bitpos, bool val); int osmo_pfcp_bits_to_str_buf(char *buf, size_t buflen, const uint8_t *bits, const struct value_string *bit_strs); diff --git a/src/libosmo-pfcp/pfcp_ies_custom.c b/src/libosmo-pfcp/pfcp_ies_custom.c index 660a08d..5975a29 100644 --- a/src/libosmo-pfcp/pfcp_ies_custom.c +++ b/src/libosmo-pfcp/pfcp_ies_custom.c @@ -317,9 +317,8 @@ return 0; } -int osmo_pfcp_enc_to_str_node_id(char *buf, size_t buflen, const void *encode_from) +int osmo_pfcp_ie_node_id_to_str_buf(char *buf, size_t buflen, const struct osmo_pfcp_ie_node_id *node_id) { - const struct osmo_pfcp_ie_node_id *node_id = encode_from; struct osmo_strbuf sb = { .buf = buf, .len = buflen }; switch (node_id->type) { @@ -343,6 +342,16 @@ return sb.chars_needed; } +char *osmo_pfcp_ie_node_id_to_str_c(void *ctx, const struct osmo_pfcp_ie_node_id *node_id) +{ + OSMO_NAME_C_IMPL(ctx, 64, "ERROR", osmo_pfcp_ie_node_id_to_str_buf, node_id) +} + +int osmo_pfcp_enc_to_str_node_id(char *buf, size_t buflen, const void *encode_from) +{ + return osmo_pfcp_ie_node_id_to_str_buf(buf, buflen, encode_from); +} + bool osmo_pfcp_bits_get(const uint8_t *bits, unsigned int bitpos) { unsigned int bytenum = bitpos / 8; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I5c580bc510afce58a03dea0861db9630b063b2ae Gerrit-Change-Number: 28226 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log