- gerrit-log - lists.osmocom.org

Change in osmo-mgw[master]: Don't check rtp timestamps if we are not patching timestamps.
by neels 07 Jun '22

07 Jun '22

Attention is currently required from: keith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28112 ) Change subject: Don't check rtp timestamps if we are not patching timestamps. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: the motivation is to reduce CPU load? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I889fce4c86cffdcbb74b17cd36ccda89c034a824 Gerrit-Change-Number: 28112 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 07 Jun 2022 20:47:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add TC_chan_alloc_algo_{a,de}scending
by neels 07 Jun '22

07 Jun '22

Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28214 ) Change subject: BSC_Tests: add TC_chan_alloc_algo_{a,de}scending ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I understand why a NACK makes things quicker, but it is surely better to model a completely realistic situation than testing "weird" scenarios. BSC_Tests.TC_ratectr_all_available_allocated() does a lot of channel allocations and releases, maybe you can copy-paste some of that? And still my opinion is that adding a vty script in osmo-bsc/tests/handover/ would make testing the channel allocator dramatically easier and faster, also allowing to test N variants of this. I'm here if you need some hints to get started. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic74a9cd264320a9a17648f9331b67fb2c2404122 Gerrit-Change-Number: 28214 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jun 2022 20:46:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: GTP: Send more QoS IE fields by default
by neels 07 Jun '22

07 Jun '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28228 ) Change subject: GTP: Send more QoS IE fields by default ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: commit log: which ttcn3 test suites does this affect, and what was the original motivation? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id195eedf530e2eff753d057ce2302dfb5275bfcd Gerrit-Change-Number: 28228 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jun 2022 20:35:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: tweak comments in rua_to_scu()
by neels 07 Jun '22

07 Jun '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28233 ) Change subject: tweak comments in rua_to_scu() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I227a5e6b869da453fa72ff0eebaa1e95aa9625e6 Gerrit-Change-Number: 28233 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 07 Jun 2022 20:33:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: tweak comments in rua_to_scu()
by neels 07 Jun '22

07 Jun '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28233 ) Change subject: tweak comments in rua_to_scu() ...................................................................... tweak comments in rua_to_scu() Change-Id: I227a5e6b869da453fa72ff0eebaa1e95aa9625e6 --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/33/28233/1 diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index eaa37d4..e4f345e 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -264,14 +264,15 @@ return -EINVAL; } - /* add optional data section, if needed */ + /* If there is RANAP data, include it in the msgb. Usually there is data, but this could also be an SCCP CR + * a.k.a. OSMO_SCU_PRIM_N_CONNECT without RANAP payload. */ if (data && len) { msg->l2h = msgb_put(msg, len); memcpy(msg->l2h, data, len); } - /* Intercept RAB Assignment Response, inform MGW FSM. */ - if (map && !map->is_ps && !release_context_map) { + /* If there is data, see if it is a RAB Assignment message where we need to change the user plane information, + * for RTP mapping via MGW (soon also GTP mapping via UPF). */ if (data && len && map && !map->is_ps && !release_context_map) { message = talloc_zero(map, ranap_message); rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I227a5e6b869da453fa72ff0eebaa1e95aa9625e6 Gerrit-Change-Number: 28233 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-hnbgw[master]: add option to send SCCP CR without payload
by neels 07 Jun '22

07 Jun '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 to look at the new patch set (#4). Change subject: add option to send SCCP CR without payload ...................................................................... add option to send SCCP CR without payload It is reported that a third-party SGSN is rejecting SCCP CR when the SCCP message part exceeds a certain length. The solution is to first send an SCCP CR without payload, and send the payload in a DT later. Add config option hnbgw sccp cr max-payload-len <0-999999> If the RANAP payload surpasses the given length, osmo-hnbgw will first send an SCCP CR without payload, cache the RANAP payload, and put that in an SCCP DT once the SCCP CC is received. The original idea was to limit the size of the entire SCCP part of the message, but I'm currently not sure how to determine that without copying much of the osmo_sccp code. I figured using a limit on the RANAP payload is sufficient. To avoid the error with above third-party SGSN, the easy solution is to set max-payload-len to 0, so that we always get a separate SCCP CR without payload. Related: SYS#5968 Related: I827e081eaacfb8e76684ed1560603e6c8f896c38 (osmo-ttcn3-hacks) Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328 --- M include/osmocom/hnbgw/context_map.h M include/osmocom/hnbgw/hnbgw.h M include/osmocom/hnbgw/hnbgw_rua.h M src/osmo-hnbgw/context_map.c M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/hnbgw_rua.c M src/osmo-hnbgw/hnbgw_vty.c 8 files changed, 122 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/30/28230/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328 Gerrit-Change-Number: 28230 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-hnbgw[master]: allow calling rua_to_scu() without data
by neels 07 Jun '22

07 Jun '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28232 ) Change subject: allow calling rua_to_scu() without data ...................................................................... allow calling rua_to_scu() without data There can be SCCP primitives without payload data, e.g. an "empty" SCCP Connection Request. Patch 'mgw_fsm: add MGW support to osmo-hnbgw' added RANAP message decoding that lacks a guard against NULL data. Fix that: do not try to decode NULL data. Related: SYS#5968 Change-Id: Id755e769e82ace7203460ea1b3c847c2c90d41bf --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/32/28232/1 diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 1943ac0..eaa37d4 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -272,6 +272,7 @@ /* Intercept RAB Assignment Response, inform MGW FSM. */ if (map && !map->is_ps && !release_context_map) { + if (data && len && map && !map->is_ps && !release_context_map) { message = talloc_zero(map, ranap_message); rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id755e769e82ace7203460ea1b3c847c2c90d41bf Gerrit-Change-Number: 28232 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-hnbgw[master]: add option to send SCCP CR without payload
by neels 07 Jun '22

07 Jun '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 ) Change subject: add option to send SCCP CR without payload ...................................................................... Patch Set 3: (1 comment) File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/41e863c1_79f7b23a PS1, Line 274: if (data && len && map && !map->is_ps && !release_context_map) { > So data is already checked above in line 267, which means this should have already been in place bef […] Before this patch, we never called rua_to_scu() with NULL data. So i don't really agree but it's ok, i can separate. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328 Gerrit-Change-Number: 28230 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jun 2022 20:32:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: add option to send SCCP CR without payload
by pespin 07 Jun '22

07 Jun '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 ) Change subject: add option to send SCCP CR without payload ...................................................................... Patch Set 3: (1 comment) File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/677c0f84_7260cada PS1, Line 274: if (data && len && map && !map->is_ps && !release_context_map) { > Because ranap_cn_rx_co_decode() crashes when there is no payload data. So data is already checked above in line 267, which means this should have already been in place before your current patch. Please submit a different patch for this fix, agree? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328 Gerrit-Change-Number: 28230 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jun 2022 16:50:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: add option to send SCCP CR without payload
by neels 07 Jun '22

07 Jun '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 to look at the new patch set (#3). Change subject: add option to send SCCP CR without payload ...................................................................... add option to send SCCP CR without payload It is reported that a third-party SGSN is rejecting SCCP CR when the SCCP message part exceeds a certain length. The solution is to first send an SCCP CR without payload, and send the payload in a DT later. Add config option hnbgw sccp cr max-payload-len <0-999999> If the RANAP payload surpasses the given length, osmo-hnbgw will first send an SCCP CR without payload, cache the RANAP payload, and put that in an SCCP DT once the SCCP CC is received. The original idea was to limit the size of the entire SCCP part of the message, but I'm currently not sure how to determine that without copying much of the osmo_sccp code. I figured using a limit on the RANAP payload is sufficient. To avoid the error with above third-party SGSN, the easy solution is to set max-payload-len to 0, so that we always get a separate SCCP CR without payload. Related: SYS#5968 Related: I827e081eaacfb8e76684ed1560603e6c8f896c38 (osmo-ttcn3-hacks) Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328 --- M include/osmocom/hnbgw/context_map.h M include/osmocom/hnbgw/hnbgw.h M include/osmocom/hnbgw/hnbgw_rua.h M src/osmo-hnbgw/context_map.c M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/hnbgw_rua.c M src/osmo-hnbgw/hnbgw_vty.c 8 files changed, 123 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/30/28230/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328 Gerrit-Change-Number: 28230 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log