- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: Move all SMSCB/CBC vty code to its own file
by laforge 10 Jun '22

10 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28256 ) Change subject: Move all SMSCB/CBC vty code to its own file ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: is this purely cosmetic? might deserve a mention in the commitlog. Is there some follow-up code coming that depends on this? Curious as to why you thought it's worth to move the code around :) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifc7d1693d745dd2a3c31e3ee9610d8c634b50812 Gerrit-Change-Number: 28256 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 05:00:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: hnodeb: Test passing unordered list of RFCIs
by laforge 10 Jun '22

10 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28254 ) Change subject: hnodeb: Test passing unordered list of RFCIs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8961630a1ebe6f6bfee5af0889aa129e491cb2b Gerrit-Change-Number: 28254 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 04:58:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: hnodeb: Update primitives to audio SAPI version 1
by laforge 10 Jun '22

10 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28253 ) Change subject: hnodeb: Update primitives to audio SAPI version 1 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File library/HNBLLIF_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28253/comment/192cc916_cf72… PS2, Line 283: rfcis[i] := i; looks like one indent level too deep? maybe just gerrit visualization... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af56f5e6a70b350f2fffa2e04be384d101b52ed Gerrit-Change-Number: 28253 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 04:57:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: hnodeb: Allow setting hnbllif sapi versions
by laforge 10 Jun '22

10 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28252 ) Change subject: hnodeb: Allow setting hnbllif sapi versions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I24d757d3dfa4148537db49d70c525e1a81836426 Gerrit-Change-Number: 28252 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 04:57:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: hnodeb: Fix passing pars to f_start_handler()
by laforge 10 Jun '22

10 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28255 ) Change subject: hnodeb: Fix passing pars to f_start_handler() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I05bb47dc12b4544a6f2d4fc1fadc9e68da374f8b Gerrit-Change-Number: 28255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 04:56:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnodeb[master]: llsk: Validate received SAPI versions at startup
by laforge 10 Jun '22

10 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/28250 ) Change subject: llsk: Validate received SAPI versions at startup ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/hnodeb/hnodeb.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/28250/comment/e03e50a4_cda93b3b PS1, Line 95: uint16_t sapi_version_iuh; might again make a nice sub-struct for llsk.sapi_version.{iuh,gtp,audio}. Just saying, not a requirement... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/28250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I172abfee3bfadb383aa6bce6fe76306291c7cd7f Gerrit-Change-Number: 28250 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 04:55:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnodeb[master]: hnb: move llsk fields inside substruct
by laforge 10 Jun '22

10 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/28242 ) Change subject: hnb: move llsk fields inside substruct ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/28242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Idfe644a7c2eccd94b602816a86e38b56264141af Gerrit-Change-Number: 28242 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 04:54:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnodeb[master]: llsk: Fix typo in log message
by laforge 10 Jun '22

10 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/28241 ) Change subject: llsk: Fix typo in log message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/28241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I3c8be85e56df23cd68e58f0112238647add3d97f Gerrit-Change-Number: 28241 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 04:53:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: APDU parsing support for GlobalPlatform
by laforge 10 Jun '22

10 Jun '22

Attention is currently required from: Karsten Ohme. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28248 ) Change subject: APDU parsing support for GlobalPlatform ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: quite interesting. Do you have any idea what it is using this for? After all, there is no requirement in 3GPP that a SIM/USIM/UICC must be a java card or that it must support global platform? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib734fc852e7b63b9efdc414adccbd796a572eb55 Gerrit-Change-Number: 28248 Gerrit-PatchSet: 1 Gerrit-Owner: Karsten Ohme <wider.stand(a)gmx.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Karsten Ohme <wider.stand(a)gmx.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 04:53:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: install libosmo-gtlv, libosmo-pfcp
by laforge 10 Jun '22

10 Jun '22

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28245 ) Change subject: install libosmo-gtlv, libosmo-pfcp ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS1: > Personally, I don't see a need to spend time on moving code between repositories. […] It is a difficult question, and as neels has pointed out, one that has not really been properly resolved in our overall repository structure. * the libosmo-mgcp-client example is not applicable, as it really is only needed by code talking to osmo-mgw; likewise libosmo-gsup in osmo-hlr.git. Those are both fine, IMHO. * we do have other "strange" examples like osmo-stp being in libosmo-sccp.git. This is odd and should have been done properly from the start, as cleaning this up later means touching every bit of our infrastructure (from packaging recipes to OBS jobs, jenkins jobs and finally ansible playbooks, sysmoNITB stuff, etc.). So if we already know that libosmo-pfcp is [in the osmocom universe] only used internally by UPF or to talk to osmo-upf [or maybe some other upf] it is fine to keep it in osmo-upf.git. This reflects the MGCP-client, GSUP-client or even libgtp/ggsn situation. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6 Gerrit-Change-Number: 28245 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 04:12:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log