- gerrit-log - lists.osmocom.org

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by lynxis lazus 10 Nov '25

10 Nov '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 8: (10 comments) Patchset: PS8: @pespin: I like to keep most of the #ifdef / #endif out of the code. The header file already takes care if the feature isn't enabled. Why do you want to have the #ifdef everywhere in the code? The header file transform it into no-ops. File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/b57d649e_3fcad… : PS8, Line 30: void *talloc_asn1_ctx; > why is this added? Because the library needs it. File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/cc96cf5f_86b02… : PS8, Line 315: /* update TCAP Transaction Tracking (Rx) */ > #ifdef WITH_TCAP_LOADSHARING no, not needed. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/ccabd2eb_642d9… : PS8, Line 316: ss7_asp_tcap_rx_sccp(as, asp, opc, dpc, msg); > This function naming is a bit misleading since it's not even known whether there's TCAP in the msg.. […] I want to keep the code changes to the other files minimal. What would you suggest instead? https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/140bbf84_334c5… : PS8, Line 360: case IPAC_PROTO_OSMO: > #ifdef WITH_TCAP_LOADSHARING I could move it further upwards. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/349533d8_c8e32… : PS8, Line 368: if (hh_ext->proto == IPAC_PROTO_EXT_TCAP_ROUTING) { > (probably a switch case here will turn out cleaner together with the ifdef. […] yes, I can use switch/case there. File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/763c4907_f6e3e… : PS8, Line 50: #include "ss7_as_loadshare_tcap.h" > #ifdef WITH_TCAP_LOADSHARINGActually, I don't see this header being used in this file. […] I prefer the style how it is currently. It reduces the usage of #ifdef in the common code. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/125b9129_31648… : PS8, Line 343: if (!xua) > This looks unrelated to this commit? Seems you want to add another commit describing this. Ack. File tests/tcap/tcap_transaction_tracking_test.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6c74d55e_52a73… : PS6, Line 19: typedef void (* tcap_trxn_track_test_func_t)(void); > space prohibited after that '*' (ctx:BxW) fixed https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/7aa05f39_9a42b… : PS6, Line 19: typedef void (* tcap_trxn_track_test_func_t)(void); > do not add new typedefs Won't fix. I think it's fine here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:05:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Add test for tcap decoding/encoding
by lynxis lazus 10 Nov '25

10 Nov '25

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email ) Change subject: Add test for tcap decoding/encoding ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Agreeing with Pau. Unit tests for TCAP codec should be in libosmo-asn1-tcap.git. […] It ensures the library works correctly. We had issues in the past with linking again asn1 libraries. I don't oppose against adding unit tests to asn1-tcap, but keeping this simple test here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2 Gerrit-Change-Number: 41308 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 16:51:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: sync_obs_projects: fix for OSC 1.12.1
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email ) Change subject: OBS: sync_obs_projects: fix for OSC 1.12.1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1236a065e2998fb46343df3968f7bb4dabeea55a Gerrit-Change-Number: 41393 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 16:05:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: OBS: sync_obs_projects: fix for OSC 1.12.1
by osmith 10 Nov '25

10 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email ) Change subject: OBS: sync_obs_projects: fix for OSC 1.12.1 ...................................................................... OBS: sync_obs_projects: fix for OSC 1.12.1 Since the Docker image used by sync_obs_projects was changed from Debian 12 to 13, several "osc" commands have in their output: fatal: not a git repository (or any of the parent directories): .git Work around this by switching to the temp directory and initializing a git repository there, with an "origin" remote that osc also expects to exist. Fixes: 6ac535b8 ("OBS: set default distro to debian 13") Change-Id: I1236a065e2998fb46343df3968f7bb4dabeea55a --- M scripts/obs/sync_obs_projects.py 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/93/41393/1 diff --git a/scripts/obs/sync_obs_projects.py b/scripts/obs/sync_obs_projects.py index d494ed4..a82a47c 100755 --- a/scripts/obs/sync_obs_projects.py +++ b/scripts/obs/sync_obs_projects.py @@ -334,6 +334,12 @@ os.makedirs(lib.config.path_temp, exist_ok=True) + # OSC 1.12.1 from Debian Trixie fails if the current working dir isn't a + # git repository or is missing an "origin" remote + os.chdir(lib.config.path_temp) + lib.run_cmd(["git", "init"]) + lib.run_cmd(["git", "remote", "add", "origin", "."]) + # Get destination OBS projects lib.osc.set_apiurl(lib.args.to_apiurl, None) dest_projects = lib.osc.get_projects() -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1236a065e2998fb46343df3968f7bb4dabeea55a Gerrit-Change-Number: 41393 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: Add ER-GSM band support
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email ) Change subject: Add ER-GSM band support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558 Gerrit-Change-Number: 41361 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 13:43:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-dev[master]: gen_makefile: python: run build in venv too
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email ) Change subject: gen_makefile: python: run build in venv too ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Idbd826d65267c05dcf2d82f7429d53a52686d737 Gerrit-Change-Number: 41391 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 13:40:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: RSSI app: Use correct BSIC for RACH bursts
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email ) Change subject: RSSI app: Use correct BSIC for RACH bursts ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19 Gerrit-Change-Number: 41358 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Nov 2025 13:38:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: mobile app: Indicate ER-GSM band support in MS classmark 3
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) Change subject: mobile app: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 13:35:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: Add ER-GSM band support to all relevant applications
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email ) Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Patch Set 4: (1 comment) File src/host/layer23/src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/cfb921e7_5417f943?u… : PS3, Line 406: return gsm48_decode_freq_list(f, cd, len, mask, frqt); > sounds like libosmocore will require support for eg_gsm in this API? Just to be sure, did you make sure this API in libosmocore.git master as well as osmocom-bb copy is now supporting the new frequencies? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 13:35:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954)
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41392?usp=email ) Change subject: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2fbddc523e72c6d6134e8a9d8132ad58266ce0db Gerrit-Change-Number: 41392 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 13:32:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log