- gerrit-log - lists.osmocom.org

Change in osmo-cbc[master]: Add initial SBc-AP support to osmo-cbc
by pespin 14 Jul '22

14 Jul '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602 to look at the new patch set (#5). Change subject: Add initial SBc-AP support to osmo-cbc ...................................................................... Add initial SBc-AP support to osmo-cbc This patch makes use of the newly introduced sbcap library, and introduces new code (and extends existing one) to handle all the aspects of MME peers talking SBc-AP and its underlaying SCTP connection. This commit doesn't aim to implement all the SBc-AP features, but to implement a minimal subset of features already available for CBSP in osmo-cbc, in order to have similar support level for both 2G and 4G networks. Related: OS#4945 Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9 --- M configure.ac M debian/control M doc/examples/osmo-cbc/osmo-cbc.cfg M include/osmocom/cbc/Makefile.am M include/osmocom/cbc/cbc_data.h M include/osmocom/cbc/internal.h A include/osmocom/cbc/sbcap_msg.h A include/osmocom/cbc/sbcap_server.h M src/Makefile.am M src/cbc_data.c M src/cbc_main.c M src/cbc_vty.c M src/message_handling.c A src/sbcap_msg.c A src/sbcap_server.c A src/sbcap_server_fsm.c M src/smscb_message_fsm.c M src/smscb_peer_fsm.c 18 files changed, 1,316 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/02/28602/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9 Gerrit-Change-Number: 28602 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in ...osmo_dia2gsup[master]: debian: add packaging
by laforge 14 Jul '22

14 Jul '22

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28605 ) Change subject: debian: add packaging ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28605/comment/57181e80_… PS1, Line 10: rebar3 I would simply import/backport the debian unstable rebar3 dpkg into our repo and make this package depend on it. Doesn't help for 3rd party dependencies, but given that there is a rebar3 package available, IMHO we should use it. File debian/rules: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28605/comment/8fe02b02_… PS1, Line 3: build: I'm surprised you didn't use any of the debian/rules from my branch. The clean rule removes also .eunit in there (not sure if it is created?) and rebar3 eunit should be in the 'test' target, shouldn't it? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ic55bca1260f992d0ed8583e7c7fe948ba0160d4d Gerrit-Change-Number: 28605 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 17:20:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in pysim[master]: pySim/ts_102_222.py: remove ununsed imports from 'cmd2'
by laforge 14 Jul '22

14 Jul '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/28599 ) Change subject: pySim/ts_102_222.py: remove ununsed imports from 'cmd2' ...................................................................... pySim/ts_102_222.py: remove ununsed imports from 'cmd2' Change-Id: If6c686c8248cd0ad4edb68b84886a6f5f558d0f7 --- M pySim/ts_102_222.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/pySim/ts_102_222.py b/pySim/ts_102_222.py index c7cff85..3c57e5b 100644 --- a/pySim/ts_102_222.py +++ b/pySim/ts_102_222.py @@ -20,7 +20,6 @@ from typing import List import cmd2 -from cmd2 import style, fg, bg from cmd2 import CommandSet, with_default_category, with_argparser import argparse -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6c686c8248cd0ad4edb68b84886a6f5f558d0f7 Gerrit-Change-Number: 28599 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in pysim[master]: pySim/ts_102_222.py: remove ununsed imports from 'cmd2'
by laforge 14 Jul '22

14 Jul '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28599 ) Change subject: pySim/ts_102_222.py: remove ununsed imports from 'cmd2' ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6c686c8248cd0ad4edb68b84886a6f5f558d0f7 Gerrit-Change-Number: 28599 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 17:14:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: pySim-shell.py: remove unused imports of 'bg' from 'cmd2'
by laforge 14 Jul '22

14 Jul '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/28598 ) Change subject: pySim-shell.py: remove unused imports of 'bg' from 'cmd2' ...................................................................... pySim-shell.py: remove unused imports of 'bg' from 'cmd2' Change-Id: Ic2a73a98f322be391e54215bc5fc3358776da0ae --- M pySim-shell.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim-shell.py b/pySim-shell.py index e52c4ef..33332a2 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -23,7 +23,7 @@ import traceback import cmd2 -from cmd2 import style, fg, bg +from cmd2 import style, fg from cmd2 import CommandSet, with_default_category, with_argparser import argparse -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic2a73a98f322be391e54215bc5fc3358776da0ae Gerrit-Change-Number: 28598 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in pysim[master]: pySim-shell.py: remove unused imports of 'bg' from 'cmd2'
by laforge 14 Jul '22

14 Jul '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28598 ) Change subject: pySim-shell.py: remove unused imports of 'bg' from 'cmd2' ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic2a73a98f322be391e54215bc5fc3358776da0ae Gerrit-Change-Number: 28598 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 17:14:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: pySim/ts_102_222.py: remove ununsed imports from 'cmd2'
by laforge 14 Jul '22

14 Jul '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28599 ) Change subject: pySim/ts_102_222.py: remove ununsed imports from 'cmd2' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6c686c8248cd0ad4edb68b84886a6f5f558d0f7 Gerrit-Change-Number: 28599 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 17:14:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-cbc[master]: Add initial SBc-AP support to osmo-cbc
by laforge 14 Jul '22

14 Jul '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602 ) Change subject: Add initial SBc-AP support to osmo-cbc ...................................................................... Patch Set 4: (5 comments) File src/cbc_main.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/9df020d2_c50dfa38 PS4, Line 284: perr copy+paste error. Should be SBc-AP ad not CBSP. File src/cbc_vty.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/ae9e75f5_8999d510 PS4, Line 539: cfg_peer_proto why is it deprecated? File src/message_handling.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/7318acd9_e6164e7f PS4, Line 151: CBSP copy+paste File src/sbcap_server.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/7bbc5e3e_da5ee4d7 PS4, Line 33: //#include <osmocom/gsm/sbcap.h> : //#include <osmocom/gsm/protocol/gsm_48_049.h> those can certainly go? File src/sbcap_server_fsm.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/be04cf5b_2eeb5a71 PS4, Line 25: / remove? -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9 Gerrit-Change-Number: 28602 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 17:13:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-cbc[master]: Add unit tests for sbcap
by laforge 14 Jul '22

14 Jul '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28601 ) Change subject: Add unit tests for sbcap ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d Gerrit-Change-Number: 28601 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 17:08:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-cbc[master]: Add sbcap library
by laforge 14 Jul '22

14 Jul '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28600 ) Change subject: Add sbcap library ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: If76f8619a9b2d46af6d94b8ae49348b8514e53aa Gerrit-Change-Number: 28600 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 17:07:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log